mbox series

[net-next,0/2] net trigraph fixes for W=1

Message ID 20201028002235.928999-1-andrew@lunn.ch (mailing list archive)
Headers show
Series net trigraph fixes for W=1 | expand

Message

Andrew Lunn Oct. 28, 2020, 12:22 a.m. UTC
Both the Marvell mvneta and rose driver accidentally make use of a
trigraph. When compiling with W=1 an warning is issues because we have
trigraphs disabled. So for mvneta, which is only a diagnostic print,
remove the trigraph. For rose, since this is a sysfs file, escape the
sequence to make it clear it is not supposed to be trigraph.

Andrew Lunn (2):
  net: marvell: mvneta: Fix trigraph warning with W=1
  net: rose: Escape trigraph to fix warning with W=1

 drivers/net/ethernet/marvell/mvneta.c | 2 +-
 net/rose/af_rose.c                    | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

Comments

Jakub Kicinski Oct. 29, 2020, 9:47 p.m. UTC | #1
On Wed, 28 Oct 2020 01:22:33 +0100 Andrew Lunn wrote:
> Both the Marvell mvneta and rose driver accidentally make use of a
> trigraph. When compiling with W=1 an warning is issues because we have
> trigraphs disabled. So for mvneta, which is only a diagnostic print,
> remove the trigraph. For rose, since this is a sysfs file, escape the
> sequence to make it clear it is not supposed to be trigraph.

Feel free to resubmit, with the mentions of W=1 adjusted. 
No preference here.