From patchwork Fri Oct 30 17:46:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rohit Maheshwari X-Patchwork-Id: 11870433 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_GIT autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2D4C4741F for ; Fri, 30 Oct 2020 17:47:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0B01F2076D for ; Fri, 30 Oct 2020 17:47:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726779AbgJ3RrR (ORCPT ); Fri, 30 Oct 2020 13:47:17 -0400 Received: from stargate.chelsio.com ([12.32.117.8]:15626 "EHLO stargate.chelsio.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725844AbgJ3RrR (ORCPT ); Fri, 30 Oct 2020 13:47:17 -0400 Received: from localhost.localdomain (redhouse.blr.asicdesigners.com [10.193.185.57]) by stargate.chelsio.com (8.13.8/8.13.8) with ESMTP id 09UHl9pM020669; Fri, 30 Oct 2020 10:47:10 -0700 From: Rohit Maheshwari To: kuba@kernel.org, netdev@vger.kernel.org, davem@davemloft.net Cc: secdev@chelsio.com, Rohit Maheshwari Subject: [net v3 00/10] cxgb4/ch_ktls: Fixes in nic tls code Date: Fri, 30 Oct 2020 23:16:58 +0530 Message-Id: <20201030174708.9578-1-rohitm@chelsio.com> X-Mailer: git-send-email 2.18.1 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org This series helps in fixing multiple nic ktls issues. Series is broken into 10 patches. Patch 1 avoids deciding tls packet based on decrypted bit. If its a retransmit packet which has tls handshake and finish (for encryption), decrypted bit won't be set there, and so we can't rely on decrypted bit. Patch 2 helps supporting linear skb. SKBs were assumed non-linear. Corrected the length extraction. Patch 3 fixes the checksum offload update in WR. Patch 4 corrects the usage of GFP_KERNEL and replaces it with GFP_ATOMIC. Patch 5 fixes kernel panic happening due to creating new skb for each record. As part of fix driver will use same skb to send out one tls record (partial data) of the same SKB. Patch 6 avoids sending extra data which is used to make a record 16 byte aligned. We don't need to retransmit those extra few bytes. Patch 7 handles the cases where retransmit packet has tls starting exchanges which are prior to tls start marker. Patch 8 handles the small packet case which has partial TAG bytes only. HW can't handle those, hence using sw crypto for such pkts. Patch 9 corrects the potential tcb update problem. Patch 10 stops the queue if queue reaches threshold value. v1->v2: - Corrected fixes tag issue. - Marked chcr_ktls_sw_fallback() static. v2->v3: - Replaced GFP_KERNEL with GFP_ATOMIC. - Removed mixed fixes. Rohit Maheshwari (10): cxgb4/ch_ktls: decrypted bit is not enough ch_ktls: Correction in finding correct length ch_ktls: Update cheksum information ch_ktls: incorrect use of GFP_KERNEL cxgb4/ch_ktls: creating skbs causes panic ch_ktls: Correction in middle record handling ch_ktls: packet handling prior to start marker ch_ktls/cxgb4: handle partial tag alone SKBs ch_ktls: tcb update fails sometimes ch_ktls: stop the txq if reaches threshold drivers/net/ethernet/chelsio/cxgb4/cxgb4.h | 3 + .../ethernet/chelsio/cxgb4/cxgb4_debugfs.c | 2 + .../net/ethernet/chelsio/cxgb4/cxgb4_main.c | 1 + .../net/ethernet/chelsio/cxgb4/cxgb4_uld.h | 6 + drivers/net/ethernet/chelsio/cxgb4/sge.c | 111 ++- .../chelsio/inline_crypto/ch_ktls/chcr_ktls.c | 772 ++++++++++-------- .../chelsio/inline_crypto/ch_ktls/chcr_ktls.h | 1 + 7 files changed, 532 insertions(+), 364 deletions(-)