mbox series

[net-next,v4,0/2] devlink: move common flash_update calls to core

Message ID 20201118190636.1235045-1-jacob.e.keller@intel.com (mailing list archive)
Headers show
Series devlink: move common flash_update calls to core | expand

Message

Jacob Keller Nov. 18, 2020, 7:06 p.m. UTC 
This series moves a couple common pieces done by all drivers of the
->flash_update interface into devlink.c flash update handler. Specifically,
the core code will now request_firmware and
devlink_flash_update_(begin|end)_notify.

This cleanup is intended to simplify driver implementations so that they
have less work to do and are less capable of doing the "wrong" thing.

For request_firmware, this simplification is done as it is not expected that
drivers would do anything else. It also standardizes all drivers so that
they use the same interface (request_firmware, as opposed to
request_firmware_direct), and allows reporting the netlink extended ack with
the file name attribute.

For status notification, this change prevents drivers from sending a status
message without properly sending the status end notification. The current
userspace implementation of devlink relies on this end notification to
properly close the flash update channel. Without this, the flash update
process may hang indefinitely. By moving the begin and end calls into the
core code, it is no longer possible for a driver author to get this wrong.

Changes since v3
* picked up acked-by and reviewed-by comments
* fixed the ionic driver to leave the print statement in place

For the original patch that moved request_firmware, see [1]. For the v2 see
[2]. For further discussion of the issues with devlink flash status see [3].
For v3 see [4].

Cc: Jiri Pirko <jiri@nvidia.com>
Cc: Michael Chan <michael.chan@broadcom.com>
Cc: Shannon Nelson <snelson@pensando.io>
Cc: Saeed Mahameed <saeedm@nvidia.com>
Cc: Boris Pismenny <borisp@nvidia.com>
Cc: Bin Luo <luobin9@huawei.com>
Cc: Jakub Kicinksi <kuba@kernel.org>

[1] https://lore.kernel.org/netdev/20201113000142.3563690-1-jacob.e.keller@intel.com/
[2] https://lore.kernel.org/netdev/20201113224559.3910864-1-jacob.e.keller@intel.com/
[3] https://lore.kernel.org/netdev/6352e9d3-02af-721e-3a54-ef99a666be29@intel.com/
[4] https://lore.kernel.org/netdev/20201117200820.854115-1-jacob.e.keller@intel.com/

Jacob Keller (2):
  devlink: move request_firmware out of driver
  devlink: move flash end and begin to core devlink

 .../net/ethernet/broadcom/bnxt/bnxt_devlink.c |  4 +--
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.c | 33 +++++++++++------
 .../net/ethernet/broadcom/bnxt/bnxt_ethtool.h |  4 +--
 .../net/ethernet/huawei/hinic/hinic_devlink.c | 12 +------
 drivers/net/ethernet/intel/ice/ice_devlink.c  | 17 +--------
 .../net/ethernet/mellanox/mlx5/core/devlink.c | 11 +-----
 .../net/ethernet/mellanox/mlxfw/mlxfw_fsm.c   |  3 --
 drivers/net/ethernet/mellanox/mlxsw/core.c    | 11 +-----
 .../net/ethernet/netronome/nfp/nfp_devlink.c  |  2 +-
 drivers/net/ethernet/netronome/nfp/nfp_main.c | 17 ++-------
 drivers/net/ethernet/netronome/nfp/nfp_main.h |  2 +-
 .../ethernet/pensando/ionic/ionic_devlink.c   |  2 +-
 .../ethernet/pensando/ionic/ionic_devlink.h   |  2 +-
 .../net/ethernet/pensando/ionic/ionic_fw.c    | 14 ++------
 drivers/net/netdevsim/dev.c                   |  2 --
 include/net/devlink.h                         |  9 +++--
 net/core/devlink.c                            | 36 ++++++++++++++-----
 17 files changed, 68 insertions(+), 113 deletions(-)


base-commit: ed30aef3c864f99111e16d4ea5cf29488d99a278

Comments

Jakub Kicinski Nov. 20, 2020, 5:43 a.m. UTC | #1 
On Wed, 18 Nov 2020 11:06:34 -0800 Jacob Keller wrote:
> This series moves a couple common pieces done by all drivers of the
> ->flash_update interface into devlink.c flash update handler. Specifically,  
> the core code will now request_firmware and
> devlink_flash_update_(begin|end)_notify.
> 
> This cleanup is intended to simplify driver implementations so that they
> have less work to do and are less capable of doing the "wrong" thing.
> 
> For request_firmware, this simplification is done as it is not expected that
> drivers would do anything else. It also standardizes all drivers so that
> they use the same interface (request_firmware, as opposed to
> request_firmware_direct), and allows reporting the netlink extended ack with
> the file name attribute.
> 
> For status notification, this change prevents drivers from sending a status
> message without properly sending the status end notification. The current
> userspace implementation of devlink relies on this end notification to
> properly close the flash update channel. Without this, the flash update
> process may hang indefinitely. By moving the begin and end calls into the
> core code, it is no longer possible for a driver author to get this wrong.
> 
> Changes since v3
> * picked up acked-by and reviewed-by comments
> * fixed the ionic driver to leave the print statement in place
> 
> For the original patch that moved request_firmware, see [1]. For the v2 see
> [2]. For further discussion of the issues with devlink flash status see [3].
> For v3 see [4].

Applied, thanks!