| Message ID | 20201120084106.10046-1-ceggers@arri.de (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: ptp: introduce common defines for PTP message types | expand |
On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote: > This series introduces commen defines for PTP event messages. Driver > internal defines are removed and some uses of magic numbers are replaced > by the new defines. Nice cleanup! Reviewed-by: Richard Cochran <richardcochran@gmail.com> Thanks, Richard
On Fri, Nov 20, 2020 at 09:41:03AM +0100, Christian Eggers wrote: > This series introduces commen defines for PTP event messages. Driver > internal defines are removed and some uses of magic numbers are replaced > by the new defines. > > Changes v2 --> v3 > ------------------ > - extend commit description for ptp_ines (Jacob Keller) > > Changes v1 --> v2 > ------------------ > - use defines instead of an enum (Richard Cochran) > - no changes necessary for dp63640 > - add cover message (Vladimir Oltean) I understand that you don't want to spend a lifetime on this, but I see that there are more drivers which you did not touch. is_sync() in drivers/net/phy/dp83640.c can be made to return ptp_get_msgtype(hdr, type) == PTP_MSGTYPE_SYNC; this can be removed from drivers/net/ethernet/mellanox/mlxsw/spectrum_ptp.h: enum { MLXSW_SP_PTP_MESSAGE_TYPE_SYNC, MLXSW_SP_PTP_MESSAGE_TYPE_DELAY_REQ, MLXSW_SP_PTP_MESSAGE_TYPE_PDELAY_REQ, MLXSW_SP_PTP_MESSAGE_TYPE_PDELAY_RESP, }; Either way, this can also be applied as-is, since there's nothing wrong with it.
On Fri, 20 Nov 2020 09:41:03 +0100 Christian Eggers wrote: > This series introduces commen defines for PTP event messages. Driver > internal defines are removed and some uses of magic numbers are replaced > by the new defines. Applied, thanks!