| Message ID | 20201203005807.486320-1-kpsingh@chromium.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | Fixes for ima selftest | expand |
On Wed, Dec 2, 2020 at 4:58 PM KP Singh <kpsingh@chromium.org> wrote: > > From: KP Singh <kpsingh@google.com> > > # v2 -> v3 > > * Added missing tags. > * Indentation fixes + some other fixes suggested by Andrii. > * Re-indent file to tabs. > > # What? > > * Fixes to work in busybox shell (tested on the one used by BPF CI). > * Ensure that securityfs is mounted before updating the ima policy > * Add missing config deps. > KP, please take a look at other cover letters to get a better idea of how they usually look like. It has to be a human-readable overview of why the patch set was posted and what problem it is solving. List of action items without any context is not the best format. > > KP Singh (4): > selftests/bpf: Update ima_setup.sh for busybox > selftests/bpf: Ensure securityfs mount before writing ima policy > selftests/bpf: Add config dependency on BLK_DEV_LOOP > selftests/bpf: Indent ima_setup.sh with tabs. > > tools/testing/selftests/bpf/config | 1 + > tools/testing/selftests/bpf/ima_setup.sh | 107 +++++++++++++---------- > 2 files changed, 64 insertions(+), 44 deletions(-) > > -- > 2.29.2.576.ga3fc446d84-goog >
On Thu, Dec 3, 2020 at 6:44 AM Andrii Nakryiko <andrii.nakryiko@gmail.com> wrote: > > On Wed, Dec 2, 2020 at 4:58 PM KP Singh <kpsingh@chromium.org> wrote: > > > > From: KP Singh <kpsingh@google.com> > > > > # v2 -> v3 > > > > * Added missing tags. > > * Indentation fixes + some other fixes suggested by Andrii. > > * Re-indent file to tabs. > > > > # What? > > > > * Fixes to work in busybox shell (tested on the one used by BPF CI). > > * Ensure that securityfs is mounted before updating the ima policy > > * Add missing config deps. > > > > KP, please take a look at other cover letters to get a better idea of > how they usually look like. It has to be a human-readable overview of > why the patch set was posted and what problem it is solving. List of > action items without any context is not the best format. Sure, I thought the individual commit messages were sufficient context but I can add a better one here. > > > > > KP Singh (4): > > selftests/bpf: Update ima_setup.sh for busybox > > selftests/bpf: Ensure securityfs mount before writing ima policy > > selftests/bpf: Add config dependency on BLK_DEV_LOOP > > selftests/bpf: Indent ima_setup.sh with tabs. > > > > tools/testing/selftests/bpf/config | 1 + > > tools/testing/selftests/bpf/ima_setup.sh | 107 +++++++++++++---------- > > 2 files changed, 64 insertions(+), 44 deletions(-) > > > > -- > > 2.29.2.576.ga3fc446d84-goog > >
From: KP Singh <kpsingh@google.com> # v2 -> v3 * Added missing tags. * Indentation fixes + some other fixes suggested by Andrii. * Re-indent file to tabs. # What? * Fixes to work in busybox shell (tested on the one used by BPF CI). * Ensure that securityfs is mounted before updating the ima policy * Add missing config deps. KP Singh (4): selftests/bpf: Update ima_setup.sh for busybox selftests/bpf: Ensure securityfs mount before writing ima policy selftests/bpf: Add config dependency on BLK_DEV_LOOP selftests/bpf: Indent ima_setup.sh with tabs. tools/testing/selftests/bpf/config | 1 + tools/testing/selftests/bpf/ima_setup.sh | 107 +++++++++++++---------- 2 files changed, 64 insertions(+), 44 deletions(-)