[net-next,0/4] enetc: code cleanups

Message

Michael Walle Dec. 15, 2020, 9:21 p.m. UTC

This are some code cleanups in the MDIO part of the enetc. They are
intended to make the code more readable.

Michael Walle (4):
  enetc: drop unneeded indirection
  enetc: don't use macro magic for the readx_poll_timeout() callback
  enetc: drop MDIO_DATA() macro
  enetc: reorder macros and functions

 .../net/ethernet/freescale/enetc/enetc_mdio.c | 61 +++++++++----------
 1 file changed, 29 insertions(+), 32 deletions(-)

Comments

Vladimir Oltean Dec. 16, 2020, 7:25 p.m. UTC | #1

Hi Michael,

On Tue, Dec 15, 2020 at 10:21:56PM +0100, Michael Walle wrote:
> This are some code cleanups in the MDIO part of the enetc. They are
> intended to make the code more readable.

Nice cleanup, please resend it after net-next opens again.

Michael Walle Dec. 16, 2020, 7:33 p.m. UTC | #2

Am 2020-12-16 20:25, schrieb Vladimir Oltean:
> Hi Michael,
> 
> On Tue, Dec 15, 2020 at 10:21:56PM +0100, Michael Walle wrote:
>> This are some code cleanups in the MDIO part of the enetc. They are
>> intended to make the code more readable.
> 
> Nice cleanup, please resend it after net-next opens again.

Ah, I thought it will be picked up automatically after the merge
window is closed, no?

-michael

Andrew Lunn Dec. 16, 2020, 11:45 p.m. UTC | #3

> Ah, I thought it will be picked up automatically after the merge
> window is closed, no?

Nope. With netdev, if it is not merged in about 3 days, it needs to be
reposted. And it might need a rebased after the merge window closes
and net-next reopens.

	  Andrew