mbox series

[RFC,net-next,0/9] Get rid of the switchdev transactional model

Message ID 20201217015822.826304-1-vladimir.oltean@nxp.com (mailing list archive)
Headers show
Series Get rid of the switchdev transactional model | expand

Message

Vladimir Oltean Dec. 17, 2020, 1:58 a.m. UTC 
This series comes after the late realization that the prepare/commit
separation imposed by switchdev does not help literally anybody:
https://patchwork.kernel.org/project/netdevbpf/patch/20201212203901.351331-1-vladimir.oltean@nxp.com/

We should kill it before it inflicts even more damage to the error
handling logic in drivers.

Vladimir Oltean (9):
  net: switchdev: remove the transaction structure from port object
    notifiers
  net: switchdev: delete switchdev_port_obj_add_now
  net: switchdev: remove the transaction structure from port attributes
  net: dsa: remove the transactional logic from ageing time notifiers
  net: dsa: remove the transactional logic from MDB entries
  net: dsa: remove the transactional logic from VLAN objects
  net: dsa: remove obsolete comment about switchdev transactions
  mlxsw: spectrum_switchdev: remove transactional logic for VLAN objects
  net: switchdev: delete the transaction object

 drivers/net/dsa/b53/b53_common.c              |  42 +++----
 drivers/net/dsa/b53/b53_priv.h                |  15 +--
 drivers/net/dsa/bcm_sf2.c                     |   2 -
 drivers/net/dsa/bcm_sf2_cfp.c                 |   7 +-
 drivers/net/dsa/dsa_loop.c                    |  32 ++----
 drivers/net/dsa/hirschmann/hellcreek.c        |  18 +--
 drivers/net/dsa/lan9303-core.c                |  12 +-
 drivers/net/dsa/lantiq_gswip.c                |  40 +++----
 drivers/net/dsa/microchip/ksz8795.c           |  14 +--
 drivers/net/dsa/microchip/ksz9477.c           |  40 +++----
 drivers/net/dsa/microchip/ksz_common.c        |  23 +---
 drivers/net/dsa/microchip/ksz_common.h        |   8 +-
 drivers/net/dsa/mt7530.c                      |  20 +---
 drivers/net/dsa/mv88e6xxx/chip.c              |  72 ++++++------
 drivers/net/dsa/ocelot/felix.c                |  32 +++---
 drivers/net/dsa/qca8k.c                       |  20 +---
 drivers/net/dsa/realtek-smi-core.h            |   9 +-
 drivers/net/dsa/rtl8366.c                     |  36 +++---
 drivers/net/dsa/rtl8366rb.c                   |   1 -
 drivers/net/dsa/sja1105/sja1105.h             |   3 +-
 drivers/net/dsa/sja1105/sja1105_devlink.c     |   9 +-
 drivers/net/dsa/sja1105/sja1105_main.c        |  48 +++-----
 .../marvell/prestera/prestera_switchdev.c     |  44 ++------
 .../mellanox/mlxsw/spectrum_switchdev.c       | 102 ++++-------------
 drivers/net/ethernet/mscc/ocelot.c            |  32 ++----
 drivers/net/ethernet/mscc/ocelot_net.c        |  39 ++-----
 drivers/net/ethernet/rocker/rocker.h          |   6 +-
 drivers/net/ethernet/rocker/rocker_main.c     |  61 +++--------
 drivers/net/ethernet/rocker/rocker_ofdpa.c    |  23 ++--
 drivers/net/ethernet/ti/cpsw_switchdev.c      |  37 ++-----
 drivers/staging/fsl-dpaa2/ethsw/ethsw.c       |  80 +++++---------
 include/net/dsa.h                             |  11 +-
 include/net/switchdev.h                       |  24 +---
 include/soc/mscc/ocelot.h                     |   3 +-
 net/dsa/dsa_priv.h                            |  27 ++---
 net/dsa/port.c                                | 103 +++++++-----------
 net/dsa/slave.c                               |  56 +++-------
 net/dsa/switch.c                              |  74 ++-----------
 net/switchdev/switchdev.c                     | 101 ++---------------
 39 files changed, 408 insertions(+), 918 deletions(-)

Comments

Linus Walleij Dec. 27, 2020, 1:32 p.m. UTC | #1 
On Thu, Dec 17, 2020 at 2:59 AM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:

> This series comes after the late realization that the prepare/commit
> separation imposed by switchdev does not help literally anybody:
> https://patchwork.kernel.org/project/netdevbpf/patch/20201212203901.351331-1-vladimir.oltean@nxp.com/
>
> We should kill it before it inflicts even more damage to the error
> handling logic in drivers.

I agree with the goal and the series make the kernel less
complex so:
Acked-by: Linus Walleij <linus.walleij@linaro.org>
for the series.

Yours,
Linus Walleij
Jiri Pirko Dec. 28, 2020, 9:59 a.m. UTC | #2 
Thu, Dec 17, 2020 at 02:58:13AM CET, vladimir.oltean@nxp.com wrote:
>This series comes after the late realization that the prepare/commit
>separation imposed by switchdev does not help literally anybody:
>https://patchwork.kernel.org/project/netdevbpf/patch/20201212203901.351331-1-vladimir.oltean@nxp.com/
>
>We should kill it before it inflicts even more damage to the error
>handling logic in drivers.

Awesome, I totally like this patchset. To be honest, I didn't see much
or a point to do the transaction model from the start, yet I remember
there were people requiring it. I guess they are fine now without
it or they don't care anymore.

Acked-by: Jiri Pirko <jiri@nvidia.com>