From patchwork Mon Dec 21 17:00:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongwei Zhang X-Patchwork-Id: 11985037 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E17E3C433E0 for ; Mon, 21 Dec 2020 17:17:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B076022C9C for ; Mon, 21 Dec 2020 17:17:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726317AbgLURRn (ORCPT ); Mon, 21 Dec 2020 12:17:43 -0500 Received: from atlmailgw2.ami.com ([63.147.10.42]:63858 "EHLO atlmailgw2.ami.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725849AbgLURRm (ORCPT ); Mon, 21 Dec 2020 12:17:42 -0500 X-Greylist: delayed 942 seconds by postgrey-1.27 at vger.kernel.org; Mon, 21 Dec 2020 12:17:41 EST X-AuditID: ac10606f-247ff70000001934-bd-5fe0d4de40c8 Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw2.ami.com (Symantec Messaging Gateway) with SMTP id 58.BF.06452.ED4D0EF5; Mon, 21 Dec 2020 12:01:18 -0500 (EST) Received: from ami-us-wk.us.megatrends.com (172.16.98.207) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server (TLS) id 14.3.468.0; Mon, 21 Dec 2020 12:01:16 -0500 From: Hongwei Zhang To: , , , Jakub Kicinski , David S Miller CC: Hongwei Zhang , netdev , Joel Stanley , Andrew Jeffery Subject: [Aspeed,ncsi-rx, v1 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue Date: Mon, 21 Dec 2020 12:00:45 -0500 Message-ID: <20201221170048.29821-1-hongweiz@ami.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201215192323.24359-1-hongweiz@ami.com> References: <20201215192323.24359-1-hongweiz@ami.com> MIME-Version: 1.0 X-Originating-IP: [172.16.98.207] X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOLMWRmVeSWpSXmKPExsWyRiBhgu69Kw/iDXp7NSx2XeawmHO+hcXi 9/m/zBYXtvWxWjSvPsdscXnXHDaLYwvELE61vGBx4PC42r6L3WPLyptMHhc/HmP22LSqk83j /IyFjB6fN8kFsEVx2aSk5mSWpRbp2yVwZZx51MhYsEaqYvK5I0wNjLvFuhg5OSQETCSWX//M 3MXIxSEksItJ4u3tx+xQDqPEyT2bmUCq2ATUJPZunsMEkhARWM0o0bPhFyOIwyzQwSgx9cVX dpAqYQF/iVVzFrN0MXJwsAioShxt4gQJ8wqYSny6c5cFYp28xOoNB5hBSjgFzCT2nJIDCQsB lbTue8cEUS4ocXLmE7ByZgEJiYMvXjBD1MhK3Dr0mAlijKLEg1/fWScwCsxC0jILScsCRqZV jEKJJTm5iZk56eVGeom5mXrJ+bmbGCGBnb+D8eNH80OMTByMhxglOJiVRHjNpO7HC/GmJFZW pRblxxeV5qQWH2KU5mBREudd5X40XkggPbEkNTs1tSC1CCbLxMEp1cAYfVxH629B50S7L3az Zsyaz3/GzsPl0K7Y4JByr8TXhZX7Njueuf1Vgdmu9vjBqse6O759W5M/saFs894/IvUVC/R/ ZVRefhdXn+4x630166fuXae6bVYuvpzHXfGDN/MQt27B/qV6nH9mtp0NnFLBf1X7svjy/54Z 1z+sFdHj0AnRrzj4j3edEktxRqKhFnNRcSIAbIgpA1oCAAA= Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dear Reviewer, When FTGMAC100 driver is used on other NCSI Ethernet controllers, few controllers have compatible issue. One example is Intel I210 Ethernet controller on AST2600 BMC, with FTGMAC100 driver, it always trigger RXDES0_RX_ERR error, cause NCSI initialization failure, removing FTGMAC100_RXDES0_RX_ERR bit from RXDES0_ANY_ERROR fix the issue. Here are part of the debug logs: ...... [ 35.075552] ftgmac100_hard_start_xmit TXDESO=b000003c [ 35.080843] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 55 [ 35.087141] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 35.094448] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 35.101498] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 35.108205] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 35.287808] i2c i2c-1: new_device: Instantiated device slave-mqueue at 0x12 [ 35.428379] ftgmac100_hard_start_xmit TXDESO=b000003c [ 35.433624] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 56 [ 35.439915] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 35.447225] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 35.454273] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 35.460972] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 35.797825] ftgmac100_hard_start_xmit TXDESO=b000003c [ 35.803241] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 57 [ 35.809541] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 35.816848] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 35.823899] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 35.830597] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 36.179914] ftgmac100_hard_start_xmit TXDESO=b000003c [ 36.185160] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 58 [ 36.191454] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 36.198761] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 36.205813] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 36.212513] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 36.593688] ftgmac100_hard_start_xmit TXDESO=b000003c [ 36.602937] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 59 [ 36.609244] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 36.616558] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 36.623608] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 36.630315] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 37.031524] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready [ 37.067831] IPv6: ADDRCONF(NETDEV_UP): eth1: link is not ready ............ This patch add a configurable flag, FTGMAC100_RXDES0_RX_ERR_CHK, in FTGMAC100 driver, it is YES by default, so keep the orignal define of RXDES0_ANY_ERROR. If it is needed, user can set the flag to NO to remove the RXDES0_RX_ERR bit, to fix the issue. Hongwei Zhang (1): net: ftgmac100: Fix AST2600 EVB NCSI RX issue drivers/net/ethernet/faraday/Kconfig | 9 +++++++++ drivers/net/ethernet/faraday/ftgmac100.h | 8 ++++++++ 2 files changed, 17 insertions(+)