From patchwork Mon Dec 21 19:40:25 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hongwei Zhang X-Patchwork-Id: 11985275 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71621C433E6 for ; Mon, 21 Dec 2020 19:41:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2729C22BE9 for ; Mon, 21 Dec 2020 19:41:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726743AbgLUTlV (ORCPT ); Mon, 21 Dec 2020 14:41:21 -0500 Received: from atlmailgw1.ami.com ([63.147.10.40]:58593 "EHLO atlmailgw1.ami.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726333AbgLUTlV (ORCPT ); Mon, 21 Dec 2020 14:41:21 -0500 X-AuditID: ac1060b2-a93ff700000017ec-ee-5fe0fa37947c Received: from atlms1.us.megatrends.com (atlms1.us.megatrends.com [172.16.96.144]) (using TLS with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (Client did not present a certificate) by atlmailgw1.ami.com (Symantec Messaging Gateway) with SMTP id 91.7D.06124.73AF0EF5; Mon, 21 Dec 2020 14:40:39 -0500 (EST) Received: from ami-us-wk.us.megatrends.com (172.16.98.207) by atlms1.us.megatrends.com (172.16.96.144) with Microsoft SMTP Server (TLS) id 14.3.468.0; Mon, 21 Dec 2020 14:40:38 -0500 From: Hongwei Zhang To: , , , Jakub Kicinski , David S Miller CC: Hongwei Zhang , netdev , Joel Stanley , Andrew Jeffery Subject: [Aspeed,ncsi-rx, v2 0/1] net: ftgmac100: Fix AST2600EVB NCSI RX issue Date: Mon, 21 Dec 2020 14:40:25 -0500 Message-ID: <20201221194026.30715-1-hongweiz@ami.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20201215192323.24359-1-hongweiz@ami.com> References: <20201215192323.24359-1-hongweiz@ami.com> MIME-Version: 1.0 X-Originating-IP: [172.16.98.207] X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrBLMWRmVeSWpSXmKPExsWyRiBhgq75rwfxBgsXq1vsusxhMed8C4vF 7/N/mS0ubOtjtWhefY7Z4vKuOWwWxxaIWZxqecHiwOFxtX0Xu8eWlTeZPC5+PMbssWlVJ5vH +RkLGT0+b5ILYIvisklJzcksSy3St0vgyjjzqJGxYI1UxeRzR5gaGHeLdTFyckgImEgcPrqV rYuRi0NIYBeTxIvLm9ihHEaJZ5+fsYJUsQmoSezdPIcJJCEisJpRomfDL0YQh1mgg1Fi6ouv 7CBVwgL+EvMOfQHrYBFQldjU+IUJxOYVMJU4cGENG8Q+eYnVGw4wdzFycHAKmEnsOSUHEhYC Kmnd9w6qXFDi5MwnLCA2s4CExMEXL5ghamQlbh16zAQxRlHiwa/vrBMYBWYhaZmFpGUBI9Mq RqHEkpzcxMyc9HJDvcTcTL3k/NxNjJDQ3rSDseWi+SFGJg7GQ4wSHMxKIrxmUvfjhXhTEiur Uovy44tKc1KLDzFKc7AoifOucj8aLySQnliSmp2aWpBaBJNl4uCUamAUMdNWXbqdt3l7Tb7i VuuD53/csbn87FRJjsKDigVu8kKLLBd4vYjN3rG344qRof1Se52fn/tsT5W4bCgSzvbKTtm1 4b98waHS5DO3vm9I9ypbJidyoG6Hx+GpGewFtut/rH/6d8oN14msnEWTvx0TSYzonNYYa8ip 4VrRueqF972XBuY/F/QqsRRnJBpqMRcVJwIA6loq6lsCAAA= Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Dear Reviewer, When FTGMAC100 driver is used on other NCSI Ethernet controllers, few controllers have compatible issue. One example is Intel I210 Ethernet controller on AST2600 BMC, with FTGMAC100 driver, it always trigger RXDES0_RX_ERR error, cause NCSI initialization failure, removing FTGMAC100_RXDES0_RX_ERR bit from RXDES0_ANY_ERROR fix the issue. Here are part of the debug logs: ...... [ 35.075552] ftgmac100_hard_start_xmit TXDESO=b000003c [ 35.080843] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 55 [ 35.087141] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 35.094448] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 35.101498] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 35.108205] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 35.287808] i2c i2c-1: new_device: Instantiated device slave-mqueue at 0x12 [ 35.428379] ftgmac100_hard_start_xmit TXDESO=b000003c [ 35.433624] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 56 [ 35.439915] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 35.447225] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 35.454273] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 35.460972] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 35.797825] ftgmac100_hard_start_xmit TXDESO=b000003c [ 35.803241] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 57 [ 35.809541] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 35.816848] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 35.823899] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 35.830597] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 36.179914] ftgmac100_hard_start_xmit TXDESO=b000003c [ 36.185160] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 58 [ 36.191454] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 36.198761] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 36.205813] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 36.212513] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 36.593688] ftgmac100_hard_start_xmit TXDESO=b000003c [ 36.602937] ftgmac100 1e660000.ethernet eth0: tx_complete_packet 59 [ 36.609244] ftgmac100 1e660000.ethernet eth0: rx_packet_error RXDES0=0xb0070040 [ 36.616558] ftgmac100_rx_packet RXDES0=b0070040 RXDES1=f0800000 RXDES2=88f8 [ 36.623608] ftgmac100 1e660000.ethernet eth0: rx_packet_error 0xb0070040 [ 36.630315] ftgmac100 1e660000.ethernet eth0: [ISR] = 0xb0070040: RX_ERR [ 37.031524] IPv6: ADDRCONF(NETDEV_UP): eth0: link is not ready [ 37.067831] IPv6: ADDRCONF(NETDEV_UP): eth1: link is not ready ............ This patch add a configurable flag, FTGMAC100_RXDES0_RX_ERR_CHK, in FTGMAC100 driver, it is YES by default, so keep the orignal define of RXDES0_ANY_ERROR. If it is needed, user can set the flag to NO to remove the RXDES0_RX_ERR bit, to fix the issue. Hongwei Zhang (1): net: ftgmac100: Fix AST2600 EVB NCSI RX issue drivers/net/ethernet/faraday/Kconfig | 9 +++++++++ drivers/net/ethernet/faraday/ftgmac100.h | 8 ++++++++ 2 files changed, 17 insertions(+)