| Message ID | 20210109185358.34616-1-dsahern@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | selftests: Updates to allow single instance of nettest for client and server | expand |
On 1/9/21 11:53 AM, David Ahern wrote: > Update nettest to handle namespace change internally to allow a > single instance to run both client and server modes. Device validation > needs to be moved after the namespace change and a few run time > options need to be split to allow values for client and server. > > David Ahern (11): > selftests: Move device validation in nettest > selftests: Move convert_addr up in nettest > selftests: Move address validation in nettest > selftests: Add options to set network namespace to nettest > selftests: Add support to nettest to run both client and server > selftests: Use separate stdout and stderr buffers in nettest > selftests: Add missing newline in nettest error messages > selftests: Make address validation apply only to client mode > selftests: Consistently specify address for MD5 protection > selftests: Add new option for client-side passwords > selftests: Add separate options for server device bindings > > tools/testing/selftests/net/fcnal-test.sh | 398 +++++++-------- > tools/testing/selftests/net/nettest.c | 576 +++++++++++++++------- > 2 files changed, 595 insertions(+), 379 deletions(-) > Ugh, I forgot to add net-next to the subject line. Let me know if I should re-send.
On Sat, 9 Jan 2021 11:55:39 -0700 David Ahern wrote: > On 1/9/21 11:53 AM, David Ahern wrote: > > Update nettest to handle namespace change internally to allow a > > single instance to run both client and server modes. Device validation > > needs to be moved after the namespace change and a few run time > > options need to be split to allow values for client and server. > > Ugh, I forgot to add net-next to the subject line. Let me know if I > should re-send. We should be fine, the build bot will default to net-next if there are not Fixes tag, and you just told us you're targeting net-next so all clear.
On Sat, 9 Jan 2021 11:02:02 -0800 Jakub Kicinski wrote: > On Sat, 9 Jan 2021 11:55:39 -0700 David Ahern wrote: > > On 1/9/21 11:53 AM, David Ahern wrote: > > > Update nettest to handle namespace change internally to allow a > > > single instance to run both client and server modes. Device validation > > > needs to be moved after the namespace change and a few run time > > > options need to be split to allow values for client and server. > > > > Ugh, I forgot to add net-next to the subject line. Let me know if I > > should re-send. > > We should be fine, the build bot will default to net-next if there are > not Fixes tag, and you just told us you're targeting net-next so all > clear. Do you want to address the checkpatch issues, tho?
On 1/9/21 4:04 PM, Jakub Kicinski wrote:
> Do you want to address the checkpatch issues, tho?
Yes, I thought I had fixed those. Evidently missed a few.
On Sat, 9 Jan 2021 16:12:22 -0700 David Ahern wrote: > On 1/9/21 4:04 PM, Jakub Kicinski wrote: > > Do you want to address the checkpatch issues, tho? > > Yes, I thought I had fixed those. Evidently missed a few. Thanks, I'm never sure if people intentionally use different style rules in selftests or just forget to checkpatch, so I never push back on style :S