[net-next,0/2] Add further DT configuration for AT803x PHYs

Message

Russell King (Oracle) Jan. 14, 2021, 10:44 a.m. UTC

Hi,

This patch series adds the ability to configure the SmartEEE feature
in AT803x PHYs. SmartEEE defaults to enabled on these PHYs, and has
a history of causing random sporadic link drops at Gigabit speeds.

There appears to be two solutions to this. There is the approach that
Freescale adopted early on, which is to disable the SmartEEE feature.
However, this loses the power saving provided by EEE. Another solution
was found by Jon Nettleton is to increase the Tw parameter for Gigabit
links.

This patch series adds support for both approaches, by adding a boolean:

	qca,disable-smarteee

if one wishes to disable SmartEEE, and two properties to configure the
SmartEEE Tw parameters:

	qca,smarteee-tw-us-100m
	qca,smarteee-tw-us-1g

Sadly, the PHY quirk I merged a while back for AT8035 on iMX6 is broken 
- rather than disabling SmartEEE mode, it enables it.

The addition of these properties will be sent to the appropriate
platform maintainers - although for SolidRun platforms, we only make use
of "qca,smarteee-tw-us-1g".

 .../devicetree/bindings/net/qca,ar803x.yaml        | 16 ++++++
 drivers/net/phy/at803x.c                           | 65 +++++++++++++++++++++-
 2 files changed, 80 insertions(+), 1 deletion(-)

Comments

[e-mail] Jan. 15, 2021, 11:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Thu, 14 Jan 2021 10:44:56 +0000 you wrote:
> Hi,
> 
> This patch series adds the ability to configure the SmartEEE feature
> in AT803x PHYs. SmartEEE defaults to enabled on these PHYs, and has
> a history of causing random sporadic link drops at Gigabit speeds.
> 
> There appears to be two solutions to this. There is the approach that
> Freescale adopted early on, which is to disable the SmartEEE feature.
> However, this loses the power saving provided by EEE. Another solution
> was found by Jon Nettleton is to increase the Tw parameter for Gigabit
> links.
> 
> [...]

Here is the summary with links:
  - [net-next,1/2] dt: ar803x: document SmartEEE properties
    https://git.kernel.org/netdev/net-next/c/623c13295cf4
  - [net-next,2/2] net: phy: at803x: add support for configuring SmartEEE
    https://git.kernel.org/netdev/net-next/c/390b4cad8148

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html