| Message ID | 20210118150656.796584-1-geert+renesas@glider.be (mailing list archive) |
|---|---|
| Headers | show |
| Series | sh_eth: Fix reboot crash | expand |
Hello: This series was applied to netdev/net.git (refs/heads/master): On Mon, 18 Jan 2021 16:06:54 +0100 you wrote: > Hi, > > This patch fixes a regression v5.11-rc1, where rebooting while a sh_eth > device is not opened will cause a crash. > > Changes compared to v1: > - Export mdiobb_{read,write}(), > - Call mdiobb_{read,write}() now they are exported, > - Use mii_bus.parent to avoid bb_info.dev copy, > - Drop RFC state. > > [...] Here is the summary with links: - [net,v2,1/2] mdio-bitbang: Export mdiobb_{read,write}() https://git.kernel.org/netdev/net/c/8eed01b5ca9c - [net,v2,2/2] sh_eth: Make PHY access aware of Runtime PM to fix reboot crash https://git.kernel.org/netdev/net/c/02cae02a7de1 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Hi, This patch fixes a regression v5.11-rc1, where rebooting while a sh_eth device is not opened will cause a crash. Changes compared to v1: - Export mdiobb_{read,write}(), - Call mdiobb_{read,write}() now they are exported, - Use mii_bus.parent to avoid bb_info.dev copy, - Drop RFC state. Alternatively, mdio-bitbang could provide Runtime PM-aware wrappers itself, and use them either manually (through a new parameter to alloc_mdio_bitbang(), or a new alloc_mdio_bitbang_*() function), or automatically (e.g. if pm_runtime_enabled() returns true). Note that the latter requires a "struct device *" parameter to operate on. Currently there are only two drivers that call alloc_mdio_bitbang() and use Runtime PM: the Renesas sh_eth and ravb drivers. This series fixes the former, while the latter is not affected (it keeps the device powered all the time between driver probe and driver unbind, and changing that seems to be non-trivial). Thanks for your comments! Geert Uytterhoeven (2): net: mdio-bitbang: Export mdiobb_{read,write}() sh_eth: Make PHY access aware of Runtime PM to fix reboot crash drivers/net/ethernet/renesas/sh_eth.c | 26 ++++++++++++++++++++++++++ drivers/net/mdio/mdio-bitbang.c | 6 ++++-- include/linux/mdio-bitbang.h | 3 +++ 3 files changed, 33 insertions(+), 2 deletions(-)