mbox series

[net-next,v2,0/4] net: inline rollback_registered() functions

Message ID 20210119202521.3108236-1-kuba@kernel.org (mailing list archive)
Headers show
Series net: inline rollback_registered() functions | expand

Message

Jakub Kicinski Jan. 19, 2021, 8:25 p.m. UTC 
After recent changes to the error path of register_netdevice()
we no longer need a version of unregister_netdevice_many() which
does not set net_todo. We can inline the rollback_registered()
functions into respective unregister_netdevice() calls.

v2: - add missing list_del() in the last patch

Jakub Kicinski (4):
  net: move net_set_todo inside rollback_registered()
  net: inline rollback_registered()
  net: move rollback_registered_many()
  net: inline rollback_registered_many()

 net/core/dev.c | 210 +++++++++++++++++++++++--------------------------
 1 file changed, 98 insertions(+), 112 deletions(-)

Comments

Edwin Peer Jan. 19, 2021, 11:18 p.m. UTC | #1 
On Tue, Jan 19, 2021 at 12:32 PM Jakub Kicinski <kuba@kernel.org> wrote:

> After recent changes to the error path of register_netdevice()
> we no longer need a version of unregister_netdevice_many() which
> does not set net_todo. We can inline the rollback_registered()
> functions into respective unregister_netdevice() calls.
>
> v2: - add missing list_del() in the last patch
>
> Jakub Kicinski (4):
>   net: move net_set_todo inside rollback_registered()
>   net: inline rollback_registered()
>   net: move rollback_registered_many()
>   net: inline rollback_registered_many()
>
>  net/core/dev.c | 210 +++++++++++++++++++++++--------------------------
>  1 file changed, 98 insertions(+), 112 deletions(-)

Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>

Regards,
Edwin Peer
Jakub Kicinski Jan. 21, 2021, 5:05 a.m. UTC | #2 
On Tue, 19 Jan 2021 15:18:46 -0800 Edwin Peer wrote:
> On Tue, Jan 19, 2021 at 12:32 PM Jakub Kicinski <kuba@kernel.org> wrote:
> 
> > After recent changes to the error path of register_netdevice()
> > we no longer need a version of unregister_netdevice_many() which
> > does not set net_todo. We can inline the rollback_registered()
> > functions into respective unregister_netdevice() calls.
> >
> > v2: - add missing list_del() in the last patch
> >
> > Jakub Kicinski (4):
> >   net: move net_set_todo inside rollback_registered()
> >   net: inline rollback_registered()
> >   net: move rollback_registered_many()
> >   net: inline rollback_registered_many()
> >
> >  net/core/dev.c | 210 +++++++++++++++++++++++--------------------------
> >  1 file changed, 98 insertions(+), 112 deletions(-)  
> 
> Reviewed-by: Edwin Peer <edwin.peer@broadcom.com>

Applied, thanks!
patchwork-bot+netdevbpf@kernel.org Jan. 21, 2021, 5:10 a.m. UTC | #3 
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Tue, 19 Jan 2021 12:25:17 -0800 you wrote:
> After recent changes to the error path of register_netdevice()
> we no longer need a version of unregister_netdevice_many() which
> does not set net_todo. We can inline the rollback_registered()
> functions into respective unregister_netdevice() calls.
> 
> v2: - add missing list_del() in the last patch
> 
> [...]

Here is the summary with links:
  - [net-next,v2,1/4] net: move net_set_todo inside rollback_registered()
    https://git.kernel.org/netdev/net-next/c/2014beea7eb1
  - [net-next,v2,2/4] net: inline rollback_registered()
    https://git.kernel.org/netdev/net-next/c/037e56bd965e
  - [net-next,v2,3/4] net: move rollback_registered_many()
    https://git.kernel.org/netdev/net-next/c/bcfe2f1a3818
  - [net-next,v2,4/4] net: inline rollback_registered_many()
    https://git.kernel.org/netdev/net-next/c/0cbe1e57a7b9

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html