| Message ID | 20210121125731.19425-1-oneukum@suse.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | usbnet: speed reporting for devices without MDIO | expand |
On Thu, Jan 21, 2021 at 01:57:28PM +0100, Oliver Neukum wrote: > This series introduces support for USB network devices that report > speed as a part of their protocol, not emulating an MII to be accessed > over MDIO. > > v2: adjusted to recent changes Hi Oliver Please give more details what actually changed. Does this mean you just rebased it on net-next? Or have you made real changes? The discussion with v1 suggested that this framework should also be used by anything which gets notified in CDC style. So i was expecting to see cdc_ether.c also use this. Andrew
On Fri, Jan 22, 2021 at 1:29 AM Andrew Lunn <andrew@lunn.ch> wrote: > > On Thu, Jan 21, 2021 at 01:57:28PM +0100, Oliver Neukum wrote: > > This series introduces support for USB network devices that report > > speed as a part of their protocol, not emulating an MII to be accessed > > over MDIO. > > > > v2: adjusted to recent changes > > Hi Oliver > > Please give more details what actually changed. Does this mean you > just rebased it on net-next? Or have you made real changes? My apologies to Oliver - the changes he's referring to are the ones I submitted: https://www.spinics.net/lists/netdev/msg715248.html which is related to this series: https://www.spinics.net/lists/netdev/msg714493.html I wasn't aware of and didn't look for the series Oliver had previously posted. *sigh* I have been talking to Realtek about getting the issue of RTL8156 spewing notifications every 32ms fixed (thinking a FW change could fix it) for nearly three months. It is unfortunate timing that Roland Dreier decided to do something about it in December - which I didn't expect to happen given this problem was reported nearly two years ago. > The discussion with v1 suggested that this framework should also be > used by anything which gets notified in CDC style. So i was expecting > to see cdc_ether.c also use this. Agreed. That's a two lines change to cdc_ether.c. I can submit this if Oliver doesn't want to spin the series. I've reviewed all three patches and besides one nit (which could be ignored or fixed later), I'm offering my Reviewed-by: Grant Grundler <grundler@chromium.org> in the off chance that helps get this accepted into net-next (and/or 5.11 RC release). cheers, grant > > Andrew
Oliver, it's been a few weeks, do you have time to post an updated patchset or is there someone else you would trust to help land this series? cheers, grant On Fri, Jan 22, 2021 at 2:10 AM Grant Grundler <grundler@chromium.org> wrote: > > On Fri, Jan 22, 2021 at 1:29 AM Andrew Lunn <andrew@lunn.ch> wrote: > > > > On Thu, Jan 21, 2021 at 01:57:28PM +0100, Oliver Neukum wrote: > > > This series introduces support for USB network devices that report > > > speed as a part of their protocol, not emulating an MII to be accessed > > > over MDIO. > > > > > > v2: adjusted to recent changes > > > > Hi Oliver > > > > Please give more details what actually changed. Does this mean you > > just rebased it on net-next? Or have you made real changes? > > My apologies to Oliver - the changes he's referring to are the ones I submitted: > https://www.spinics.net/lists/netdev/msg715248.html > > which is related to this series: > https://www.spinics.net/lists/netdev/msg714493.html > > I wasn't aware of and didn't look for the series Oliver had previously > posted. *sigh* I have been talking to Realtek about getting the issue > of RTL8156 spewing notifications every 32ms fixed (thinking a FW > change could fix it) for nearly three months. It is unfortunate > timing that Roland Dreier decided to do something about it in December > - which I didn't expect to happen given this problem was reported > nearly two years ago. > > > The discussion with v1 suggested that this framework should also be > > used by anything which gets notified in CDC style. So i was expecting > > to see cdc_ether.c also use this. > > Agreed. That's a two lines change to cdc_ether.c. I can submit this if > Oliver doesn't want to spin the series. > > I've reviewed all three patches and besides one nit (which could be > ignored or fixed later), I'm offering my > Reviewed-by: Grant Grundler <grundler@chromium.org> > > in the off chance that helps get this accepted into net-next (and/or > 5.11 RC release). > > cheers, > grant > > > > > Andrew