mbox series

[v6,0/7] MSFT offloading support for advertisement monitor

Message ID 20210122083617.3163489-1-apusaka@google.com (mailing list archive)
Headers show
Series MSFT offloading support for advertisement monitor | expand

Message

Archie Pusaka Jan. 22, 2021, 8:36 a.m. UTC
From: Archie Pusaka <apusaka@chromium.org>


Hi linux-bluetooth,

This series of patches manages the hardware offloading part of MSFT
extension API. The full documentation can be accessed by this link:
https://docs.microsoft.com/en-us/windows-hardware/drivers/bluetooth/microsoft-defined-bluetooth-hci-commands-and-events

Only four of the HCI commands are planned to be implemented:
HCI_VS_MSFT_Read_Supported_Features (implemented in previous patch),
HCI_VS_MSFT_LE_Monitor_Advertisement,
HCI_VS_MSFT_LE_Cancel_Monitor_Advertisement, and
HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable.
These are the commands which would be used for advertisement monitor
feature. Only if the controller supports the MSFT extension would
these commands be sent. Otherwise, software-based monitoring would be
performed in the user space instead.

Thanks in advance for your feedback!

Archie

Changes in v6:
* New patch "advmon offload MSFT interleave scanning integration"
* New patch "disable advertisement filters during suspend"

Changes in v5:
* Discard struct flags on msft_data and use it's members directly

Changes in v4:
* Change the logic of merging add_adv_patterns_monitor with rssi
* Aligning variable declaration on mgmt.h
* Replacing the usage of BT_DBG with bt_dev_dbg

Changes in v3:
* Flips the order of rssi and pattern_count on mgmt struct
* Fix return type of msft_remove_monitor

Changes in v2:
* Add a new opcode instead of modifying an existing one
* Also implement the new MGMT opcode and merge the functionality with
  the old one.

Archie Pusaka (6):
  Bluetooth: advmon offload MSFT add rssi support
  Bluetooth: advmon offload MSFT add monitor
  Bluetooth: advmon offload MSFT remove monitor
  Bluetooth: advmon offload MSFT handle controller reset
  Bluetooth: advmon offload MSFT handle filter enablement
  Bluetooth: advmon offload MSFT interleave scanning integration

Howard Chung (1):
  Bluetooth: disable advertisement filters during suspend

 include/net/bluetooth/hci_core.h |  36 ++-
 include/net/bluetooth/mgmt.h     |  16 ++
 net/bluetooth/hci_core.c         | 174 +++++++++---
 net/bluetooth/hci_request.c      |  49 +++-
 net/bluetooth/mgmt.c             | 391 +++++++++++++++++++-------
 net/bluetooth/msft.c             | 460 ++++++++++++++++++++++++++++++-
 net/bluetooth/msft.h             |  30 ++
 7 files changed, 1015 insertions(+), 141 deletions(-)

Comments

Marcel Holtmann Jan. 25, 2021, 3:09 p.m. UTC | #1
Hi Archie,

> This series of patches manages the hardware offloading part of MSFT
> extension API. The full documentation can be accessed by this link:
> https://docs.microsoft.com/en-us/windows-hardware/drivers/bluetooth/microsoft-defined-bluetooth-hci-commands-and-events
> 
> Only four of the HCI commands are planned to be implemented:
> HCI_VS_MSFT_Read_Supported_Features (implemented in previous patch),
> HCI_VS_MSFT_LE_Monitor_Advertisement,
> HCI_VS_MSFT_LE_Cancel_Monitor_Advertisement, and
> HCI_VS_MSFT_LE_Set_Advertisement_Filter_Enable.
> These are the commands which would be used for advertisement monitor
> feature. Only if the controller supports the MSFT extension would
> these commands be sent. Otherwise, software-based monitoring would be
> performed in the user space instead.
> 
> Thanks in advance for your feedback!
> 
> Archie
> 
> Changes in v6:
> * New patch "advmon offload MSFT interleave scanning integration"
> * New patch "disable advertisement filters during suspend"
> 
> Changes in v5:
> * Discard struct flags on msft_data and use it's members directly
> 
> Changes in v4:
> * Change the logic of merging add_adv_patterns_monitor with rssi
> * Aligning variable declaration on mgmt.h
> * Replacing the usage of BT_DBG with bt_dev_dbg
> 
> Changes in v3:
> * Flips the order of rssi and pattern_count on mgmt struct
> * Fix return type of msft_remove_monitor
> 
> Changes in v2:
> * Add a new opcode instead of modifying an existing one
> * Also implement the new MGMT opcode and merge the functionality with
>  the old one.
> 
> Archie Pusaka (6):
>  Bluetooth: advmon offload MSFT add rssi support
>  Bluetooth: advmon offload MSFT add monitor
>  Bluetooth: advmon offload MSFT remove monitor
>  Bluetooth: advmon offload MSFT handle controller reset
>  Bluetooth: advmon offload MSFT handle filter enablement
>  Bluetooth: advmon offload MSFT interleave scanning integration
> 
> Howard Chung (1):
>  Bluetooth: disable advertisement filters during suspend
> 
> include/net/bluetooth/hci_core.h |  36 ++-
> include/net/bluetooth/mgmt.h     |  16 ++
> net/bluetooth/hci_core.c         | 174 +++++++++---
> net/bluetooth/hci_request.c      |  49 +++-
> net/bluetooth/mgmt.c             | 391 +++++++++++++++++++-------
> net/bluetooth/msft.c             | 460 ++++++++++++++++++++++++++++++-
> net/bluetooth/msft.h             |  30 ++
> 7 files changed, 1015 insertions(+), 141 deletions(-)

all 7 patches have been applied to bluetooth-next tree.

Regards

Marcel