From patchwork Tue Feb 2 18:06:04 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Danielle Ratson X-Patchwork-Id: 12062547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DF5F3C433DB for ; Tue, 2 Feb 2021 18:13:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BA3DC64F97 for ; Tue, 2 Feb 2021 18:13:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238379AbhBBSNP (ORCPT ); Tue, 2 Feb 2021 13:13:15 -0500 Received: from hqnvemgate26.nvidia.com ([216.228.121.65]:2667 "EHLO hqnvemgate26.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238264AbhBBSHJ (ORCPT ); Tue, 2 Feb 2021 13:07:09 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate26.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Tue, 02 Feb 2021 10:06:28 -0800 Received: from dev-r-vrt-156.mtr.labs.mlnx (172.20.145.6) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 2 Feb 2021 18:06:25 +0000 From: Danielle Ratson To: CC: , , , , , , , , Danielle Ratson Subject: [PATCH net-next v4 0/8] Support setting lanes via ethtool Date: Tue, 2 Feb 2021 20:06:04 +0200 Message-ID: <20210202180612.325099-1-danieller@nvidia.com> X-Mailer: git-send-email 2.26.2 MIME-Version: 1.0 X-Originating-IP: [172.20.145.6] X-ClientProxiedBy: HQMAIL111.nvidia.com (172.20.187.18) To HQMAIL107.nvidia.com (172.20.187.13) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1612289188; bh=M9evM1K9zDv0qYNXtNpgn+hR1eu1WS9NInawYQCIZmw=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:MIME-Version: Content-Transfer-Encoding:Content-Type:X-Originating-IP: X-ClientProxiedBy; b=SNiLmffsdJAbukYtg1VJnjwql3vFIkuLAgqIIOXcnRTwHEsYTAwWUE9dbZ05PpGZm Y5f2zZV+o6IR5HABvVQ3Nu0F/f1abgGjAHzkeykGeCoTrk7tQXOpZ1ztSUiAh+oUaV xR8y0in6VOh9GmFND3FKYhcoVebEKpcpYpf8FalfrhzYh15HpkdpoE8n0M8i3eseet 3za4l/GjHzmZx6ttn88C+B2dSRH5WmH85SbzVvgmELibYAGm8oTry2B07WBQZzdpOc DCpTGZNPWYteuJTL6Icv7jCyRMjlmZqFOF2obzX/2OqPq1+b4gmXBYLMZKIxkVSCg6 Vzorna23ZmnwA== Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Some speeds can be achieved with different number of lanes. For example, 100Gbps can be achieved using two lanes of 50Gbps or four lanes of 25Gbps. This patchset adds a new selector that allows ethtool to advertise link modes according to their number of lanes and also force a specific number of lanes when autonegotiation is off. Advertising all link modes with a speed of 100Gbps that use two lanes: $ ethtool -s swp1 speed 100000 lanes 2 autoneg on Forcing a speed of 100Gbps using four lanes: $ ethtool -s swp1 speed 100000 lanes 4 autoneg off Patchset overview: Patch #1-#2 allows user space to configure the desired number of lanes. Patch #3-#4 adjusts ethtool to dump to user space the number of lanes currently in use. Patches #5-#7 add support for lanes configuration in mlxsw. Patch #8 adds a selftest. v4: * Add patch #1 for validating parameters before rtnl_lock(). v3: * Patch #1: Change ethtool_ops.capabilities to be a bitfield, and set min and max for the lanes policy. * Patch #2: Remove LINK_MODE_UNKNOWN and move the speed, duplex and lanes derivation to the wrapper __ethtool_get_link_ksettings(). * Patch #5: Set the bitfield of supporting lanes in the driver * to 'true'. * Patch #7: Move the test to drivers/net/mlxsw. v2: * Patch #1: Remove ETHTOOL_LANES defines and simply use a number instead. * Patches #2,#6: Pass link mode from driver to ethtool instead * of the parameters themselves. * Patch #5: Add an actual width field for spectrum-2 link modes in order to set the suitable link mode when lanes parameter is passed. * Patch #6: Changed lanes to be unsigned in 'struct link_mode_info'. * Patch #7: Remove the test for recieving max_width when lanes is not set by user. When not setting lanes, we don't promise anything regarding what number of lanes will be chosen. Danielle Ratson (8): ethtool: Validate master slave configuration before rtnl_lock() ethtool: Extend link modes settings uAPI with lanes ethtool: Get link mode in use instead of speed and duplex parameters ethtool: Expose the number of lanes in use mlxsw: ethtool: Remove max lanes filtering mlxsw: ethtool: Add support for setting lanes when autoneg is off mlxsw: ethtool: Pass link mode in use to ethtool net: selftests: Add lanes setting test Documentation/networking/ethtool-netlink.rst | 11 +- .../net/ethernet/mellanox/mlxsw/spectrum.h | 13 +- .../mellanox/mlxsw/spectrum_ethtool.c | 196 ++++++++++------- include/linux/ethtool.h | 5 + include/uapi/linux/ethtool_netlink.h | 1 + net/ethtool/common.c | 147 +++++++++++++ net/ethtool/common.h | 7 + net/ethtool/ioctl.c | 18 +- net/ethtool/linkmodes.c | 208 ++++++------------ net/ethtool/netlink.h | 2 +- .../drivers/net/mlxsw/ethtool_lanes.sh | 187 ++++++++++++++++ .../selftests/net/forwarding/ethtool_lib.sh | 34 +++ tools/testing/selftests/net/forwarding/lib.sh | 28 +++ 13 files changed, 626 insertions(+), 231 deletions(-) create mode 100755 tools/testing/selftests/drivers/net/mlxsw/ethtool_lanes.sh