| Message ID | 20210205124020.683286-1-jolsa@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | kbuild/resolve_btfids: Invoke resolve_btfids clean in root Makefile | expand |
On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa <jolsa@kernel.org> wrote: > > hi, > resolve_btfids tool is used during the kernel build, > so we should clean it on kernel's make clean. > > v2 changes: > - add Song's acks on patches 1 and 4 (others changed) [Song] > - add missing / [Andrii] > - change srctree variable initialization [Andrii] > - shifted ifdef for clean target [Andrii] > > thanks, > jirka > > FYI, your patch #2 didn't make it into the mailing list (see [0]). So maybe wait for a bit and if it doesn't arrive, re-submit? [0] https://patchwork.kernel.org/user/todo/netdevbpf/?series=428711&delegate=121173&state=* > --- > Jiri Olsa (4): > tools/resolve_btfids: Build libbpf and libsubcmd in separate directories > tools/resolve_btfids: Check objects before removing > tools/resolve_btfids: Set srctree variable unconditionally > kbuild: Add resolve_btfids clean to root clean target > > Makefile | 7 ++++++- > tools/bpf/resolve_btfids/.gitignore | 2 -- > tools/bpf/resolve_btfids/Makefile | 44 ++++++++++++++++++++++---------------------- > 3 files changed, 28 insertions(+), 25 deletions(-) >
On Fri, Feb 05, 2021 at 02:27:08PM -0800, Andrii Nakryiko wrote: > On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa <jolsa@kernel.org> wrote: > > > > hi, > > resolve_btfids tool is used during the kernel build, > > so we should clean it on kernel's make clean. > > > > v2 changes: > > - add Song's acks on patches 1 and 4 (others changed) [Song] > > - add missing / [Andrii] > > - change srctree variable initialization [Andrii] > > - shifted ifdef for clean target [Andrii] > > > > thanks, > > jirka > > > > > > FYI, your patch #2 didn't make it into the mailing list (see [0]). So > maybe wait for a bit and if it doesn't arrive, re-submit? > > [0] https://patchwork.kernel.org/user/todo/netdevbpf/?series=428711&delegate=121173&state=* hum and lore shows just 1 and 4 https://lore.kernel.org/bpf/20210205124020.683286-1-jolsa@kernel.org/ I'll check and resent later thanks, jirka > > > --- > > Jiri Olsa (4): > > tools/resolve_btfids: Build libbpf and libsubcmd in separate directories > > tools/resolve_btfids: Check objects before removing > > tools/resolve_btfids: Set srctree variable unconditionally > > kbuild: Add resolve_btfids clean to root clean target > > > > Makefile | 7 ++++++- > > tools/bpf/resolve_btfids/.gitignore | 2 -- > > tools/bpf/resolve_btfids/Makefile | 44 ++++++++++++++++++++++---------------------- > > 3 files changed, 28 insertions(+), 25 deletions(-) > > >
On Fri, Feb 05, 2021 at 11:32:57PM +0100, Jiri Olsa wrote: > On Fri, Feb 05, 2021 at 02:27:08PM -0800, Andrii Nakryiko wrote: > > On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa <jolsa@kernel.org> wrote: > > > > > > hi, > > > resolve_btfids tool is used during the kernel build, > > > so we should clean it on kernel's make clean. > > > > > > v2 changes: > > > - add Song's acks on patches 1 and 4 (others changed) [Song] > > > - add missing / [Andrii] > > > - change srctree variable initialization [Andrii] > > > - shifted ifdef for clean target [Andrii] > > > > > > thanks, > > > jirka > > > > > > > > > > FYI, your patch #2 didn't make it into the mailing list (see [0]). So > > maybe wait for a bit and if it doesn't arrive, re-submit? > > > > [0] https://patchwork.kernel.org/user/todo/netdevbpf/?series=428711&delegate=121173&state=* > > hum and lore shows just 1 and 4 > https://lore.kernel.org/bpf/20210205124020.683286-1-jolsa@kernel.org/ > > I'll check and resent later it arrived jirka
On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa <jolsa@kernel.org> wrote: > > hi, > resolve_btfids tool is used during the kernel build, > so we should clean it on kernel's make clean. > > v2 changes: > - add Song's acks on patches 1 and 4 (others changed) [Song] > - add missing / [Andrii] > - change srctree variable initialization [Andrii] > - shifted ifdef for clean target [Andrii] > > thanks, > jirka > > > --- > Jiri Olsa (4): > tools/resolve_btfids: Build libbpf and libsubcmd in separate directories > tools/resolve_btfids: Check objects before removing > tools/resolve_btfids: Set srctree variable unconditionally > kbuild: Add resolve_btfids clean to root clean target > > Makefile | 7 ++++++- > tools/bpf/resolve_btfids/.gitignore | 2 -- > tools/bpf/resolve_btfids/Makefile | 44 ++++++++++++++++++++++---------------------- > 3 files changed, 28 insertions(+), 25 deletions(-) > I've applied the changes to the bpf-next tree. Thanks. Next time please make sure that each patch in the series has a v2 tag in [PATCH] section, it was a bit confusing to figure out which one is the actual v2 version. Our tooling (CI) also expects the format [PATCH v2 bpf-next], so try not to merge v2 with PATCH.
On Mon, Feb 08, 2021 at 09:36:40PM -0800, Andrii Nakryiko wrote: > On Fri, Feb 5, 2021 at 4:45 AM Jiri Olsa <jolsa@kernel.org> wrote: > > > > hi, > > resolve_btfids tool is used during the kernel build, > > so we should clean it on kernel's make clean. > > > > v2 changes: > > - add Song's acks on patches 1 and 4 (others changed) [Song] > > - add missing / [Andrii] > > - change srctree variable initialization [Andrii] > > - shifted ifdef for clean target [Andrii] > > > > thanks, > > jirka > > > > > > --- > > Jiri Olsa (4): > > tools/resolve_btfids: Build libbpf and libsubcmd in separate directories > > tools/resolve_btfids: Check objects before removing > > tools/resolve_btfids: Set srctree variable unconditionally > > kbuild: Add resolve_btfids clean to root clean target > > > > Makefile | 7 ++++++- > > tools/bpf/resolve_btfids/.gitignore | 2 -- > > tools/bpf/resolve_btfids/Makefile | 44 ++++++++++++++++++++++---------------------- > > 3 files changed, 28 insertions(+), 25 deletions(-) > > > > I've applied the changes to the bpf-next tree. Thanks. > > Next time please make sure that each patch in the series has a v2 tag > in [PATCH] section, it was a bit confusing to figure out which one is > the actual v2 version. Our tooling (CI) also expects the format [PATCH > v2 bpf-next], so try not to merge v2 with PATCH. > will do, thanks jirka
hi, resolve_btfids tool is used during the kernel build, so we should clean it on kernel's make clean. v2 changes: - add Song's acks on patches 1 and 4 (others changed) [Song] - add missing / [Andrii] - change srctree variable initialization [Andrii] - shifted ifdef for clean target [Andrii] thanks, jirka --- Jiri Olsa (4): tools/resolve_btfids: Build libbpf and libsubcmd in separate directories tools/resolve_btfids: Check objects before removing tools/resolve_btfids: Set srctree variable unconditionally kbuild: Add resolve_btfids clean to root clean target Makefile | 7 ++++++- tools/bpf/resolve_btfids/.gitignore | 2 -- tools/bpf/resolve_btfids/Makefile | 44 ++++++++++++++++++++++---------------------- 3 files changed, 28 insertions(+), 25 deletions(-)