| Message ID | 20210210204333.729603-1-razor@blackwall.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | bonding: 3ad: support for 200G/400G ports and more verbose warning | expand |
On Wed, Feb 10, 2021 at 12:43 PM Nikolay Aleksandrov <razor@blackwall.org> wrote: > > From: Nikolay Aleksandrov <nikolay@nvidia.com> > > Hi, > We'd like to have proper 200G and 400G support with 3ad bond mode, so we > need to add new definitions for them in order to have separate oper keys, > aggregated bandwidth and proper operation (patches 01 and 02). In > patch 03 Ido changes the code to use pr_err_once instead of > pr_warn_once which would help future detection of unsupported speeds. > > v2: patch 03: use pr_err_once instead of WARN_ONCE > > Thanks, > Nik > > Ido Schimmel (1): > bonding: 3ad: Print an error for unknown speeds > > Nikolay Aleksandrov (2): > bonding: 3ad: add support for 200G speed > bonding: 3ad: add support for 400G speed > > drivers/net/bonding/bond_3ad.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > With this update the series looks good to me. Reviewed-by: Alexander Duyck <alexanderduyck@fb.com>
Nikolay Aleksandrov <razor@blackwall.org> wrote: >From: Nikolay Aleksandrov <nikolay@nvidia.com> > >Hi, >We'd like to have proper 200G and 400G support with 3ad bond mode, so we >need to add new definitions for them in order to have separate oper keys, >aggregated bandwidth and proper operation (patches 01 and 02). In >patch 03 Ido changes the code to use pr_err_once instead of >pr_warn_once which would help future detection of unsupported speeds. > >v2: patch 03: use pr_err_once instead of WARN_ONCE > >Thanks, > Nik > >Ido Schimmel (1): > bonding: 3ad: Print an error for unknown speeds > >Nikolay Aleksandrov (2): > bonding: 3ad: add support for 200G speed > bonding: 3ad: add support for 400G speed > > drivers/net/bonding/bond_3ad.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) Patches 1 and 2 could have been one patch, I suppose, but not really a big deal. I'm in agreement about pr_err_once instead of WARN_ONCE. Acked-by: Jay Vosburgh <jay.vosburgh@canonical.com> -J --- -Jay Vosburgh, jay.vosburgh@canonical.com
Le 10/02/2021 à 21:43, Nikolay Aleksandrov a écrit : > From: Nikolay Aleksandrov <nikolay@nvidia.com> > > Hi, > We'd like to have proper 200G and 400G support with 3ad bond mode, so we > need to add new definitions for them in order to have separate oper keys, > aggregated bandwidth and proper operation (patches 01 and 02). In > patch 03 Ido changes the code to use pr_err_once instead of > pr_warn_once which would help future detection of unsupported speeds. > > v2: patch 03: use pr_err_once instead of WARN_ONCE > > Thanks, > Nik > > Ido Schimmel (1): > bonding: 3ad: Print an error for unknown speeds > > Nikolay Aleksandrov (2): > bonding: 3ad: add support for 200G speed > bonding: 3ad: add support for 400G speed > > drivers/net/bonding/bond_3ad.c | 26 ++++++++++++++++++++++---- > 1 file changed, 22 insertions(+), 4 deletions(-) > Acked-by: Nicolas Dichtel <nicolas.dichtel@6wind.com>
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Wed, 10 Feb 2021 22:43:30 +0200 you wrote: > From: Nikolay Aleksandrov <nikolay@nvidia.com> > > Hi, > We'd like to have proper 200G and 400G support with 3ad bond mode, so we > need to add new definitions for them in order to have separate oper keys, > aggregated bandwidth and proper operation (patches 01 and 02). In > patch 03 Ido changes the code to use pr_err_once instead of > pr_warn_once which would help future detection of unsupported speeds. > > [...] Here is the summary with links: - [net-next,v2,1/3] bonding: 3ad: add support for 200G speed https://git.kernel.org/netdev/net-next/c/ab73447c38e4 - [net-next,v2,2/3] bonding: 3ad: add support for 400G speed https://git.kernel.org/netdev/net-next/c/138e3b3cc0bb - [net-next,v2,3/3] bonding: 3ad: Print an error for unknown speeds https://git.kernel.org/netdev/net-next/c/5edf55ad95b5 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
From: Nikolay Aleksandrov <nikolay@nvidia.com> Hi, We'd like to have proper 200G and 400G support with 3ad bond mode, so we need to add new definitions for them in order to have separate oper keys, aggregated bandwidth and proper operation (patches 01 and 02). In patch 03 Ido changes the code to use pr_err_once instead of pr_warn_once which would help future detection of unsupported speeds. v2: patch 03: use pr_err_once instead of WARN_ONCE Thanks, Nik Ido Schimmel (1): bonding: 3ad: Print an error for unknown speeds Nikolay Aleksandrov (2): bonding: 3ad: add support for 200G speed bonding: 3ad: add support for 400G speed drivers/net/bonding/bond_3ad.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)