[net,v2,0/2] net: dsa: Learning fixes for b53/bcm_sf2

Message

Florian Fainelli Feb. 22, 2021, 10:30 p.m. UTC

Hi David, Jakub,

This patch series contains a couple of fixes for the b53/bcm_sf2 drivers
with respect to configuring learning.

The first patch is wiring-up the necessary dsa_switch_ops operations in
order to support the offloading of bridge flags.

The second patch corrects the switch driver's default learning behavior
which was unfortunately wrong from day one.

This is submitted against "net" because this is technically a bug fix
since ports should not have had learning enabled by default but given
this is dependent upon Vladimir's recent br_flags series, there is no
Fixes tag provided.

I will be providing targeted stable backports that look a bit
difference.

Changes in v2:

- added first patch
- updated second patch to include BR_LEARNING check in br_flags_pre as
  a support bridge flag to offload

Florian Fainelli (2):
  net: dsa: bcm_sf2: Wire-up br_flags_pre, br_flags and set_mrouter
  net: dsa: b53: Support setting learning on port

 drivers/net/dsa/b53/b53_common.c | 39 ++++++++++++++++++++++++--------
 drivers/net/dsa/b53/b53_priv.h   |  8 +++++++
 drivers/net/dsa/b53/b53_regs.h   |  1 +
 drivers/net/dsa/bcm_sf2.c        | 18 ++++-----------
 4 files changed, 43 insertions(+), 23 deletions(-)

Comments

Jakub Kicinski Feb. 23, 2021, 8:27 p.m. UTC | #1

On Mon, 22 Feb 2021 14:30:08 -0800 Florian Fainelli wrote:
> This patch series contains a couple of fixes for the b53/bcm_sf2 drivers
> with respect to configuring learning.
> 
> The first patch is wiring-up the necessary dsa_switch_ops operations in
> order to support the offloading of bridge flags.
> 
> The second patch corrects the switch driver's default learning behavior
> which was unfortunately wrong from day one.
> 
> This is submitted against "net" because this is technically a bug fix
> since ports should not have had learning enabled by default but given
> this is dependent upon Vladimir's recent br_flags series, there is no
> Fixes tag provided.
> 
> I will be providing targeted stable backports that look a bit
> difference.

Applied, thanks!