From patchwork Thu Mar 25 01:11:54 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jakub Kicinski X-Patchwork-Id: 12162613 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C2FC433E1 for ; Thu, 25 Mar 2021 01:13:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE54561A16 for ; Thu, 25 Mar 2021 01:13:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239559AbhCYBM3 (ORCPT ); Wed, 24 Mar 2021 21:12:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:52272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239545AbhCYBMG (ORCPT ); Wed, 24 Mar 2021 21:12:06 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id CFEB961A14; Thu, 25 Mar 2021 01:12:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1616634726; bh=352VrPUrx++UEr/czikRjEFB5U7juxq2H0+r7pGhxvQ=; h=From:To:Cc:Subject:Date:From; b=Hg/nSlO3J0L4M0U7febI7T10Lypv6V/+iHykw2kJmqFi/pVt0+9DygdWm/ltMs3y9 7jhtaBxJWXwkcPYXsy/arTQPeIGSokN4hIc1x6EsUd39JpoZGZiJBQJt2ezqAKGw2g VArNEaCYMq10ViNzt+rSarfOTyknN7lr867dcpYHPjPH03lsAbOs+AmFxYqa62CWwg qa2rAPSokMUAdFpYy3PEe/+mxIDzdwInvbiZ3vrnOZindjJRwSwjBOvnxUVKq41U60 xQ8cIyeHApCG7yiQBnFPJnG2/i34Jfu5gm5gvPa8mX8x3oAZY1J/DxQqYOS4KKDeLM m7HDhv3MbP2pg== From: Jakub Kicinski To: davem@davemloft.net Cc: netdev@vger.kernel.org, ecree.xilinx@gmail.com, michael.chan@broadcom.com, damian.dybek@intel.com, paul.greenwalt@intel.com, rajur@chelsio.com, jaroslawx.gawin@intel.com, vkochan@marvell.com, alobakin@pm.me, snelson@pensando.io, shayagr@amazon.com, ayal@nvidia.com, shenjian15@huawei.com, saeedm@nvidia.com, mkubecek@suse.cz, andrew@lunn.ch, roopa@nvidia.com, Jakub Kicinski Subject: [PATCH net-next 0/6] ethtool: clarify the ethtool FEC interface Date: Wed, 24 Mar 2021 18:11:54 -0700 Message-Id: <20210325011200.145818-1-kuba@kernel.org> X-Mailer: git-send-email 2.30.2 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org X-Patchwork-Delegate: kuba@kernel.org Our FEC configuration interface is one of the more confusing. It also lacks any error checking in the core. This certainly shows in the varying implementations across the drivers. Improve the documentation and add most basic checks. Sadly, it's probably too late now to try to enforce much more uniformity. Any thoughts & suggestions welcome. Next step is to add netlink for FEC, then stats. Jakub Kicinski (6): ethtool: fec: fix typo in kdoc ethtool: fec: remove long structure description ethtool: fec: sanitize ethtool_fecparam->reserved ethtool: fec: sanitize ethtool_fecparam->active_fec ethtool: fec: sanitize ethtool_fecparam->fec ethtool: clarify the ethtool FEC interface include/uapi/linux/ethtool.h | 39 +++++++++++++++++++++++++++--------- net/ethtool/ioctl.c | 9 +++++++++ 2 files changed, 38 insertions(+), 10 deletions(-)