mbox series

[net,0/2] net: do not modify the shared tunnel info when PMTU triggers an ICMP reply

Message ID 20210325153533.770125-1-atenart@kernel.org (mailing list archive)
Headers show
Series net: do not modify the shared tunnel info when PMTU triggers an ICMP reply | expand

Message

Antoine Tenart March 25, 2021, 3:35 p.m. UTC
Hi,

The series fixes an issue were a shared ip_tunnel_info is modified when
PMTU triggers an ICMP reply in vxlan and geneve, making following
packets in that flow to have a wrong destination address if the flow
isn't updated. A detailled information is given in each of the two
commits.

This was tested manually with OVS and I ran the PTMU selftests with
kmemleak enabled (all OK, none was skipped).

Thanks!
Antoine

Antoine Tenart (2):
  vxlan: do not modify the shared tunnel info when PMTU triggers an ICMP
    reply
  geneve: do not modify the shared tunnel info when PMTU triggers an
    ICMP reply

 drivers/net/geneve.c | 24 ++++++++++++++++++++----
 drivers/net/vxlan.c  | 18 ++++++++++++++----
 2 files changed, 34 insertions(+), 8 deletions(-)

Comments

Stefano Brivio March 25, 2021, 8:28 p.m. UTC | #1
On Thu, 25 Mar 2021 16:35:31 +0100
Antoine Tenart <atenart@kernel.org> wrote:

> Hi,
> 
> The series fixes an issue were a shared ip_tunnel_info is modified when
> PMTU triggers an ICMP reply in vxlan and geneve, making following
> packets in that flow to have a wrong destination address if the flow
> isn't updated. A detailled information is given in each of the two
> commits.
> 
> This was tested manually with OVS and I ran the PTMU selftests with
> kmemleak enabled (all OK, none was skipped).
> 
> Thanks!
> Antoine
> 
> Antoine Tenart (2):
>   vxlan: do not modify the shared tunnel info when PMTU triggers an ICMP
>     reply
>   geneve: do not modify the shared tunnel info when PMTU triggers an
>     ICMP reply

For the series,

Reviewed-by: Stefano Brivio <sbrivio@redhat.com>

Thanks for fixing this!
patchwork-bot+netdevbpf@kernel.org March 26, 2021, 12:40 a.m. UTC | #2
Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Thu, 25 Mar 2021 16:35:31 +0100 you wrote:
> Hi,
> 
> The series fixes an issue were a shared ip_tunnel_info is modified when
> PMTU triggers an ICMP reply in vxlan and geneve, making following
> packets in that flow to have a wrong destination address if the flow
> isn't updated. A detailled information is given in each of the two
> commits.
> 
> [...]

Here is the summary with links:
  - [net,1/2] vxlan: do not modify the shared tunnel info when PMTU triggers an ICMP reply
    https://git.kernel.org/netdev/net/c/30a93d2b7d5a
  - [net,2/2] geneve: do not modify the shared tunnel info when PMTU triggers an ICMP reply
    https://git.kernel.org/netdev/net/c/68c1a943ef37

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html