[net-next,v2,0/6] ethtool: clarify the ethtool FEC interface

Message

Jakub Kicinski March 26, 2021, 2:07 a.m. UTC

Our FEC configuration interface is one of the more confusing.
It also lacks any error checking in the core. This certainly
shows in the varying implementations across the drivers.

Improve the documentation and add most basic checks. Sadly, it's
probably too late now to try to enforce much more uniformity.

Any thoughts & suggestions welcome. Next step is to add netlink
for FEC, then stats.

v2: 
 - fix patch 5
 - adjust kdoc in patches 3 and 6

Jakub Kicinski (6):
  ethtool: fec: fix typo in kdoc
  ethtool: fec: remove long structure description
  ethtool: fec: sanitize ethtool_fecparam->reserved
  ethtool: fec: sanitize ethtool_fecparam->active_fec
  ethtool: fec: sanitize ethtool_fecparam->fec
  ethtool: clarify the ethtool FEC interface

 include/uapi/linux/ethtool.h | 45 +++++++++++++++++++++++++++---------
 net/ethtool/ioctl.c          |  9 ++++++++
 2 files changed, 43 insertions(+), 11 deletions(-)

Comments

David Miller March 26, 2021, 9:49 p.m. UTC | #1

From: Jakub Kicinski <[e-mail]>
Date: Thu, 25 Mar 2021 19:07:21 -0700

> Our FEC configuration interface is one of the more confusing.
> It also lacks any error checking in the core. This certainly
> shows in the varying implementations across the drivers.
> 
> Improve the documentation and add most basic checks. Sadly, it's
> probably too late now to try to enforce much more uniformity.
> 
> Any thoughts & suggestions welcome. Next step is to add netlink
> for FEC, then stats.
> 
> v2: 
>  - fix patch 5
>  - adjust kdoc in patches 3 and 6

Jakub, I applied v1 so please send fiixups relative to that, thank you.