mbox series

[0/3] bpf/selftests: page size fixes

Message ID 20210326114658.210034-1-yauheni.kaliuta@redhat.com (mailing list archive)
Headers show
Series bpf/selftests: page size fixes | expand

Message

Yauheni Kaliuta March 26, 2021, 11:46 a.m. UTC 
A set of fixes for selftests to make them working on systems with PAGE_SIZE > 4K

2 questions left:

- about `nit: if (!ASSERT_OK(err, "setsockopt_attach"))`. I left
  CHECK() for now since otherwise it has too many negations. But
  should I anyway use ASSERT?

- https://github.com/torvalds/linux/blob/master/tools/testing/selftests/bpf/prog_tests/mmap.c#L41
  and below -- it works now as is, but should be switched also to page_size?

Yauheni Kaliuta (3):
  selftests/bpf: test_progs/sockopt_sk: pass page size from userspace
  bpf: selftests: test_progs/sockopt_sk: remove version
  selftests/bpf: ringbuf, mmap: bump up page size to 64K

 tools/testing/selftests/bpf/prog_tests/ringbuf.c      |  9 +++++++--
 tools/testing/selftests/bpf/prog_tests/sockopt_sk.c   |  2 ++
 tools/testing/selftests/bpf/progs/map_ptr_kern.c      |  9 +++++++--
 tools/testing/selftests/bpf/progs/sockopt_sk.c        | 11 ++++-------
 tools/testing/selftests/bpf/progs/test_mmap.c         | 10 ++++++++--
 tools/testing/selftests/bpf/progs/test_ringbuf.c      |  8 +++++++-
 .../testing/selftests/bpf/progs/test_ringbuf_multi.c  |  7 ++++++-
 7 files changed, 41 insertions(+), 15 deletions(-)

Comments

Yauheni Kaliuta March 26, 2021, 12:21 p.m. UTC | #1 
Oops, one patch is missing.

Will recend

On Fri, Mar 26, 2021 at 1:47 PM Yauheni Kaliuta
<yauheni.kaliuta@redhat.com> wrote:
>
> A set of fixes for selftests to make them working on systems with PAGE_SIZE > 4K
>
> 2 questions left:
>
> - about `nit: if (!ASSERT_OK(err, "setsockopt_attach"))`. I left
>   CHECK() for now since otherwise it has too many negations. But
>   should I anyway use ASSERT?
>
> - https://github.com/torvalds/linux/blob/master/tools/testing/selftests/bpf/prog_tests/mmap.c#L41
>   and below -- it works now as is, but should be switched also to page_size?
>
> Yauheni Kaliuta (3):
>   selftests/bpf: test_progs/sockopt_sk: pass page size from userspace
>   bpf: selftests: test_progs/sockopt_sk: remove version
>   selftests/bpf: ringbuf, mmap: bump up page size to 64K
>
>  tools/testing/selftests/bpf/prog_tests/ringbuf.c      |  9 +++++++--
>  tools/testing/selftests/bpf/prog_tests/sockopt_sk.c   |  2 ++
>  tools/testing/selftests/bpf/progs/map_ptr_kern.c      |  9 +++++++--
>  tools/testing/selftests/bpf/progs/sockopt_sk.c        | 11 ++++-------
>  tools/testing/selftests/bpf/progs/test_mmap.c         | 10 ++++++++--
>  tools/testing/selftests/bpf/progs/test_ringbuf.c      |  8 +++++++-
>  .../testing/selftests/bpf/progs/test_ringbuf_multi.c  |  7 ++++++-
>  7 files changed, 41 insertions(+), 15 deletions(-)
>
> --
> 2.29.2
>