[net-next,00/13] MPTCP: Cleanup and address advertisement fixes

Message

Mat Martineau March 26, 2021, 6:23 p.m. UTC

This patch series contains cleanup and fixes we have been testing in the
MPTCP tree. MPTCP uses TCP option headers to advertise additional
address information after an initial connection is established. The main
fixes here deal with making those advertisements more reliable and
improving the way subflows are created after an advertisement is
received.


Patches 1, 2, 4, 10, and 12 are for various cleanup or refactoring.

Patch 3 skips an extra connection attempt if there's already a subflow
connection for the newly received advertisement.

Patches 5, 6, and 7 make sure that the next address is advertised when
there are multiple addresses to share, the advertisement has been
retried, and the peer has not echoed the advertisement. Self tests are
updated.

Patches 8 and 9 fix a problem similar to 5/6/7, but covers a case where
the failure was due to a subflow connection not completing.

Patches 11 and 13 send a bare ack to revoke an advertisement rather than
waiting for other activity to trigger a packet send. This mirrors the
way acks are sent for new advertisements. Self test is included.


Geliang Tang (12):
  mptcp: drop argument port from mptcp_pm_announce_addr
  mptcp: skip connecting the connected address
  mptcp: drop unused subflow in mptcp_pm_subflow_established
  mptcp: move to next addr when timeout
  selftests: mptcp: add cfg_do_w for cfg_remove
  selftests: mptcp: timeout testcases for multi addresses
  mptcp: export lookup_anno_list_by_saddr
  mptcp: move to next addr when subflow creation fail
  mptcp: drop useless addr_signal clear
  mptcp: send ack for rm_addr
  mptcp: rename mptcp_pm_nl_add_addr_send_ack
  selftests: mptcp: signal addresses testcases

Paolo Abeni (1):
  mptcp: clean-up the rtx path

 net/mptcp/options.c                           |  3 +-
 net/mptcp/pm.c                                | 25 ++++--
 net/mptcp/pm_netlink.c                        | 69 +++++++++------
 net/mptcp/protocol.c                          | 42 +++-------
 net/mptcp/protocol.h                          | 12 ++-
 .../selftests/net/mptcp/mptcp_connect.c       | 10 ++-
 .../testing/selftests/net/mptcp/mptcp_join.sh | 84 ++++++++++++++++++-
 7 files changed, 173 insertions(+), 72 deletions(-)


base-commit: 6c996e19949b34d7edebed4f6b0511145c036404

Comments

[e-mail] March 26, 2021, 10:10 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Fri, 26 Mar 2021 11:23:07 -0700 you wrote:
> This patch series contains cleanup and fixes we have been testing in the
> MPTCP tree. MPTCP uses TCP option headers to advertise additional
> address information after an initial connection is established. The main
> fixes here deal with making those advertisements more reliable and
> improving the way subflows are created after an advertisement is
> received.
> 
> [...]

Here is the summary with links:
  - [net-next,01/13] mptcp: clean-up the rtx path
    https://git.kernel.org/netdev/net-next/c/2d6f5a2b5720
  - [net-next,02/13] mptcp: drop argument port from mptcp_pm_announce_addr
    https://git.kernel.org/netdev/net-next/c/f7efc7771eac
  - [net-next,03/13] mptcp: skip connecting the connected address
    https://git.kernel.org/netdev/net-next/c/d84ad04941c3
  - [net-next,04/13] mptcp: drop unused subflow in mptcp_pm_subflow_established
    https://git.kernel.org/netdev/net-next/c/62535200be17
  - [net-next,05/13] mptcp: move to next addr when timeout
    https://git.kernel.org/netdev/net-next/c/348d5c1dec60
  - [net-next,06/13] selftests: mptcp: add cfg_do_w for cfg_remove
    https://git.kernel.org/netdev/net-next/c/2e580a63b5c2
  - [net-next,07/13] selftests: mptcp: timeout testcases for multi addresses
    https://git.kernel.org/netdev/net-next/c/8da6229b9524
  - [net-next,08/13] mptcp: export lookup_anno_list_by_saddr
    https://git.kernel.org/netdev/net-next/c/d88c476f4a7d
  - [net-next,09/13] mptcp: move to next addr when subflow creation fail
    https://git.kernel.org/netdev/net-next/c/557963c383e8
  - [net-next,10/13] mptcp: drop useless addr_signal clear
    https://git.kernel.org/netdev/net-next/c/b65d95adb802
  - [net-next,11/13] mptcp: send ack for rm_addr
    https://git.kernel.org/netdev/net-next/c/8dd5efb1f91b
  - [net-next,12/13] mptcp: rename mptcp_pm_nl_add_addr_send_ack
    https://git.kernel.org/netdev/net-next/c/b46a02381093
  - [net-next,13/13] selftests: mptcp: signal addresses testcases
    https://git.kernel.org/netdev/net-next/c/ef360019db40

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html