| Message ID | 20210408183828.1907807-1-martin.blumenstingl@googlemail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | lantiq: GSWIP: two more fixes | expand |
Hello: This series was applied to netdev/net.git (refs/heads/master): On Thu, 8 Apr 2021 20:38:26 +0200 you wrote: > Hello, > > after my last patch got accepted and is now in net as commit > 3e6fdeb28f4c33 ("net: dsa: lantiq_gswip: Let GSWIP automatically set > the xMII clock") [0] some more people from the OpenWrt community > (many thanks to everyone involved) helped test the GSWIP driver: [1] > > [...] Here is the summary with links: - [net,v2,1/2] net: dsa: lantiq_gswip: Don't use PHY auto polling https://git.kernel.org/netdev/net/c/3e9005be8777 - [net,v2,2/2] net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits https://git.kernel.org/netdev/net/c/4b5923249b8f You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
Hello, after my last patch got accepted and is now in net as commit 3e6fdeb28f4c33 ("net: dsa: lantiq_gswip: Let GSWIP automatically set the xMII clock") [0] some more people from the OpenWrt community (many thanks to everyone involved) helped test the GSWIP driver: [1] It turns out that the previous fix does not work for all boards. There's no regression, but it doesn't fix as many problems as I thought. This is why two more fixes are needed: - the first one solves many (four known but probably there are a few extra hidden ones) reported bugs with the GSWIP where no traffic would flow. Not all circumstances are fully understood but testing shows that switching away from PHY auto polling solves all of them - while investigating the different problems which are addressed by the first patch some small issues with the existing code were found. These are addressed by the second patch Changes since v1 at [0]: - Don't configure the link parameters in gswip_phylink_mac_config (as we're using the "modern" way in gswip_phylink_mac_link_up). Thanks to Andrew for the hint with the phylink documentation. - Clarify that GSWIP_MII_CFG_RMII_CLK is ignored by the hardware in the description of the second patch as suggested by Hauke - Don't set GSWIP_MII_CFG_RGMII_IBS in the second patch as we don't have any hardware available for testing this. The patch description now also reflects this. - Added Andrew's Reviewed-by to the first patch (thank you!) Best regards, Martin [0] https://patchwork.kernel.org/project/netdevbpf/cover/20210406203508.476122-1-martin.blumenstingl@googlemail.com/ Martin Blumenstingl (2): net: dsa: lantiq_gswip: Don't use PHY auto polling net: dsa: lantiq_gswip: Configure all remaining GSWIP_MII_CFG bits drivers/net/dsa/lantiq_gswip.c | 202 ++++++++++++++++++++++++++++----- 1 file changed, 174 insertions(+), 28 deletions(-)