From patchwork Wed May 12 09:58:22 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: xufeng zhang X-Patchwork-Id: 12253201 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9218CC433B4 for ; Wed, 12 May 2021 09:59:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53428613C3 for ; Wed, 12 May 2021 09:59:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230160AbhELKAL (ORCPT ); Wed, 12 May 2021 06:00:11 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:50259 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230096AbhELKAL (ORCPT ); Wed, 12 May 2021 06:00:11 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04394;MF=yunbo.xufeng@linux.alibaba.com;NM=1;PH=DS;RN=15;SR=0;TI=SMTPD_---0UYdyiiS_1620813539; Received: from localhost.localdomain(mailfrom:yunbo.xufeng@linux.alibaba.com fp:SMTPD_---0UYdyiiS_1620813539) by smtp.aliyun-inc.com(127.0.0.1); Wed, 12 May 2021 17:59:00 +0800 From: Xufeng Zhang To: kpsingh@kernel.org, ast@kernel.org, daniel@iogearbox.net, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, linux-security-module@vger.kernel.org Cc: revest@chromium.org, jackmanb@chromium.org, yhs@fb.com, songliubraving@fb.com, kafai@fb.com, john.fastabend@gmail.com, joe@cilium.io, quentin@isovalent.com, Xufeng Zhang Subject: [RFC] [PATCH bpf-next 0/1] Implement getting cgroup path bpf helper Date: Wed, 12 May 2021 17:58:22 +0800 Message-Id: <20210512095823.99162-1-yunbo.xufeng@linux.alibaba.com> X-Mailer: git-send-email 2.20.1 (Apple Git-117) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: bpf@vger.kernel.org X-Patchwork-State: RFC In order to protect the running application containers by utilizing bpf LSM, we need to upload the security rules into bpf maps in container granularity, however, there is no effective bpf helper to identify the container, especially for cgroup v1. Generally, the only thing which the user side can get is container ID, and the cgroup path for this running container is fixed if we know the container ID, therefore, bpf programs also need to get the cgroup path for the running task in order to apply security rules stored in bpf maps. This patch add a bpf helper - bpf_get_current_cpuset_cgroup_path(), which return the cpuset cgroup path for the current task, since cgroup_path_ns() can sleep, this helper is only allowed for sleepable LSM hooks. Concern: Since cgroup_path_ns() takes 'cgroup_mutex' and 'css_set_lock' lock, I'm not sure if there is any dead lock code path in LSM hooks. Xufeng Zhang (1): bpf: Add a BPF helper for getting the cgroup path of current task --- include/uapi/linux/bpf.h | 13 +++++++++++++ kernel/bpf/bpf_lsm.c | 28 ++++++++++++++++++++++++++++ tools/include/uapi/linux/bpf.h | 13 +++++++++++++ 3 files changed, 54 insertions(+)