From patchwork Mon May 24 15:59:39 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Fitzgerald X-Patchwork-Id: 12276539 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6102C2B9F7 for ; Mon, 24 May 2021 16:01:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A7E216109F for ; Mon, 24 May 2021 16:01:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235885AbhEXQDE (ORCPT ); Mon, 24 May 2021 12:03:04 -0400 Received: from mx0b-001ae601.pphosted.com ([67.231.152.168]:59140 "EHLO mx0b-001ae601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234967AbhEXQCL (ORCPT ); Mon, 24 May 2021 12:02:11 -0400 Received: from pps.filterd (m0077474.ppops.net [127.0.0.1]) by mx0b-001ae601.pphosted.com (8.16.0.43/8.16.0.43) with SMTP id 14OFv7WI009692; Mon, 24 May 2021 10:59:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cirrus.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding : content-type; s=PODMain02222019; bh=S7FQg2IR5Mf3ip3RJT1rmhF6CLbED/7CxbMJUwPMbeg=; b=jRNr5gpjiUklo9RnEDw9Hl0fhTLUcasmKe9rvfmUwItre8tB52+nFqqlO/qX5Vy37ui4 tCvRQjTmXVS3EKwlOqu8uExXuMcocBTIfg1VgVK1+T6mXEpKpde+7VUlFKjU4j2Op3lX SDET2dNCB2KCuARZdoyXJajiXvpnaul2q6jog+YbB3DTliaKdKN0q6KEr+4BIcgJhTG/ Wd8YbDTWYN88cj40Ffj1SsXgXnVqL8RXRTR5I8JIPLaTkOUG5oSO7JqnGEM0fCKlhdGR dBqE04rxYjxfYdSgQU/YmHacEwchmxqk9av2on3Wssos9ZueJRrfxGJ9fM2kx8drh4fk 8w== Received: from ediex02.ad.cirrus.com ([87.246.76.36]) by mx0b-001ae601.pphosted.com with ESMTP id 38r28v0qh4-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT); Mon, 24 May 2021 10:59:44 -0500 Received: from EDIEX01.ad.cirrus.com (198.61.84.80) by EDIEX02.ad.cirrus.com (198.61.84.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.4; Mon, 24 May 2021 16:59:42 +0100 Received: from ediswmail.ad.cirrus.com (198.61.86.93) by EDIEX01.ad.cirrus.com (198.61.84.80) with Microsoft SMTP Server id 15.1.2242.4 via Frontend Transport; Mon, 24 May 2021 16:59:42 +0100 Received: from AUSNPC0LSNW1-debian.cirrus.com (AUSNPC0LSNW1.ad.cirrus.com [198.61.64.127]) by ediswmail.ad.cirrus.com (Postfix) with ESMTP id 0BC8E11D6; Mon, 24 May 2021 15:59:42 +0000 (UTC) From: Richard Fitzgerald To: , , , , , , , , CC: , , , Richard Fitzgerald Subject: [PATCH 0/2] Fix truncation warnings from building test_scanf.c Date: Mon, 24 May 2021 16:59:39 +0100 Message-ID: <20210524155941.16376-1-rf@opensource.cirrus.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-Proofpoint-ORIG-GUID: 5XI6TMK2TrxJFx0TsxnEbSe47ggppj5O X-Proofpoint-GUID: 5XI6TMK2TrxJFx0TsxnEbSe47ggppj5O X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1011 suspectscore=0 priorityscore=1501 malwarescore=0 spamscore=0 mlxscore=0 lowpriorityscore=0 mlxlogscore=714 bulkscore=0 impostorscore=0 adultscore=0 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2104190000 definitions=main-2105240096 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The kernel test robot is reporting truncation warnings when building lib/test_scanf.c: 1) lib/test_scanf.c:250:9: sparse: sparse: cast truncates bits from constant value (ffff0001 becomes 1) Reported on several lines. 2) include/linux/prandom.h:114:45: sparse: sparse: cast truncates bits from constant value (4f2e5357408c3c09 becomes 408c3c09) (1) is caused by test_scanf.c using type_min() on an unsigned type. The type_min() macro calculates -type_max() - 1, so is only meaningful for signed types. (2) is caused by prandom_seed_state() storing a modified u64 seed value into a u32 - sparse will warn that this causes a truncation. The two patches in this series fix these problems. Richard Fitzgerald (2): lib: test_scanf: Fix incorrect use of type_min() with unsigned types random32: Fix implicit truncation warning in prandom_seed_state() include/linux/prandom.h | 2 +- lib/test_scanf.c | 13 ++++++------- 2 files changed, 7 insertions(+), 8 deletions(-) Reviewed-by: Petr Mladek