mbox series

[RESEND,net,v3,0/3] Fix IPsec crypto offloads with vxlan tunnel

Message ID 20210603160045.11805-1-huyn@nvidia.com (mailing list archive)
Headers show
Series Fix IPsec crypto offloads with vxlan tunnel | expand

Message

Huy Nguyen June 3, 2021, 4 p.m. UTC 
v1 -> v2:
  - Move inner_ipproto into xfrm_offload structure.
  - Fix static code analysis errors.
  - skip checking for skb->encapsulation to be more flexible for vendor

v2 -> v3:
  - Fix bug in patch 003 when checking for xo null pointer in mlx5e_ipsec_feature_check
  - Fix bug of accidentally commenting out memset in patch 003

This small series fixes ipsec TX offloads with vxlan overlay on top of
the offloaded ipsec packet, the driver (mlx5) was lacking such information
and the skb->encapsulation bit wasn't enough as indication to reach the
vxlan inner headers, as a solution we mark the tunnel in the offloaded
context of ipsec.

Huy Nguyen (3):
  net/mlx5: Optimize mlx5e_feature_checks for non IPsec packet
  net/xfrm: Add inner_ipproto into sec_path
  net/mlx5: Fix checksum issue of VXLAN and IPsec crypto offload

 .../mellanox/mlx5/core/en_accel/ipsec_rxtx.c  | 65 ++++++++++++++-----
 .../mellanox/mlx5/core/en_accel/ipsec_rxtx.h  | 37 ++++++++---
 .../net/ethernet/mellanox/mlx5/core/en_main.c |  8 ++-
 include/net/xfrm.h                            |  1 +
 net/xfrm/xfrm_output.c                        | 44 ++++++++++++-
 5 files changed, 127 insertions(+), 28 deletions(-)

Comments

Steffen Klassert June 4, 2021, 7:57 a.m. UTC | #1 
On Thu, Jun 03, 2021 at 07:00:42PM +0300, Huy Nguyen wrote:
> v1 -> v2:
>   - Move inner_ipproto into xfrm_offload structure.
>   - Fix static code analysis errors.
>   - skip checking for skb->encapsulation to be more flexible for vendor
> 
> v2 -> v3:
>   - Fix bug in patch 003 when checking for xo null pointer in mlx5e_ipsec_feature_check
>   - Fix bug of accidentally commenting out memset in patch 003
> 
> This small series fixes ipsec TX offloads with vxlan overlay on top of
> the offloaded ipsec packet, the driver (mlx5) was lacking such information
> and the skb->encapsulation bit wasn't enough as indication to reach the
> vxlan inner headers, as a solution we mark the tunnel in the offloaded
> context of ipsec.

This patchset does not look like a fix. It looks more that you add
a feature that was not supported before, so the pachset should
go to -next.

Also, who should merge that pachset? I contains xfrm and mlx5
parts.