| Message ID | 20210609151602.29004-1-oleksandr.mazur@plvision.eu (mailing list archive) |
|---|---|
| Headers | show |
| Series | Marvell Prestera driver implementation of devlink functionality. | expand |
> Prestera Switchdev driver implements a set of devlink-based features, > that include both debug functionality (traps with trap statistics), as well > as functional rate limiter that is based on the devlink kernel API (interfaces). > The core prestera-devlink functionality is implemented in the prestera_devlink.c. > The patch series also extends the existing devlink kernel API with a list of core > features: > - devlink: add API for both publish/unpublish port parameters. > - devlink: add port parameters-specific ops, as current design makes it impossible > to register one parameter for multiple ports, and effectively distinguish for > what port parameter_op is called. As we discussed the storm control (BUM) done via devlink port params topic, and agreed that it shouldn't be done using the devlink API itself, there's an open question i'd like to address: the patch series included, for what i think, list of needed and benefitial changes, and those are the following patches: > Oleksandr Mazur (2): ... > net: core: devlink: add port_params_ops for devlink port parameters altering > drivers: net: netdevsim: add devlink port params usage > Sudarsana Reddy Kalluru (1): > net: core: devlink: add apis to publish/unpublish port params So, should i create a new patch series that would include all of them? Because in that case the series itself would lack an actual HW usage of it. The only usage would be limited to the netdevsim driver.
On Thu, Jun 17, 2021 at 05:30:07PM +0000, Oleksandr Mazur wrote: > > Prestera Switchdev driver implements a set of devlink-based features, > > that include both debug functionality (traps with trap statistics), as well > > as functional rate limiter that is based on the devlink kernel API (interfaces). > > > The core prestera-devlink functionality is implemented in the prestera_devlink.c. > > > The patch series also extends the existing devlink kernel API with a list of core > > features: > > - devlink: add API for both publish/unpublish port parameters. > > - devlink: add port parameters-specific ops, as current design makes it impossible > > to register one parameter for multiple ports, and effectively distinguish for > > what port parameter_op is called. > > As we discussed the storm control (BUM) done via devlink port params topic, and agreed that it shouldn't be done using the devlink API itself, there's an open question i'd like to address: the patch series included, for what i think, list of needed and benefitial changes, and those are the following patches: Please wrap your emails at around 70 characters. > > > Oleksandr Mazur (2): > ... > > net: core: devlink: add port_params_ops for devlink port parameters altering > > drivers: net: netdevsim: add devlink port params usage > > > Sudarsana Reddy Kalluru (1): > > net: core: devlink: add apis to publish/unpublish port params > > So, should i create a new patch series that would include all of them? > > Because in that case the series itself would lack an actual HW usage of it. The only usage would be limited to the netdevsim driver. We generally don't add APIs without a user. And in this case, i'm not sure netdevsim is a valid user. Can you refactor some other driver to make use of the new code? If not, i would suggest they are not merged at the moment. When you do have a valid use case, you can post them again. Andrew
Prestera Switchdev driver implements a set of devlink-based features, that include both debug functionality (traps with trap statistics), as well as functional rate limiter that is based on the devlink kernel API (interfaces). The core prestera-devlink functionality is implemented in the prestera_devlink.c. The patch series also extends the existing devlink kernel API with a list of core features: - devlink: add API for both publish/unpublish port parameters. - devlink: add port parameters-specific ops, as current design makes it impossible to register one parameter for multiple ports, and effectively distinguish for what port parameter_op is called. - devlink: add trap_drop_counter_get callback for driver to register - make it possible to keep track of how many packets have been dropped (hard) by the switch device, before the packets even made it to the devlink subsystem (e.g. dropped due to RXDMA buffer overflow). The core features that extend current functionality of prestera Switchdev driver: - add storm control (BUM control) functionality, that is driven through the devlink (per) port parameters. - add logic for driver traps and drops registration (also traps with DROP action). - add documentation for prestera driver traps and drops group. Oleksandr Mazur (10): net: core: devlink: add dropped stats traps field net: core: devlink: add port_params_ops for devlink port parameters altering testing: selftests: net: forwarding: add devlink-required functionality to test (hard) dropped stats field drivers: net: netdevsim: add devlink trap_drop_counter_get implementation testing: selftests: drivers: net: netdevsim: devlink: add test case for hard drop statistics drivers: net: netdevsim: add devlink port params usage net: marvell: prestera: devlink: add traps/groups implementation net: marvell: prestera: devlink: add traps with DROP action net: marvell: prestera: add storm control (rate limiter) implementation documentation: networking: devlink: add prestera switched driver Documentation Sudarsana Reddy Kalluru (1): net: core: devlink: add apis to publish/unpublish port params Documentation/networking/devlink/prestera.rst | 167 +++++ .../net/ethernet/marvell/prestera/prestera.h | 9 + .../marvell/prestera/prestera_devlink.c | 664 +++++++++++++++++- .../marvell/prestera/prestera_devlink.h | 3 + .../ethernet/marvell/prestera/prestera_dsa.c | 3 + .../ethernet/marvell/prestera/prestera_dsa.h | 1 + .../ethernet/marvell/prestera/prestera_hw.c | 60 ++ .../ethernet/marvell/prestera/prestera_hw.h | 20 + .../ethernet/marvell/prestera/prestera_rxtx.c | 7 +- drivers/net/netdevsim/dev.c | 108 ++- drivers/net/netdevsim/netdevsim.h | 3 + include/net/devlink.h | 35 + net/core/devlink.c | 139 +++- .../drivers/net/netdevsim/devlink_trap.sh | 10 + .../selftests/net/forwarding/devlink_lib.sh | 26 + 15 files changed, 1238 insertions(+), 17 deletions(-) create mode 100644 Documentation/networking/devlink/prestera.rst