mbox series

[net,0/3] net: macsec: fix key length when offloading

Message ID 20210624093830.943139-1-atenart@kernel.org (mailing list archive)
Headers show
Series net: macsec: fix key length when offloading | expand

Message

Antoine Tenart June 24, 2021, 9:38 a.m. UTC 
Hello,

The key length used to copy the key to offloading drivers and to store
it is wrong and was working by chance as it matched the default key
length. But using a different key length fails. Fix it by using instead
the max length accepted in uAPI to store the key and the actual key
length when copying it.

This was tested on the MSCC PHY driver but not on the Atlantic MAC
(looking at the code it looks ok, but testing would be appreciated).

Thanks,
Antoine

Antoine Tenart (3):
  net: macsec: fix the length used to copy the key for offloading
  net: phy: mscc: fix macsec key length
  net: atlantic: fix the macsec key length

 drivers/net/ethernet/aquantia/atlantic/aq_macsec.h | 4 ++--
 drivers/net/macsec.c                               | 4 ++--
 drivers/net/phy/mscc/mscc_macsec.c                 | 2 +-
 drivers/net/phy/mscc/mscc_macsec.h                 | 2 +-
 include/net/macsec.h                               | 2 +-
 5 files changed, 7 insertions(+), 7 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org June 24, 2021, 7:50 p.m. UTC | #1 
Hello:

This series was applied to netdev/net.git (refs/heads/master):

On Thu, 24 Jun 2021 11:38:27 +0200 you wrote:
> Hello,
> 
> The key length used to copy the key to offloading drivers and to store
> it is wrong and was working by chance as it matched the default key
> length. But using a different key length fails. Fix it by using instead
> the max length accepted in uAPI to store the key and the actual key
> length when copying it.
> 
> [...]

Here is the summary with links:
  - [net,1/3] net: macsec: fix the length used to copy the key for offloading
    https://git.kernel.org/netdev/net/c/1f7fe5121127
  - [net,2/3] net: phy: mscc: fix macsec key length
    https://git.kernel.org/netdev/net/c/c309217f91f2
  - [net,3/3] net: atlantic: fix the macsec key length
    https://git.kernel.org/netdev/net/c/d67fb4772d9a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html