| Message ID | 20210627115429.1084203-1-olteanv@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Cleanup for the bridge replay helpers | expand |
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Sun, 27 Jun 2021 14:54:21 +0300 you wrote: > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > This patch series brings some improvements to the logic added to the > bridge and DSA to handle LAG interfaces sandwiched between a bridge and > a DSA switch port. > > br0 > / \ > / \ > bond0 swp2 > / \ > / \ > swp0 swp1 > > [...] Here is the summary with links: - [v2,net-next,1/8] net: bridge: include the is_local bit in br_fdb_replay https://git.kernel.org/netdev/net-next/c/e887b2df6251 - [v2,net-next,2/8] net: ocelot: delete call to br_fdb_replay https://git.kernel.org/netdev/net-next/c/97558e880f63 - [v2,net-next,3/8] net: switchdev: add a context void pointer to struct switchdev_notifier_info https://git.kernel.org/netdev/net-next/c/69bfac968a06 - [v2,net-next,4/8] net: bridge: ignore switchdev events for LAG ports which didn't request replay https://git.kernel.org/netdev/net-next/c/0d2cfbd41c4a - [v2,net-next,5/8] net: bridge: constify variables in the replay helpers https://git.kernel.org/netdev/net-next/c/bdf123b455ce - [v2,net-next,6/8] net: bridge: allow the switchdev replay functions to be called for deletion https://git.kernel.org/netdev/net-next/c/7e8c18586daf - [v2,net-next,7/8] net: dsa: refactor the prechangeupper sanity checks into a dedicated function https://git.kernel.org/netdev/net-next/c/4ede74e73b5b - [v2,net-next,8/8] net: dsa: replay a deletion of switchdev objects for ports leaving a bridged LAG https://git.kernel.org/netdev/net-next/c/749189453234 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
From: Vladimir Oltean <vladimir.oltean@nxp.com> This patch series brings some improvements to the logic added to the bridge and DSA to handle LAG interfaces sandwiched between a bridge and a DSA switch port. br0 / \ / \ bond0 swp2 / \ / \ swp0 swp1 In particular, it ensures that the switchdev object additions and deletions are well balanced per physical port. This is important for future work in the area of offloading local bridge FDB entries to hardware in the context of DSA requesting a replay of those entries at bridge join time (this will be submitted in a future patch series). Due to some difficulty ensuring that the deletion of local FDB entries pointing towards the bridge device itself is notified to switchdev in time (before the switchdev port disconnects from the bridge), this is potentially still not the final form in which the replay helpers will exist. I'm thinking about moving from the pull mode (in which DSA requests the replay) to a push mode (in which the bridge initiates the replay). Nonetheless, these preliminary changes are needed either way. The patch series also addresses some feedback from Nikolai which is long overdue by now (sorry). Switchdev driver maintainers were deliberately omitted due to the trivial nature of the driver changes (just a function prototype). Changes in v2: - fix build issue in patch 4 (function prototype mismatch) - move switchdev object unsync to the NETDEV_PRECHANGEUPPER code path Vladimir Oltean (8): net: bridge: include the is_local bit in br_fdb_replay net: ocelot: delete call to br_fdb_replay net: switchdev: add a context void pointer to struct switchdev_notifier_info net: bridge: ignore switchdev events for LAG ports which didn't request replay net: bridge: constify variables in the replay helpers net: bridge: allow the switchdev replay functions to be called for deletion net: dsa: refactor the prechangeupper sanity checks into a dedicated function net: dsa: replay a deletion of switchdev objects for ports leaving a bridged LAG .../ethernet/freescale/dpaa2/dpaa2-switch.c | 2 +- .../marvell/prestera/prestera_switchdev.c | 6 +- .../mellanox/mlx5/core/en/rep/bridge.c | 3 + .../mellanox/mlxsw/spectrum_switchdev.c | 6 +- .../microchip/sparx5/sparx5_switchdev.c | 2 +- drivers/net/ethernet/mscc/ocelot_net.c | 29 +++-- drivers/net/ethernet/ti/am65-cpsw-switchdev.c | 6 +- drivers/net/ethernet/ti/cpsw_switchdev.c | 6 +- include/linux/if_bridge.h | 30 ++--- include/net/switchdev.h | 13 ++- net/bridge/br_fdb.c | 23 ++-- net/bridge/br_mdb.c | 23 ++-- net/bridge/br_stp.c | 4 +- net/bridge/br_vlan.c | 15 ++- net/dsa/dsa_priv.h | 4 + net/dsa/port.c | 58 +++++++-- net/dsa/slave.c | 110 +++++++++++++++--- net/switchdev/switchdev.c | 25 ++-- 18 files changed, 267 insertions(+), 98 deletions(-)