| Message ID | 20210629140658.2510288-1-olteanv@gmail.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | RX filtering in DSA | expand |
Hello: This series was applied to netdev/net-next.git (refs/heads/master): On Tue, 29 Jun 2021 17:06:43 +0300 you wrote: > From: Vladimir Oltean <vladimir.oltean@nxp.com> > > This is my 5th stab at creating a list of unicast and multicast > addresses that the DSA CPU ports must trap. I am reusing a lot of > Tobias's work which he submitted here: > https://patchwork.kernel.org/project/netdevbpf/cover/20210116012515.3152-1-tobias@waldekranz.com/ > > [...] Here is the summary with links: - [v5,net-next,01/15] net: bridge: use READ_ONCE() and WRITE_ONCE() compiler barriers for fdb->dst https://git.kernel.org/netdev/net-next/c/3e19ae7c6fd6 - [v5,net-next,02/15] net: bridge: switchdev: send FDB notifications for host addresses https://git.kernel.org/netdev/net-next/c/6eb38bf8eb90 - [v5,net-next,03/15] net: bridge: allow br_fdb_replay to be called for the bridge device https://git.kernel.org/netdev/net-next/c/f851a721a638 - [v5,net-next,04/15] net: dsa: delete dsa_legacy_fdb_add and dsa_legacy_fdb_del https://git.kernel.org/netdev/net-next/c/b117e1e8a86d - [v5,net-next,05/15] net: dsa: introduce dsa_is_upstream_port and dsa_switch_is_upstream_of https://git.kernel.org/netdev/net-next/c/63609c8fac40 - [v5,net-next,06/15] net: dsa: introduce a separate cross-chip notifier type for host MDBs https://git.kernel.org/netdev/net-next/c/b8e997c49003 - [v5,net-next,07/15] net: dsa: reference count the MDB entries at the cross-chip notifier level https://git.kernel.org/netdev/net-next/c/161ca59d39e9 - [v5,net-next,08/15] net: dsa: introduce a separate cross-chip notifier type for host FDBs https://git.kernel.org/netdev/net-next/c/3dc80afc5098 - [v5,net-next,09/15] net: dsa: reference count the FDB addresses at the cross-chip notifier level https://git.kernel.org/netdev/net-next/c/3f6e32f92a02 - [v5,net-next,10/15] net: dsa: install the host MDB and FDB entries in the master's RX filter https://git.kernel.org/netdev/net-next/c/26ee7b06a4d3 - [v5,net-next,11/15] net: dsa: sync static FDB entries on foreign interfaces to hardware https://git.kernel.org/netdev/net-next/c/3068d466a67e - [v5,net-next,12/15] net: dsa: include bridge addresses which are local in the host fdb list https://git.kernel.org/netdev/net-next/c/10fae4ac89ce - [v5,net-next,13/15] net: dsa: include fdb entries pointing to bridge in the host fdb list https://git.kernel.org/netdev/net-next/c/81a619f78759 - [v5,net-next,14/15] net: dsa: ensure during dsa_fdb_offload_notify that dev_hold and dev_put are on the same dev https://git.kernel.org/netdev/net-next/c/4bed397c3e65 - [v5,net-next,15/15] net: dsa: replay the local bridge FDB entries pointing to the bridge dev too https://git.kernel.org/netdev/net-next/c/63c51453c82c You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html
From: Vladimir Oltean <olteanv@gmail.com> Date: Tue, 29 Jun 2021 17:06:43 +0300 > Changes in v5: > - added READ_ONCE and WRITE_ONCE for fdb->dst > - removed a paranoid WARN_ON in DSA > - added some documentation regarding how 'bridge fdb' is supposed to be > used with DSA Vlad, I applied v4, could you please send me relative fixups to v5? Thank you.
On Tue, Jun 29, 2021 at 11:52:13AM -0700, David Miller wrote: > From: Vladimir Oltean <olteanv@gmail.com> > Date: Tue, 29 Jun 2021 17:06:43 +0300 > > > Changes in v5: > > - added READ_ONCE and WRITE_ONCE for fdb->dst > > - removed a paranoid WARN_ON in DSA > > - added some documentation regarding how 'bridge fdb' is supposed to be > > used with DSA > > Vlad, I applied v4, could you please send me relative fixups to v5? > > Thank you. Thanks for applying. I'm going to prepare the delta patches right now.
On Tue, Jun 29, 2021 at 09:58:22PM +0300, Vladimir Oltean wrote: > On Tue, Jun 29, 2021 at 11:52:13AM -0700, David Miller wrote: > > From: Vladimir Oltean <olteanv@gmail.com> > > Date: Tue, 29 Jun 2021 17:06:43 +0300 > > > > > Changes in v5: > > > - added READ_ONCE and WRITE_ONCE for fdb->dst > > > - removed a paranoid WARN_ON in DSA > > > - added some documentation regarding how 'bridge fdb' is supposed to be > > > used with DSA > > > > Vlad, I applied v4, could you please send me relative fixups to v5? > > > > Thank you. > > Thanks for applying. I'm going to prepare the delta patches right now. Dave, is it possible that you may have applied v5 with the cover letter from v4? I checked and everything is in its right place: - the READ_ONCE stuff for fdb->dst: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/net/bridge/br_fdb.c#n447 - there is no WARN_ON in DSA switch.c: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/net/dsa/switch.c#n167 - the additional documentation chapter is there: https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/Documentation/networking/dsa/configuration.rst#n296 Thanks.
From: Vladimir Oltean <olteanv@gmail.com> Date: Tue, 29 Jun 2021 22:09:23 +0300 > On Tue, Jun 29, 2021 at 09:58:22PM +0300, Vladimir Oltean wrote: >> On Tue, Jun 29, 2021 at 11:52:13AM -0700, David Miller wrote: >> > From: Vladimir Oltean <olteanv@gmail.com> >> > Date: Tue, 29 Jun 2021 17:06:43 +0300 >> > >> > > Changes in v5: >> > > - added READ_ONCE and WRITE_ONCE for fdb->dst >> > > - removed a paranoid WARN_ON in DSA >> > > - added some documentation regarding how 'bridge fdb' is supposed to be >> > > used with DSA >> > >> > Vlad, I applied v4, could you please send me relative fixups to v5? >> > >> > Thank you. >> >> Thanks for applying. I'm going to prepare the delta patches right now. > > Dave, is it possible that you may have applied v5 with the cover letter > from v4? I checked and everything is in its right place: Yes I believe that is what happened. Thanks for checking...
From: Vladimir Oltean <vladimir.oltean@nxp.com> This is my 5th stab at creating a list of unicast and multicast addresses that the DSA CPU ports must trap. I am reusing a lot of Tobias's work which he submitted here: https://patchwork.kernel.org/project/netdevbpf/cover/20210116012515.3152-1-tobias@waldekranz.com/ My additions to Tobias' work come in the form of taking some care that additions and removals of host addresses are properly balanced, so that we can do reference counting on them for cross-chip setups and multiple bridges spanning the same switch (I am working on an NXP board where both are real requirements). During the last attempted submission of multiple CPU ports for DSA: https://patchwork.kernel.org/project/netdevbpf/cover/20210410133454.4768-1-ansuelsmth@gmail.com/ it became clear that the concept of multiple CPU ports would not be compatible with the idea of address learning on those CPU ports (when those CPU ports are statically assigned to user ports, not in a LAG) unless the switch supports complete FDB isolation, which most switches do not. So DSA needs to manage in software all addresses that are installed on the CPU port(s), which is what this patch set does. Compared to all earlier attempts, this series does not fiddle with how DSA operates the ports in standalone mode at all, just when bridged. We need to sort that out properly, then any optimization that comes in standalone mode (i.e. IFF_UNICAST_FLT) can come later. Changes in v5: - added READ_ONCE and WRITE_ONCE for fdb->dst - removed a paranoid WARN_ON in DSA - added some documentation regarding how 'bridge fdb' is supposed to be used with DSA Tobias Waldekranz (2): net: bridge: switchdev: send FDB notifications for host addresses net: dsa: include bridge addresses which are local in the host fdb list Vladimir Oltean (13): net: bridge: use READ_ONCE() and WRITE_ONCE() compiler barriers for fdb->dst net: bridge: allow br_fdb_replay to be called for the bridge device net: dsa: delete dsa_legacy_fdb_add and dsa_legacy_fdb_del net: dsa: introduce dsa_is_upstream_port and dsa_switch_is_upstream_of net: dsa: introduce a separate cross-chip notifier type for host MDBs net: dsa: reference count the MDB entries at the cross-chip notifier level net: dsa: introduce a separate cross-chip notifier type for host FDBs net: dsa: reference count the FDB addresses at the cross-chip notifier level net: dsa: install the host MDB and FDB entries in the master's RX filter net: dsa: sync static FDB entries on foreign interfaces to hardware net: dsa: include fdb entries pointing to bridge in the host fdb list net: dsa: ensure during dsa_fdb_offload_notify that dev_hold and dev_put are on the same dev net: dsa: replay the local bridge FDB entries pointing to the bridge dev too .../networking/dsa/configuration.rst | 68 +++++ include/net/dsa.h | 39 +++ net/bridge/br_fdb.c | 37 ++- net/bridge/br_private.h | 7 +- net/bridge/br_switchdev.c | 12 +- net/dsa/dsa2.c | 14 + net/dsa/dsa_priv.h | 14 + net/dsa/port.c | 86 ++++++ net/dsa/slave.c | 102 +++---- net/dsa/switch.c | 273 +++++++++++++++++- 10 files changed, 573 insertions(+), 79 deletions(-)