mbox series

[net-next,00/13] Add Factorisation code to support Gigabit Ethernet driver

Message ID 20210825070154.14336-1-biju.das.jz@bp.renesas.com (mailing list archive)
Headers show
Series Add Factorisation code to support Gigabit Ethernet driver | expand

Message

Biju Das Aug. 25, 2021, 7:01 a.m. UTC 
The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are
similar to the R-Car Ethernet AVB IP.

The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal
TCP/IP Offload Engine (TOE)  and Dedicated Direct memory access controller
(DMAC).

With a few changes in the driver we can support both IPs.

This patch series aims to add factorisation code to support RZ/G2L SoC,
hardware feature bits for gPTP feature, Multiple irq feature and 
optional reset support.

Ref:-
 * https://lore.kernel.org/linux-renesas-soc/TYCPR01MB59334319695607A2683C1A5E86E59@TYCPR01MB5933.jpnprd01.prod.outlook.com/T/#t

Biju Das (13):
  ravb: Remove the macros NUM_TX_DESC_GEN[23]
  ravb: Add multi_irq to struct ravb_hw_info
  ravb: Add no_ptp_cfg_active to struct ravb_hw_info
  ravb: Add ptp_cfg_active to struct ravb_hw_info
  ravb: Factorise ravb_ring_free function
  ravb: Factorise ravb_ring_format function
  ravb: Factorise ravb_ring_init function
  ravb: Factorise ravb_rx function
  ravb: Factorise ravb_adjust_link function
  ravb: Factorise ravb_set_features
  ravb: Factorise ravb_dmac_init function
  ravb: Factorise ravb_emac_init function
  ravb: Add reset support

 drivers/net/ethernet/renesas/ravb.h      |  23 +-
 drivers/net/ethernet/renesas/ravb_main.c | 272 ++++++++++++++++-------
 drivers/net/ethernet/renesas/ravb_ptp.c  |   8 +-
 3 files changed, 204 insertions(+), 99 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Aug. 25, 2021, 10:30 a.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (refs/heads/master):

On Wed, 25 Aug 2021 08:01:41 +0100 you wrote:
> The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are
> similar to the R-Car Ethernet AVB IP.
> 
> The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal
> TCP/IP Offload Engine (TOE)  and Dedicated Direct memory access controller
> (DMAC).
> 
> [...]

Here is the summary with links:
  - [net-next,01/13] ravb: Remove the macros NUM_TX_DESC_GEN[23]
    https://git.kernel.org/netdev/net-next/c/c81d894226b9
  - [net-next,02/13] ravb: Add multi_irq to struct ravb_hw_info
    https://git.kernel.org/netdev/net-next/c/6de19fa0e9f7
  - [net-next,03/13] ravb: Add no_ptp_cfg_active to struct ravb_hw_info
    https://git.kernel.org/netdev/net-next/c/8f27219a6191
  - [net-next,04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
    https://git.kernel.org/netdev/net-next/c/a69a3d094de3
  - [net-next,05/13] ravb: Factorise ravb_ring_free function
    https://git.kernel.org/netdev/net-next/c/bf46b7578404
  - [net-next,06/13] ravb: Factorise ravb_ring_format function
    https://git.kernel.org/netdev/net-next/c/1ae22c19e75c
  - [net-next,07/13] ravb: Factorise ravb_ring_init function
    https://git.kernel.org/netdev/net-next/c/7870a41848ab
  - [net-next,08/13] ravb: Factorise ravb_rx function
    https://git.kernel.org/netdev/net-next/c/d5d95c11365b
  - [net-next,09/13] ravb: Factorise ravb_adjust_link function
    https://git.kernel.org/netdev/net-next/c/cb21104f2c35
  - [net-next,10/13] ravb: Factorise ravb_set_features
    https://git.kernel.org/netdev/net-next/c/80f35a0df086
  - [net-next,11/13] ravb: Factorise ravb_dmac_init function
    https://git.kernel.org/netdev/net-next/c/eb4fd127448b
  - [net-next,12/13] ravb: Factorise ravb_emac_init function
    https://git.kernel.org/netdev/net-next/c/511d74d9d86c
  - [net-next,13/13] ravb: Add reset support
    https://git.kernel.org/netdev/net-next/c/0d13a1a464a0

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
Sergey Shtylyov Aug. 25, 2021, 10:57 a.m. UTC | #2 
Hello!

On 25.08.2021 13:30, patchwork-bot+netdevbpf@kernel.org wrote:

 > This series was applied to netdev/net-next.git (refs/heads/master):
 >
 > On Wed, 25 Aug 2021 08:01:41 +0100 you wrote:
    Now this is super fast -- I didn't even have the time to promise 
reviewing... :-/

 >> The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are
 >> similar to the R-Car Ethernet AVB IP.
 >>
 >> The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal
 >> TCP/IP Offload Engine (TOE)  and Dedicated Direct memory access controller
 >> (DMAC).
 >>
 >> [...]
 >
 > Here is the summary with links:
 >    - [net-next,01/13] ravb: Remove the macros NUM_TX_DESC_GEN[23]
 >      https://git.kernel.org/netdev/net-next/c/c81d894226b9
 >    - [net-next,02/13] ravb: Add multi_irq to struct ravb_hw_info
 >      https://git.kernel.org/netdev/net-next/c/6de19fa0e9f7
 >    - [net-next,03/13] ravb: Add no_ptp_cfg_active to struct ravb_hw_info
 >      https://git.kernel.org/netdev/net-next/c/8f27219a6191
 >    - [net-next,04/13] ravb: Add ptp_cfg_active to struct ravb_hw_info
 >      https://git.kernel.org/netdev/net-next/c/a69a3d094de3
 >    - [net-next,05/13] ravb: Factorise ravb_ring_free function
 >      https://git.kernel.org/netdev/net-next/c/bf46b7578404
 >    - [net-next,06/13] ravb: Factorise ravb_ring_format function
 >      https://git.kernel.org/netdev/net-next/c/1ae22c19e75c
 >    - [net-next,07/13] ravb: Factorise ravb_ring_init function
 >      https://git.kernel.org/netdev/net-next/c/7870a41848ab
 >    - [net-next,08/13] ravb: Factorise ravb_rx function
 >      https://git.kernel.org/netdev/net-next/c/d5d95c11365b
 >    - [net-next,09/13] ravb: Factorise ravb_adjust_link function
 >      https://git.kernel.org/netdev/net-next/c/cb21104f2c35
 >    - [net-next,10/13] ravb: Factorise ravb_set_features
 >      https://git.kernel.org/netdev/net-next/c/80f35a0df086
 >    - [net-next,11/13] ravb: Factorise ravb_dmac_init function
 >      https://git.kernel.org/netdev/net-next/c/eb4fd127448b
 >    - [net-next,12/13] ravb: Factorise ravb_emac_init function
 >      https://git.kernel.org/netdev/net-next/c/511d74d9d86c
 >    - [net-next,13/13] ravb: Add reset support
 >      https://git.kernel.org/netdev/net-next/c/0d13a1a464a0

    Will have to do a post-merge review again. And I expect more issues here 
than in a previous patch set...

 > You are awesome, thank you!

MBR, Sergey
Andrew Lunn Aug. 25, 2021, 1:46 p.m. UTC | #3 
On Wed, Aug 25, 2021 at 01:57:55PM +0300, Sergey Shtylyov wrote:
> Hello!
> 
> On 25.08.2021 13:30, patchwork-bot+netdevbpf@kernel.org wrote:
> 
> > This series was applied to netdev/net-next.git (refs/heads/master):
> >
> > On Wed, 25 Aug 2021 08:01:41 +0100 you wrote:
>    Now this is super fast -- I didn't even have the time to promise
> reviewing... :-/

2 hours 30 minutes, i think.

Seems like reviews are no longer wanted in netdev.

      Andrew
Sergey Shtylyov Aug. 25, 2021, 2:06 p.m. UTC | #4 
On 8/25/21 4:46 PM, Andrew Lunn wrote:

[...]
>>> This series was applied to netdev/net-next.git (refs/heads/master):
>>>
>>> On Wed, 25 Aug 2021 08:01:41 +0100 you wrote:
>>    Now this is super fast -- I didn't even have the time to promise
>> reviewing... :-/
> 
> 2 hours 30 minutes, i think.

   Took 3 hours 30 mins on my side. :-)

> Seems like reviews are no longer wanted in netdev.

   At least with merge window coming close? 

>       Andrew

MBR, Sergey