| Message ID | 20210825215227.4947-1-stefan.maetje@esd.eu (mailing list archive) |
|---|---|
| Headers | show |
| Series | can: usb: esd_usb2: Fix the interchange of CAN TX and RX error counters | expand |
On 25.08.2021 23:52:26, Stefan Mätje wrote: > In the driver for the esd CAN-USB/2 the CAN RX and TX error counters > were fetched interchanged from the ESD_EV_CAN_ERROR_EXT message and > therefore delivered wrong to the user. > > To verify the now correct behavior call the candump tool to print CAN > error frames with extra infos (including CAN RX and TX error counters) > like "candump -e -x can4,0:0,#fffffffff". > Then send a CAN frame to the open (no other node) but terminated CAN > bus. The TX error counter must increase by 8 for each transmit attempt > until CAN_STATE_ERROR_PASSIVE is reached. > > Stefan Mätje (1): > can: usb: esd_usb2: Fix the interchange of the CAN RX and TX error > counters. > > drivers/net/can/usb/esd_usb2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to linux-can/testing. Thanks, Marc > base-commit: cbe8cd7d83e251bff134a57ea4b6378db992ad82 BTW: Thanks for including a base-commit. Your base is linux-can-next-for-5.15-20210825, but this is a bug-fix patch. It should be based on the latest can pull request, can/master or net/master instead. It doesn't matter here, as the patch applies without problems.
In the driver for the esd CAN-USB/2 the CAN RX and TX error counters were fetched interchanged from the ESD_EV_CAN_ERROR_EXT message and therefore delivered wrong to the user. To verify the now correct behavior call the candump tool to print CAN error frames with extra infos (including CAN RX and TX error counters) like "candump -e -x can4,0:0,#fffffffff". Then send a CAN frame to the open (no other node) but terminated CAN bus. The TX error counter must increase by 8 for each transmit attempt until CAN_STATE_ERROR_PASSIVE is reached. Stefan Mätje (1): can: usb: esd_usb2: Fix the interchange of the CAN RX and TX error counters. drivers/net/can/usb/esd_usb2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) base-commit: cbe8cd7d83e251bff134a57ea4b6378db992ad82