From patchwork Fri Sep 10 16:04:33 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= X-Patchwork-Id: 12485449 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, MSGID_FROM_MTA_HEADER,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 201B0C433FE for ; Fri, 10 Sep 2021 16:05:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F0DEE61205 for ; Fri, 10 Sep 2021 16:05:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229546AbhIJQGq (ORCPT ); Fri, 10 Sep 2021 12:06:46 -0400 Received: from mail-co1nam11on2067.outbound.protection.outlook.com ([40.107.220.67]:25696 "EHLO NAM11-CO1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S229448AbhIJQGp (ORCPT ); Fri, 10 Sep 2021 12:06:45 -0400 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=jTouRQBowvHyCcGB/aCSURxURMakFhDct06BzVWznO7+eZkgbLz+BArJuf9lIYjshLbJTEKHY8GbiPmNKAX/Y7TJvc3xya+HyGNKNRLHWO5UAD0aXpcMM8PUCQrs978esn/VXVOFst9AtxOforqeWnyS1FMcEOJGBs8qzIMfpwy2MzibYpbxeg/G5doxUacqw/bMNfkgWuL+6Wh4BZrUQ2tDHj6lJSZoB3KGdQv2iLTy5RqBeo/reBwHdCYXjrCb+0RbKAMM4o9ogd2Nc9Ajx54NhCzmR9gl/DRuPIl5NSnxrhGnljtw2NqPjp0sI/8CGsshZHjRftBkt2wTyr0djQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=XMICdxmOe3jb3Xembz/d5ptOSsq4dCHTuO6APpZ/tOI=; b=aqXVYzMDuSJPJKyWyeRj6kvutfl+hV1J4B3G/wBQixwFweo0tJjf9w9ZvRr6H/wsOU0Xdo4IpOKZuPcBhbq3bHxXq/3maSLqavfYC33wAQ0cibQxXKD3dxNOyRzp+6oNYiZZc/r6fGnnWxWP2JSmwMm33Sqivxz4CucFIXtqYbCKgt050GVOB9jPtsmRpEgCQF0eZku1ScZPJd4NQ3OkzPFRtwvWsqfck33DHFhBhwbzHIwFrj794hpj+I1Xz26QeeLp1O9QTIxjddfMdOShD0RrNkKCsvtvz03R7ZlR4l74GybBy6D3R6RQ5WekUxbHKpD6S4hWa2b8IA/an2EN7Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=silabs.com; dmarc=pass action=none header.from=silabs.com; dkim=pass header.d=silabs.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=silabs.onmicrosoft.com; s=selector2-silabs-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=XMICdxmOe3jb3Xembz/d5ptOSsq4dCHTuO6APpZ/tOI=; b=VWQTC4DykXCFT85ENLflX42CAJZWaW5BTJ/OpQG7fo8lg9UhcVdD4t3XKSS3QRxXxljpbo11CfLBYylpZk1Whmokk/QXQ6SlNdiqyMYG5yxTE6IH+T6ypFEEYZoZlzDuTqED95382/W9ZrZJWaEikj8lxE5Dk+hNMiy5AcndyEE= Authentication-Results: driverdev.osuosl.org; dkim=none (message not signed) header.d=none;driverdev.osuosl.org; dmarc=none action=none header.from=silabs.com; Received: from SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) by SA0PR11MB4592.namprd11.prod.outlook.com (2603:10b6:806:98::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.17; Fri, 10 Sep 2021 16:05:31 +0000 Received: from SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd]) by SN6PR11MB2718.namprd11.prod.outlook.com ([fe80::7050:a0a:415:2ccd%7]) with mapi id 15.20.4500.017; Fri, 10 Sep 2021 16:05:31 +0000 From: Jerome Pouiller To: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Greg Kroah-Hartman , Kalle Valo , "David S . Miller" , =?utf-8?b?SsOpcsO0bWUgUG91aWxsZXI=?= Subject: [PATCH 00/31] [PATCH 00/31] staging/wfx: usual maintenance Date: Fri, 10 Sep 2021 18:04:33 +0200 Message-Id: <20210910160504.1794332-1-Jerome.Pouiller@silabs.com> X-Mailer: git-send-email 2.33.0 X-ClientProxiedBy: SN4PR0601CA0006.namprd06.prod.outlook.com (2603:10b6:803:2f::16) To SN6PR11MB2718.namprd11.prod.outlook.com (2603:10b6:805:63::18) MIME-Version: 1.0 Received: from pc-42.silabs.com (2a01:e34:ecb5:66a0:9876:e1d7:65be:d294) by SN4PR0601CA0006.namprd06.prod.outlook.com (2603:10b6:803:2f::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.15 via Frontend Transport; Fri, 10 Sep 2021 16:05:29 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 94851b2f-6880-4078-b9d1-08d97474d066 X-MS-TrafficTypeDiagnostic: SA0PR11MB4592: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:8882; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 0BoOrSYSQ58vn7Hm6dZH68xXuJNZYP/sWvnXeAtftGiWL3QAC0ZL2UPlHLGHAswUefD1xoDB5UtqXsrJx1k9kWxFq9uM4aOQGqPjlXiuI4UDAAjl5EGCGdZmevSqWyZqrcGnK/FNNUTcCz0TkjfpxhLsuKOq1jFIQ8EPBGRVz6s4n231lBdniXUIGQKy4oG+lB63bQwq9/WRZBLd/8CS/we5YQbrZsB5hZVAv27PcaShUA5RYhwiCtEOuDqPYdN5iNMg2+lE4QIYmfhc4gxbnt512IazPPgM0UQ/lpy14EG89nQR5mD67oQqwrNJG6KRdOAOKszw2eKcA238Ss8JqOxfpi6FC1ZW1AAYs8hv+5xIYPr81+Y5SRtZrkJjBHoqQecIzrIEDH1fPeRGGKE1M9MlB57MQf3KqeFld/KtbwpajqrV46pKBnhaStmx7qTbsy5qPzysfo6g6bfvtm1WphpdJb+siAar4p2PUy7+4PctFGJKs62rAm335QjTUAfnFeMYwbX3uHtyGlrCjMcmvK9/4oRq+qID3Irw6rYtFlKOzY6yad7lJbOLI24G0cUxUryPy6RbqYmj6Z9MXasXMR7QrFyLNvnO4CsXp5m+yrD5uu4fovOGNUDIcf3pPDFuOxr3528+Drj6XCQO03UIuYfGsNBOElasRaUU9b7D2r1v+FYhzItUqD0hFHgscZk9N7FDxmf9xE+fRoJpB0GYgxMQfv/0fPL1pf2rCKK5lhc= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR11MB2718.namprd11.prod.outlook.com;PTR:;CAT:NONE;SFS:(366004)(508600001)(2906002)(66556008)(6666004)(66476007)(316002)(66946007)(83380400001)(966005)(66574015)(8676002)(8936002)(36756003)(86362001)(6486002)(107886003)(7696005)(52116002)(54906003)(2616005)(5660300002)(4326008)(38100700002)(1076003)(186003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?JfmFrhszDpBM9XkWZTQ5uz3a7EIH?= =?utf-8?q?3hz2w+H2MaPfte/MQx++D3n7VNEs5J9koD0SuHxQ8wkipFDnIeoMirGuk+qi9hqYA?= =?utf-8?q?QHUUua5niVSXotNAz3BkoRIFyKH3ArASec5JZcHa4fMvmQywXF/lORrEL0cmfexKN?= =?utf-8?q?vw0u0Rqy1pJBYAbfAEEezU175BCRzNa/6dzOEtXWJKdmOmh2pbXAZ06g8yz8byKLe?= =?utf-8?q?3s58LvXVm4RiBN8aTA5Pl2PmIYrnv5swdhwB6cl/c/QVlx58JC0VFBoIIcs+zSmJ7?= =?utf-8?q?rtBvDSEkAMhfJGrMlKCE6Q1vBAnp/exZxL2eMn/yAEnYMX7xhgm6hqD3Qi4KTYwc/?= =?utf-8?q?2kxJyajQFwDwNQ5GfydGpZGQojVopu0Lf1OL0tnbEe75Xha2gR3LiKBadZtVKkJdI?= =?utf-8?q?mK6qCt2uBWYkBwZzdhn7hqe9z6kq3BxQ1J+kdFPxn8/YO3PB8sgsZ83z5323Mf5Io?= =?utf-8?q?Uxf3YmbKWkHA3ZF+p89VmYArNe0ffAfIKLDOoTodF1UEOiJtIcLQCQJKpMazEIcWg?= =?utf-8?q?6VwvUaCOkaRAzSDJS+xlzmkJ4fXy/XfB1QEG+ycTzmsW20pvD37Nw91o+tPwe8W6h?= =?utf-8?q?KN1IdyOpwB2dIRvA79wutEyrVS5XLzsC+IZSyPdr2HFSOOPeD+WuITjBPVidUQiTW?= =?utf-8?q?w2z80szjX05LLpcxa+RIYVUtuCHs6X82xH9vx3uZa9DIwz8rlCViFb/GQSbLu01lJ?= =?utf-8?q?fKgjxehYCmp26EdUbvZ9TCAYsIMUev4LJxLxR1179tFWpBjXGNczTXokgSbn3DXqv?= =?utf-8?q?gaFASL/+ZNZZeZ5bElttyhU81OCMxhwfB2wnsaB7G3UExy2mp1hNxVjES+/E79Qyu?= =?utf-8?q?tptPkfSQLDNi6uzLBstYwpcGmBSRr6IiMrzvnkWQXDTxY2gYGYPLijSK3phdGd/Ql?= =?utf-8?q?KGVs15z38oh0Yoo4CGvfFu5OG/n4DNB+CcQKs/2s71wrGtLR7TamX7djwdBnBMbIG?= =?utf-8?q?w/88yroKAcwTtge0IzovQcDIsQ84dv2krZQnq1T1NPFjkBTo6YETKrT+mVCqXxnvj?= =?utf-8?q?iq/xpMsIrZY77/uq7ABSAarDBsPjpDzW1v7VUmHtZZ/yjs0Kdqxe8CHGe8oicR5c4?= =?utf-8?q?EnCQ9OpQ0zFK44jRWarQCbfAF5z3JpwWj/M9DMXUKvxevDR9LRW/P2oPkutHWn6Zi?= =?utf-8?q?EEf7uW6+D6omcLPYcNrdp9E605fzvebDaOTXDOBk1nlAUyLd0oTo63kcKrRLN7Eos?= =?utf-8?q?0c429xaK/T9piyo705JKigkDFFOmBz/564qevn+tBnDlGSCSj9C4Loa+tL95PE6Kl?= =?utf-8?q?CPePdey682HW+mDQxO0U3T3F9vngW6XCIxuQZP0Wm93TNYYRZbhEQHwSqTaXJPeIG?= =?utf-8?q?n1PjBMQoGa/VHOo?= X-OriginatorOrg: silabs.com X-MS-Exchange-CrossTenant-Network-Message-Id: 94851b2f-6880-4078-b9d1-08d97474d066 X-MS-Exchange-CrossTenant-AuthSource: SN6PR11MB2718.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Sep 2021 16:05:31.4635 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 54dbd822-5231-4b20-944d-6f4abcd541fb X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PBPKJBREarbcsuadfL8T5FAqLCo7Vl6/vHqLo1rDd4aXK7cOpvuGptKuu5LwO/Cuyi90gvW6egC87H86vHgwtQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR11MB4592 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org From: Jérôme Pouiller Hi, The following PR contains now usual maintenance for the wfx driver. I have more-or-less sorted the patches by importance: - the first ones are fixes for a few corner-cases reported by users - the patches 9 and 10 add support for CSA and TDLS - then the end of the series is mostly cosmetics and nitpicking I have wait longer than I initially wanted before to send this PR. It is because didn't want to conflict with the PR currently in review[1] to relocate this driver into the main tree. However, this PR started to be very large and nothing seems to move on main-tree side so I decided to not wait longer. Kalle, I am going to send a new version of [1] as soon as this PR will be accepted. I hope you will have time to review it one day :-). [1] https://lore.kernel.org/all/20210315132501.441681-1-Jerome.Pouiller@silabs.com/ Jérôme Pouiller (31): staging: wfx: use abbreviated message for "incorrect sequence" staging: wfx: do not send CAB while scanning staging: wfx: ignore PS when STA/AP share same channel staging: wfx: wait for SCAN_CMPL after a SCAN_STOP staging: wfx: avoid possible lock-up during scan staging: wfx: drop unused argument from hif_scan() staging: wfx: fix atomic accesses in wfx_tx_queue_empty() staging: wfx: take advantage of wfx_tx_queue_empty() staging: wfx: declare support for TDLS staging: wfx: fix support for CSA staging: wfx: relax the PDS existence constraint staging: wfx: simplify API coherency check staging: wfx: update with API 3.8 staging: wfx: uniformize counter names staging: wfx: fix misleading 'rate_id' usage staging: wfx: declare variables at beginning of functions staging: wfx: simplify hif_join() staging: wfx: reorder function for slightly better eye candy staging: wfx: fix error names staging: wfx: apply naming rules in hif_tx_mib.c staging: wfx: remove unused definition staging: wfx: remove useless debug statement staging: wfx: fix space after cast operator staging: wfx: remove references to WFxxx in comments staging: wfx: update files descriptions staging: wfx: reformat comment staging: wfx: avoid c99 comments staging: wfx: fix comments styles staging: wfx: remove useless comments after #endif staging: wfx: explain the purpose of wfx_send_pds() staging: wfx: indent functions arguments drivers/staging/wfx/bh.c | 33 +++---- drivers/staging/wfx/bh.h | 4 +- drivers/staging/wfx/bus_sdio.c | 8 +- drivers/staging/wfx/bus_spi.c | 22 ++--- drivers/staging/wfx/data_rx.c | 7 +- drivers/staging/wfx/data_rx.h | 4 +- drivers/staging/wfx/data_tx.c | 87 +++++++++-------- drivers/staging/wfx/data_tx.h | 6 +- drivers/staging/wfx/debug.c | 54 ++++++----- drivers/staging/wfx/debug.h | 2 +- drivers/staging/wfx/fwio.c | 26 ++--- drivers/staging/wfx/fwio.h | 2 +- drivers/staging/wfx/hif_api_cmd.h | 14 +-- drivers/staging/wfx/hif_api_general.h | 25 ++--- drivers/staging/wfx/hif_api_mib.h | 85 ++++++++-------- drivers/staging/wfx/hif_rx.c | 23 ++--- drivers/staging/wfx/hif_rx.h | 3 +- drivers/staging/wfx/hif_tx.c | 61 +++++------- drivers/staging/wfx/hif_tx.h | 6 +- drivers/staging/wfx/hif_tx_mib.c | 14 +-- drivers/staging/wfx/hif_tx_mib.h | 2 +- drivers/staging/wfx/hwio.c | 6 +- drivers/staging/wfx/hwio.h | 20 ++-- drivers/staging/wfx/key.c | 30 +++--- drivers/staging/wfx/key.h | 4 +- drivers/staging/wfx/main.c | 39 +++++--- drivers/staging/wfx/main.h | 3 +- drivers/staging/wfx/queue.c | 43 ++++---- drivers/staging/wfx/queue.h | 6 +- drivers/staging/wfx/scan.c | 55 +++++++---- drivers/staging/wfx/scan.h | 4 +- drivers/staging/wfx/sta.c | 135 +++++++++++++++----------- drivers/staging/wfx/sta.h | 8 +- drivers/staging/wfx/traces.h | 2 +- drivers/staging/wfx/wfx.h | 14 ++- 35 files changed, 457 insertions(+), 400 deletions(-)