| Message ID | 20210923140813.13541-1-biju.das.jz@bp.renesas.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Add Gigabit Ethernet driver support | expand |
Hello! On 9/23/21 5:07 PM, Biju Das wrote: > The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are > similar to the R-Car Ethernet AVB IP. > > The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal > TCP/IP Offload Engine (TOE) and Dedicated Direct memory access controller > (DMAC). > > With a few changes in the driver we can support both IPs. > > This patch series aims to add Gigabit ethernet driver support to RZ/G2L SoC. > > Please provide your valuable comments. Note to Dav: I will, in the coming couple days... > Ref:- > * https://lore.kernel.org/linux-renesas-soc/TYCPR01MB59334319695607A2683C1A5E86E59@TYCPR01MB5933.jpnprd01.prod.outlook.com/T/#t > > > Biju Das (18): > ravb: Rename "ravb_set_features_rx_csum" function to > "ravb_set_features_rcar" > ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" > ravb: Initialize GbEthernet dmac > ravb: Enable aligned_tx and tx_counters for RZ/G2L > ravb: Exclude gPTP feature support for RZ/G2L > ravb: Add multi_tsrq to struct ravb_hw_info > ravb: Add magic_pkt to struct ravb_hw_info > ravb: Add mii_rgmii_selection to struct ravb_hw_info > ravb: Add half_duplex to struct ravb_hw_info > ravb: Initialize GbEthernet E-MAC > ravb: Add rx_2k_buffers to struct ravb_hw_info > ravb: Add timestamp to struct ravb_hw_info > ravb: Add rx_ring_free function support for GbEthernet > ravb: Add rx_ring_format function for GbEthernet > ravb: Add rx_alloc helper function for GbEthernet > ravb: Add Packet receive function for Gigabit Ethernet > ravb: Add carrier_counters to struct ravb_hw_info > ravb: Add set_feature support for RZ/G2L > > drivers/net/ethernet/renesas/ravb.h | 91 +++- > drivers/net/ethernet/renesas/ravb_main.c | 631 ++++++++++++++++++++--- > 2 files changed, 630 insertions(+), 92 deletions(-) There's a lot of new code.... MBR, Sergey
On 9/23/21 6:11 PM, Sergey Shtylyov wrote: > Hello! > > On 9/23/21 5:07 PM, Biju Das wrote: > >> The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are >> similar to the R-Car Ethernet AVB IP. >> >> The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal >> TCP/IP Offload Engine (TOE) and Dedicated Direct memory access controller >> (DMAC). >> >> With a few changes in the driver we can support both IPs. >> >> This patch series aims to add Gigabit ethernet driver support to RZ/G2L SoC. >> >> Please provide your valuable comments. > > Note to Dav: I will, in the coming couple days... Sorry, I thought I typed DaveM. :-) [...] MBR, Sergey
On Thu, 23 Sep 2021 18:11:49 +0300 Sergey Shtylyov wrote: > > drivers/net/ethernet/renesas/ravb_main.c | 631 ++++++++++++++++++++--- > > 2 files changed, 630 insertions(+), 92 deletions(-) > > There's a lot of new code.... TBH the patches look small an reasonably split to me. Thanks for the "intending to review" note :)
On 9/23/21 6:37 PM, Jakub Kicinski wrote: >>> drivers/net/ethernet/renesas/ravb_main.c | 631 ++++++++++++++++++++--- >>> 2 files changed, 630 insertions(+), 92 deletions(-) >> >> There's a lot of new code.... > > TBH the patches look small an reasonably split to me. They only /look/ reasonably split. :-) > Thanks for the "intending to review" note :) I was afraid DaveM would merge the series without any review. :-) MBR, Sergey
The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are similar to the R-Car Ethernet AVB IP. The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal TCP/IP Offload Engine (TOE) and Dedicated Direct memory access controller (DMAC). With a few changes in the driver we can support both IPs. This patch series aims to add Gigabit ethernet driver support to RZ/G2L SoC. Please provide your valuable comments. Ref:- * https://lore.kernel.org/linux-renesas-soc/TYCPR01MB59334319695607A2683C1A5E86E59@TYCPR01MB5933.jpnprd01.prod.outlook.com/T/#t Biju Das (18): ravb: Rename "ravb_set_features_rx_csum" function to "ravb_set_features_rcar" ravb: Rename the variables "no_ptp_cfg_active" and "ptp_cfg_active" ravb: Initialize GbEthernet dmac ravb: Enable aligned_tx and tx_counters for RZ/G2L ravb: Exclude gPTP feature support for RZ/G2L ravb: Add multi_tsrq to struct ravb_hw_info ravb: Add magic_pkt to struct ravb_hw_info ravb: Add mii_rgmii_selection to struct ravb_hw_info ravb: Add half_duplex to struct ravb_hw_info ravb: Initialize GbEthernet E-MAC ravb: Add rx_2k_buffers to struct ravb_hw_info ravb: Add timestamp to struct ravb_hw_info ravb: Add rx_ring_free function support for GbEthernet ravb: Add rx_ring_format function for GbEthernet ravb: Add rx_alloc helper function for GbEthernet ravb: Add Packet receive function for Gigabit Ethernet ravb: Add carrier_counters to struct ravb_hw_info ravb: Add set_feature support for RZ/G2L drivers/net/ethernet/renesas/ravb.h | 91 +++- drivers/net/ethernet/renesas/ravb_main.c | 631 ++++++++++++++++++++--- 2 files changed, 630 insertions(+), 92 deletions(-)