[net-next,0/6,v8] RTL8366(RB) cleanups part 1

Message

Linus Walleij Sept. 28, 2021, 2:41 p.m. UTC

This is a first set of patches making the RTL8366RB work out of
the box with a default OpenWrt userspace.

We achieve bridge port isolation with the first patch, and the
next 5 patches removes the very weird VLAN set-up with one
VLAN with PVID per port that has been in this driver in all
vendor trees and in OpenWrt for years.

The switch is now managed the way a modern bridge/DSA switch
shall be managed.

After these patches are merged, I will send the next set which
adds new features, some which have circulated before.

ChangeLog v7->v8:
- Keep track of filtering state using the core instead of
  tracking it in the driver.
- Minor spelling etc.

ChangeLog v6->v7:
- Fix up the filter enable/disablement code according to spec.

ChangeLog v5->v6:
- Fix a dangling unused "ret" in patch 4.

ChangeLog v4->v5:
- Drop the patch disabling 4K VLAN.
- Drop the patch forcing VLAN0 untagged.
- Fix a semantic bug in the filer enablement code.

DENG Qingfang (1):
  net: dsa: rtl8366rb: Support bridge offloading

Linus Walleij (5):
  net: dsa: rtl8366: Drop custom VLAN set-up
  net: dsa: rtl8366rb: Rewrite weird VLAN filering enablement
  net: dsa: rtl8366rb: Fix off-by-one bug
  net: dsa: rtl8366: Fix a bug in deleting VLANs
  net: dsa: rtl8366: Drop and depromote pointless prints

 drivers/net/dsa/realtek-smi-core.h |   3 -
 drivers/net/dsa/rtl8366.c          |  96 +--------------
 drivers/net/dsa/rtl8366rb.c        | 189 +++++++++++++++++++++++++++--
 3 files changed, 183 insertions(+), 105 deletions(-)

Comments

Jakub Kicinski Sept. 29, 2021, 12:25 a.m. UTC | #1

On Tue, 28 Sep 2021 16:41:43 +0200 Linus Walleij wrote:
> This is a first set of patches making the RTL8366RB work out of
> the box with a default OpenWrt userspace.
> 
> We achieve bridge port isolation with the first patch, and the
> next 5 patches removes the very weird VLAN set-up with one
> VLAN with PVID per port that has been in this driver in all
> vendor trees and in OpenWrt for years.
> 
> The switch is now managed the way a modern bridge/DSA switch
> shall be managed.
> 
> After these patches are merged, I will send the next set which
> adds new features, some which have circulated before.

Looks like v7 got silently applied. Would you mind converting 
to incremental fixups?

Vladimir Oltean Sept. 29, 2021, 12:49 a.m. UTC | #2

On Tue, Sep 28, 2021 at 05:25:19PM -0700, Jakub Kicinski wrote:
> On Tue, 28 Sep 2021 16:41:43 +0200 Linus Walleij wrote:
> > This is a first set of patches making the RTL8366RB work out of
> > the box with a default OpenWrt userspace.
> >
> > We achieve bridge port isolation with the first patch, and the
> > next 5 patches removes the very weird VLAN set-up with one
> > VLAN with PVID per port that has been in this driver in all
> > vendor trees and in OpenWrt for years.
> >
> > The switch is now managed the way a modern bridge/DSA switch
> > shall be managed.
> >
> > After these patches are merged, I will send the next set which
> > adds new features, some which have circulated before.
>
> Looks like v7 got silently applied. Would you mind converting
> to incremental fixups?

David LRO Miller, merging everything in sight :)

Linus Walleij Sept. 29, 2021, 8:16 a.m. UTC | #3

On Wed, Sep 29, 2021 at 2:25 AM Jakub Kicinski <[e-mail]> wrote:

> > After these patches are merged, I will send the next set which
> > adds new features, some which have circulated before.
>
> Looks like v7 got silently applied. Would you mind converting
> to incremental fixups?

No problem it's just one small incremental change, I'll fix.

Yours,
Linus Walleij