[0/8] Fillup stubs for Gigabit Ethernet driver support

Message

Biju Das Oct. 1, 2021, 4:42 p.m. UTC

The DMAC and EMAC blocks of Gigabit Ethernet IP found on RZ/G2L SoC are
similar to the R-Car Ethernet AVB IP.

The Gigabit Ethernet IP consists of Ethernet controller (E-MAC), Internal
TCP/IP Offload Engine (TOE)  and Dedicated Direct memory access controller
(DMAC).

With a few changes in the driver we can support both IPs.

This patch series is for adding Gigabit ethernet driver support to RZ/G2L SoC.

The number of patches after incorporatng RFC review comments is 18.
So split the patches into 2 patchsets (10 + 8).

This series is the second patchset, aims to fillup all the stubs for the
Gigabit Ethernet driver.

This patch series depend upon [1]
[1] https://lore.kernel.org/linux-renesas-soc/[e-mail]/T/#t

RFC->V1:
 * used rx_max_buf_size instead of rx_2k_buffers feature bit.
 * renamed "rgeth" to "gbeth".
 * renamed ravb_rx_ring_free to ravb_rx_ring_free_rcar
 * renamed ravb_rx_ring_format to ravb_rx_ring_format_rcar
 * renamed ravb_alloc_rx_desc to ravb_alloc_rx_desc_rcar
 * renamed ravb_rcar_rx to ravb_rx_rcar
 * Added Sergey's Rb tag for patch #6.
 * Moved CSR0 initialization to patch #8.

Biju Das (8):
  ravb: Add rx_max_buf_size to struct ravb_hw_info
  ravb: Fillup ravb_rx_ring_free_gbeth() stub
  ravb: Fillup ravb_rx_ring_format_gbeth() stub
  ravb: Fillup ravb_alloc_rx_desc_gbeth() stub
  ravb: Fillup ravb_rx_gbeth() stub
  ravb: Add carrier_counters to struct ravb_hw_info
  ravb: Add support to retrieve stats for GbEthernet
  ravb: Fillup ravb_set_features_gbeth() stub

 drivers/net/ethernet/renesas/ravb.h      |  47 ++++
 drivers/net/ethernet/renesas/ravb_main.c | 327 +++++++++++++++++++++--
 2 files changed, 352 insertions(+), 22 deletions(-)

Comments

Jakub Kicinski Oct. 1, 2021, 6:45 p.m. UTC | #1

On Fri,  1 Oct 2021 17:42:57 +0100 Biju Das wrote:
> This patch series depend upon [1]
> [1] https://lore.kernel.org/linux-renesas-soc/[e-mail]/T/#t

Post it as an RFC, then, please.

Sergey Shtylyov Oct. 1, 2021, 7:16 p.m. UTC | #2

On 10/1/21 9:45 PM, Jakub Kicinski wrote:

>> This patch series depend upon [1]
>> [1] https://lore.kernel.org/linux-renesas-soc/[e-mail]/T/#t
> 
> Post it as an RFC, then, please.

   Please don't merge the above 10 patches until I have a chance to review them. I'll try to start reviewing
them today.

MBR, Sergey

Biju Das Oct. 2, 2021, 7:28 a.m. UTC | #3

Hi Jakub Kicinski,

Thanks for the feedback.

> -----Original Message-----
> From: Jakub Kicinski <[e-mail]>
> Sent: 01 October 2021 19:46
> To: Biju Das <[e-mail]>
> Cc: David S. Miller <[e-mail]>; Sergey Shtylyov
> <[e-mail]>; Prabhakar Mahadev Lad <prabhakar.mahadev-
> [e-mail]>; Andrew Lunn <[e-mail]>; Sergei Shtylyov
> <[e-mail]>; Geert Uytterhoeven <[e-mail]>;
> Adam Ford <[e-mail]>; Yoshihiro Shimoda
> <[e-mail]>; [e-mail]; linux-renesas-
> [e-mail]; Chris Paterson <[e-mail]>; Biju
> Das <[e-mail]>
> Subject: Re: [PATCH 0/8] Fillup stubs for Gigabit Ethernet driver support
> 
> On Fri,  1 Oct 2021 17:42:57 +0100 Biju Das wrote:
> > This patch series depend upon [1]
> > [1]
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flore.ker
> nel.org%2Flinux-renesas-soc%2F20211001150636.7500-1-
> biju.das.jz%40bp.renesas.com%2FT%2F%23t&amp;data=04%7C01%7Cbiju.das.jz%40b
> p.renesas.com%7C05175e47a5464f89a02f08d9850bb7cb%7C53d82571da1947e49cb4625
> a166a4a2a%7C0%7C0%7C637687107650777424%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4
> wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&amp;sdata=T
> fSvrZyyc9%2B%2BOWglDr4Dx0wLqx%2B1tv4toP%2BKaCclp%2FE%3D&amp;reserved=0
> 
> Post it as an RFC, then, please.

Agreed. Will post this patch series as RFC.

Regards,
Biju