[net-next,0/3] net: introduce a function to check if a netdev name is in use

Message

Antoine Tenart Oct. 7, 2021, 4:16 p.m. UTC

Hello,

This was initially part of an RFC series[1] but has value on its own;
hence the standalone report. (It will also help in not having a series
too large).

From patch 1:

"""
__dev_get_by_name is currently used to either retrieve a net device
reference using its name or to check if a name is already used by a
registered net device (per ns). In the later case there is no need to
return a reference to a net device.

Introduce a new helper, netdev_name_in_use, to check if a name is
currently used by a registered net device without leaking a reference
the corresponding net device. This helper uses netdev_name_node_lookup
instead of __dev_get_by_name as we don't need the extra logic retrieving
a reference to the corresponding net device.
"""

Two uses[2] of __dev_get_by_name weren't converted to this new function,
as they are really looking for a net device, not only checking if a net
device name is in use. While checking one or the other currently has
the same result, that might change if the initial RFC series moves
forward. I'll convert them later depending on the outcome of the initial
series.

Thanks,
Antoine

[1] https://lore.kernel.org/all/[e-mail]/
[2] drivers/net/Space.c:130 & drivers/nvme/host/tcp.c:2550

Antoine Tenart (3):
  net: introduce a function to check if a netdev name is in use
  bonding: use the correct function to check for netdev name collision
  ppp: use the correct function to check if a netdev name is in use

 drivers/net/bonding/bond_sysfs.c |  4 ++--
 drivers/net/ppp/ppp_generic.c    |  2 +-
 include/linux/netdevice.h        |  1 +
 net/core/dev.c                   | 14 ++++++++++----
 4 files changed, 14 insertions(+), 7 deletions(-)

Comments

[e-mail] Oct. 8, 2021, 4:30 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Thu,  7 Oct 2021 18:16:49 +0200 you wrote:
> Hello,
> 
> This was initially part of an RFC series[1] but has value on its own;
> hence the standalone report. (It will also help in not having a series
> too large).
> 
> From patch 1:
> 
> [...]

Here is the summary with links:
  - [net-next,1/3] net: introduce a function to check if a netdev name is in use
    https://git.kernel.org/netdev/net-next/c/75ea27d0d622
  - [net-next,2/3] bonding: use the correct function to check for netdev name collision
    https://git.kernel.org/netdev/net-next/c/caa9b35fadff
  - [net-next,3/3] ppp: use the correct function to check if a netdev name is in use
    https://git.kernel.org/netdev/net-next/c/d03eb9787d3a

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html