mbox series

[v2,0/2,net-next] Let spi drivers return 0 in .remove()

Message ID 20211015065615.2795190-1-u.kleine-koenig@pengutronix.de (mailing list archive)
Headers show
Series Let spi drivers return 0 in .remove() | expand

Message

Uwe Kleine-König Oct. 15, 2021, 6:56 a.m. UTC 
Hello,

this series is part of my quest to change the return type of the spi
driver .remove() callback to void. In this first stage I fix all drivers
to return 0 to be able to mechanically change all drivers in the final
step. Here the two spi drivers in net are fixed to obviously return 0.

Returning an error code (which actually very few drivers do) doesn't
make much sense, because the only effect is that the spi core emits an
error message.

The same holds try for platform drivers, one of them is fixed en passant.

There is no need to coordinate application of this series. There is
still much to do until struct spi_driver can be changed.

Changes since v1:

 - Fix a compile error found by the kernel test robot, thanks!

Best regards
Uwe

Uwe Kleine-König (2):
  net: ks8851: Make ks8851_remove_common() return void
  net: w5100: Make w5100_remove() return void

 drivers/net/ethernet/micrel/ks8851.h        | 2 +-
 drivers/net/ethernet/micrel/ks8851_common.c | 4 +---
 drivers/net/ethernet/micrel/ks8851_par.c    | 4 +++-
 drivers/net/ethernet/micrel/ks8851_spi.c    | 4 +++-
 drivers/net/ethernet/wiznet/w5100-spi.c     | 4 +++-
 drivers/net/ethernet/wiznet/w5100.c         | 7 ++++---
 drivers/net/ethernet/wiznet/w5100.h         | 2 +-
 7 files changed, 16 insertions(+), 11 deletions(-)


base-commit: 9e1ff307c779ce1f0f810c7ecce3d95bbae40896

Comments

patchwork-bot+netdevbpf@kernel.org Oct. 18, 2021, 12:10 p.m. UTC | #1 
Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <davem@davemloft.net>:

On Fri, 15 Oct 2021 08:56:13 +0200 you wrote:
> Hello,
> 
> this series is part of my quest to change the return type of the spi
> driver .remove() callback to void. In this first stage I fix all drivers
> to return 0 to be able to mechanically change all drivers in the final
> step. Here the two spi drivers in net are fixed to obviously return 0.
> 
> [...]

Here is the summary with links:
  - [v2,1/2] net: ks8851: Make ks8851_remove_common() return void
    https://git.kernel.org/netdev/net-next/c/2841bfd10aa7
  - [v2,2/2] net: w5100: Make w5100_remove() return void
    https://git.kernel.org/netdev/net-next/c/d40dfa0cebd8

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html