[v4,net-next,0/7] net: dsa: add support for RTL8365MB-VC

Message

Alvin Šipraga Oct. 18, 2021, 9:37 a.m. UTC

From: Alvin Šipraga <[e-mail]>

This series adds support for Realtek's RTL8365MB-VC, a 4+1 port
10/100/1000M Ethernet switch. The driver - rtl8365mb - was developed by
Michael Ramussen and myself.

This version of the driver is relatively slim, implementing only the
standalone port functionality and no offload capabilities. It is based
on a previous RFC series [1] from August, and the main difference is the
removal of some spurious VLAN operations. Otherwise I have simply
addressed most of the feedback. Please see the respective patches for
more detail.

In parallel I am working on offloading the bridge layer capabilities,
but I would like to get the basic stuff upstreamed as soon as possible.

v3 -> v4:
  - get irq before setting virq parents (fixes kernel test robot
    warning)
  - remove pad-to-72-bytes logic in tagger xmit (fixes DENG Qingfang's
    suggestion); no longer needed as we set CPU minimum RX size to 64
    bytes
  - use mutex to protect MIB counter access instead of a spinlock (fixes
    Jakub's feedback on v3 statistics refactoring)

v2 -> v3:
  - move IRQ setup earlier in probe per Florian's suggestion
  - fix compilation error on some archs due to FIELD_PREP use in v1
  - follow Jakub's suggestion and use the standard ethtool stats API;
    NOTE: new patch in the series for relevant DSA plumbing
  - following the stats change, it became apparent that the rtl8366
    helper library is no longer that helpful; scrap it and implement
    the ethtool ops specifically for this chip

v1 -> v2:
  - drop DSA port type checks during MAC configuration
  - use OF properties to configure RGMII TX/RX delay
  - don't set default fwd_offload_mark if packet is trapped to CPU
  - remove port mapping macros
  - update device tree bindings documentation with an example
  - cosmetic changes to the tagging driver using FIELD_* macros

[1] https://lore.kernel.org/netdev/[e-mail]/

Alvin Šipraga (7):
  ether: add EtherType for proprietary Realtek protocols
  net: dsa: allow reporting of standard ethtool stats for slave devices
  net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/Makefile
  dt-bindings: net: dsa: realtek-smi: document new compatible rtl8365mb
  net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag
  net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC
  net: phy: realtek: add support for RTL8365MB-VC internal PHYs

 .../bindings/net/dsa/realtek-smi.txt          |   87 +
 drivers/net/dsa/Kconfig                       |    1 +
 drivers/net/dsa/Makefile                      |    2 +-
 drivers/net/dsa/realtek-smi-core.c            |    4 +
 drivers/net/dsa/realtek-smi-core.h            |    1 +
 drivers/net/dsa/rtl8365mb.c                   | 1982 +++++++++++++++++
 drivers/net/phy/realtek.c                     |    8 +
 include/net/dsa.h                             |    8 +
 include/uapi/linux/if_ether.h                 |    1 +
 net/dsa/Kconfig                               |   20 +-
 net/dsa/Makefile                              |    3 +-
 net/dsa/slave.c                               |   34 +
 net/dsa/tag_rtl8_4.c                          |  178 ++
 13 files changed, 2320 insertions(+), 9 deletions(-)
 create mode 100644 drivers/net/dsa/rtl8365mb.c
 create mode 100644 net/dsa/tag_rtl8_4.c

Comments

[e-mail] Oct. 18, 2021, 1:30 p.m. UTC | #1

Hello:

This series was applied to netdev/net-next.git (master)
by David S. Miller <[e-mail]>:

On Mon, 18 Oct 2021 11:37:55 +0200 you wrote:
> From: Alvin Šipraga <[e-mail]>
> 
> This series adds support for Realtek's RTL8365MB-VC, a 4+1 port
> 10/100/1000M Ethernet switch. The driver - rtl8365mb - was developed by
> Michael Ramussen and myself.
> 
> This version of the driver is relatively slim, implementing only the
> standalone port functionality and no offload capabilities. It is based
> on a previous RFC series [1] from August, and the main difference is the
> removal of some spurious VLAN operations. Otherwise I have simply
> addressed most of the feedback. Please see the respective patches for
> more detail.
> 
> [...]

Here is the summary with links:
  - [v4,net-next,1/7] ether: add EtherType for proprietary Realtek protocols
    https://git.kernel.org/netdev/net-next/c/7bbbbfaa7a1b
  - [v4,net-next,2/7] net: dsa: allow reporting of standard ethtool stats for slave devices
    https://git.kernel.org/netdev/net-next/c/487d3855b641
  - [v4,net-next,3/7] net: dsa: move NET_DSA_TAG_RTL4_A to right place in Kconfig/Makefile
    https://git.kernel.org/netdev/net-next/c/9cb8edda2157
  - [v4,net-next,4/7] dt-bindings: net: dsa: realtek-smi: document new compatible rtl8365mb
    https://git.kernel.org/netdev/net-next/c/2e405875f39f
  - [v4,net-next,5/7] net: dsa: tag_rtl8_4: add realtek 8 byte protocol 4 tag
    https://git.kernel.org/netdev/net-next/c/1521d5adfc2b
  - [v4,net-next,6/7] net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC
    https://git.kernel.org/netdev/net-next/c/4af2950c50c8
  - [v4,net-next,7/7] net: phy: realtek: add support for RTL8365MB-VC internal PHYs
    https://git.kernel.org/netdev/net-next/c/2ca2969aae1e

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html