mbox series

[bpf-next,0/3] "map_extra" and bloom filter fixups

Message ID 20211029224909.1721024-1-joannekoong@fb.com (mailing list archive)
Headers show
Series "map_extra" and bloom filter fixups | expand

Message

Joanne Koong Oct. 29, 2021, 10:49 p.m. UTC
There are 3 patches in this patchset:

1/3 - Bloom filter naming fixups (kernel/bpf/bloom_filter.c)

2/3 - Add alignment padding for map_extra, rearrange fields in
bpf_map struct to consolidate holes

3/3 - Bloom filter tests (prog_tests/bloom_filter_map):
Add test for successful userspace calls, some refactoring to
use bpf_create_map instead of bpf_create_map_xattr

v1 -> v2:
    * In prog_tests/bloom_filter_map: remove unneeded line break,
	also change the inner_map_test to use bpf_create_map instead
	of bpf_create_map_xattr.
    * Add acked-bys to commit messages

Joanne Koong (3):
  bpf: Bloom filter map naming fixups
  bpf: Add alignment padding for "map_extra" + consolidate holes
  selftests/bpf: Add bloom map success test for userspace calls

 include/linux/bpf.h                           |  6 +-
 include/uapi/linux/bpf.h                      |  1 +
 kernel/bpf/bloom_filter.c                     | 49 +++++++--------
 tools/include/uapi/linux/bpf.h                |  1 +
 .../bpf/prog_tests/bloom_filter_map.c         | 59 +++++++++++--------
 5 files changed, 64 insertions(+), 52 deletions(-)

Comments

Joanne Koong Oct. 29, 2021, 10:53 p.m. UTC | #1
Apologies, I forgot to include "v2" in the email header -
this is the second revision of the patchset
(v1 is here: 
https://lore.kernel.org/bpf/20211029224909.1721024-1-joannekoong@fb.com/)

On 10/29/21 3:49 PM, Joanne Koong wrote:
> There are 3 patches in this patchset:
>
> 1/3 - Bloom filter naming fixups (kernel/bpf/bloom_filter.c)
>
> 2/3 - Add alignment padding for map_extra, rearrange fields in
> bpf_map struct to consolidate holes
>
> 3/3 - Bloom filter tests (prog_tests/bloom_filter_map):
> Add test for successful userspace calls, some refactoring to
> use bpf_create_map instead of bpf_create_map_xattr
>
> v1 -> v2:
>      * In prog_tests/bloom_filter_map: remove unneeded line break,
> 	also change the inner_map_test to use bpf_create_map instead
> 	of bpf_create_map_xattr.
>      * Add acked-bys to commit messages
>
> Joanne Koong (3):
>    bpf: Bloom filter map naming fixups
>    bpf: Add alignment padding for "map_extra" + consolidate holes
>    selftests/bpf: Add bloom map success test for userspace calls
>
>   include/linux/bpf.h                           |  6 +-
>   include/uapi/linux/bpf.h                      |  1 +
>   kernel/bpf/bloom_filter.c                     | 49 +++++++--------
>   tools/include/uapi/linux/bpf.h                |  1 +
>   .../bpf/prog_tests/bloom_filter_map.c         | 59 +++++++++++--------
>   5 files changed, 64 insertions(+), 52 deletions(-)
>
Martin KaFai Lau Nov. 1, 2021, 6:02 p.m. UTC | #2
On Fri, Oct 29, 2021 at 03:49:06PM -0700, Joanne Koong wrote:
> There are 3 patches in this patchset:
> 
> 1/3 - Bloom filter naming fixups (kernel/bpf/bloom_filter.c)
> 
> 2/3 - Add alignment padding for map_extra, rearrange fields in
> bpf_map struct to consolidate holes
> 
> 3/3 - Bloom filter tests (prog_tests/bloom_filter_map):
> Add test for successful userspace calls, some refactoring to
> use bpf_create_map instead of bpf_create_map_xattr
> 
> v1 -> v2:
>     * In prog_tests/bloom_filter_map: remove unneeded line break,
> 	also change the inner_map_test to use bpf_create_map instead
> 	of bpf_create_map_xattr.
>     * Add acked-bys to commit messages
Acked-by: Martin KaFai Lau <kafai@fb.com>