mbox series

[net,v2,0/6] mv88e6xxx fixes (mainly 88E6393X family)

Message ID 20211130170151.7741-1-kabel@kernel.org (mailing list archive)
Headers show
Series mv88e6xxx fixes (mainly 88E6393X family) | expand

Message

Marek BehĂșn Nov. 30, 2021, 5:01 p.m. UTC
Hello,

sending v2 of these fixes.

Original cover letter:

So I managed to discovered how to fix inband AN for 2500base-x mode on
88E6393x (Amethyst) family.

This series fixes application of erratum 4.8, adds fix for erratum 5.2,
adds support for completely disablign SerDes receiver / transmitter,
fixes inband AN for 2500base-x mode by using 1000base-x mode and simply
changing frequeny to 3.125 GHz, all this for 88E6393X.

The last commit fixes linking when link partner has AN disabled and the
device invokes the AN bypass feature. Currently we fail to link in this
case.

Changes since v1:
- fixed wrong operator in patch 3 (thanks Russell)
- added more comments about why BMCR_ANENABLE is used in patch 6 (thanks
  Russell)
- updated some return statements from
     if (something)
       return func();
     return 0;
  to
     if (something)
       err = func();
     return err;
  (err is set to 0 before the condition)

Marek

Marek BehĂșn (6):
  net: dsa: mv88e6xxx: Fix application of erratum 4.8 for 88E6393X
  net: dsa: mv88e6xxx: Drop unnecessary check in
    mv88e6393x_serdes_erratum_4_6()
  net: dsa: mv88e6xxx: Save power by disabling SerDes trasmitter and
    receiver
  net: dsa: mv88e6xxx: Add fix for erratum 5.2 of 88E6393X family
  net: dsa: mv88e6xxx: Fix inband AN for 2500base-x on 88E6393X family
  net: dsa: mv88e6xxx: Link in pcs_get_state() if AN is bypassed

 drivers/net/dsa/mv88e6xxx/serdes.c | 252 +++++++++++++++++++++++++----
 drivers/net/dsa/mv88e6xxx/serdes.h |   4 +
 2 files changed, 224 insertions(+), 32 deletions(-)

Comments

patchwork-bot+netdevbpf@kernel.org Dec. 1, 2021, 3 p.m. UTC | #1
Hello:

This series was applied to netdev/net.git (master)
by David S. Miller <davem@davemloft.net>:

On Tue, 30 Nov 2021 18:01:45 +0100 you wrote:
> Hello,
> 
> sending v2 of these fixes.
> 
> Original cover letter:
> 
> So I managed to discovered how to fix inband AN for 2500base-x mode on
> 88E6393x (Amethyst) family.
> 
> [...]

Here is the summary with links:
  - [net,v2,1/6] net: dsa: mv88e6xxx: Fix application of erratum 4.8 for 88E6393X
    https://git.kernel.org/netdev/net/c/21635d9203e1
  - [net,v2,2/6] net: dsa: mv88e6xxx: Drop unnecessary check in mv88e6393x_serdes_erratum_4_6()
    https://git.kernel.org/netdev/net/c/8c3318b4874e
  - [net,v2,3/6] net: dsa: mv88e6xxx: Save power by disabling SerDes trasmitter and receiver
    https://git.kernel.org/netdev/net/c/7527d66260ac
  - [net,v2,4/6] net: dsa: mv88e6xxx: Add fix for erratum 5.2 of 88E6393X family
    https://git.kernel.org/netdev/net/c/93fd8207bed8
  - [net,v2,5/6] net: dsa: mv88e6xxx: Fix inband AN for 2500base-x on 88E6393X family
    https://git.kernel.org/netdev/net/c/163000dbc772
  - [net,v2,6/6] net: dsa: mv88e6xxx: Link in pcs_get_state() if AN is bypassed
    https://git.kernel.org/netdev/net/c/ede359d8843a

You are awesome, thank you!