| Message ID | 20211205150455.1829929-1-m.chetan.kumar@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | net: wwan: iosm: Bug fixes | expand |
On Sun, 5 Dec 2021 20:34:48 +0530 M Chetan Kumar wrote: > This patch series brings in IOSM driver bug fixes. Patch details > are explained below. > > PATCH1: > * stop sending unnecessary doorbell in IP tx flow. > PATCH2: > * set tx queue len. > PATCH3: > * Restore the IP channel configuration after fw flash. > PATCH4: > * Release data channel if there is no active IP session. > PATCH5: > * Removes dead code. > PATCH6: > * Removed the unnecessary check around control port TX transfer. > PATCH7: > * Correct open parenthesis alignment to fix checkpatch warning. Are any of these fixing functional bugs which users may encounter? Looks like at least patches 1, 3, and 6 may be? All the fixes for bugs should have Fixes tags and be posted against the netdev/net tree with [PATCH net] in the subject (meaning a separate series). If there are dependencies between cleanups and fixes - you'll need to defer the cleanups for a few days, until net is merged into net-next. It usually happens every Thursday.
> -----Original Message----- > From: Jakub Kicinski <kuba@kernel.org> > Sent: Wednesday, December 8, 2021 10:52 AM > To: M Chetan Kumar <m.chetan.kumar@linux.intel.com> > Cc: netdev@vger.kernel.org; davem@davemloft.net; > johannes@sipsolutions.net; ryazanov.s.a@gmail.com; > loic.poulain@linaro.org; Sudi, Krishna C <krishna.c.sudi@intel.com>; Kumar, > M Chetan <m.chetan.kumar@intel.com>; linuxwwan > <linuxwwan@intel.com> > Subject: Re: [PATCH V2 net-next 0/7] net: wwan: iosm: Bug fixes > > On Sun, 5 Dec 2021 20:34:48 +0530 M Chetan Kumar wrote: > > This patch series brings in IOSM driver bug fixes. Patch details are > > explained below. > > > > PATCH1: > > * stop sending unnecessary doorbell in IP tx flow. > > PATCH2: > > * set tx queue len. > > PATCH3: > > * Restore the IP channel configuration after fw flash. > > PATCH4: > > * Release data channel if there is no active IP session. > > PATCH5: > > * Removes dead code. > > PATCH6: > > * Removed the unnecessary check around control port TX transfer. > > PATCH7: > > * Correct open parenthesis alignment to fix checkpatch warning. > > Are any of these fixing functional bugs which users may encounter? > > Looks like at least patches 1, 3, and 6 may be? Right 1, 3, & 6 are fixes. 2, 4 are improvement and 5 & 7 are cleanup. > > All the fixes for bugs should have Fixes tags and be posted against the > netdev/net tree with [PATCH net] in the subject (meaning a separate series). > If there are dependencies between cleanups and fixes - you'll need to defer > the cleanups for a few days, until net is merged into net-next. It usually > happens every Thursday. There is no dependency b/w batches. I will break into 2 patch series and submit fixes to netdev/net tree & improvement/cleanups into netdev/net-next tree.
This patch series brings in IOSM driver bug fixes. Patch details are explained below. PATCH1: * stop sending unnecessary doorbell in IP tx flow. PATCH2: * set tx queue len. PATCH3: * Restore the IP channel configuration after fw flash. PATCH4: * Release data channel if there is no active IP session. PATCH5: * Removes dead code. PATCH6: * Removed the unnecessary check around control port TX transfer. PATCH7: * Correct open parenthesis alignment to fix checkpatch warning. Changes since v1: * PATCH2: - For tx queue length use the common DEFAULT_TX_QUEUE_LEN macro instead of defining the new macro. * PATCH4: - Fix checkpath warning. M Chetan Kumar (7): net: wwan: iosm: stop sending unnecessary doorbell net: wwan: iosm: set tx queue len net: wwan: iosm: wwan0 net interface nonfunctional after fw flash net: wwan: iosm: release data channel in case no active IP session net: wwan: iosm: removed unused function decl net: wwan: iosm: AT port is not working while MBIM TX is ongoing net: wwan: iosm: correct open parenthesis alignment drivers/net/wwan/iosm/iosm_ipc_imem.c | 27 +++++++++++++-------- drivers/net/wwan/iosm/iosm_ipc_imem.h | 4 +--- drivers/net/wwan/iosm/iosm_ipc_imem_ops.c | 7 +----- drivers/net/wwan/iosm/iosm_ipc_mmio.c | 2 +- drivers/net/wwan/iosm/iosm_ipc_mux.c | 28 ++++++++++++++-------- drivers/net/wwan/iosm/iosm_ipc_mux.h | 1 - drivers/net/wwan/iosm/iosm_ipc_mux_codec.c | 18 +++++++------- drivers/net/wwan/iosm/iosm_ipc_wwan.c | 3 ++- drivers/net/wwan/iosm/iosm_ipc_wwan.h | 10 -------- 9 files changed, 49 insertions(+), 51 deletions(-) -- 2.25.1