mbox series

[bpf,v2,0/4] Bugfixes for syncookie BPF helpers

Message ID 20220124151146.376446-1-maximmi@nvidia.com (mailing list archive)
Headers show
Series Bugfixes for syncookie BPF helpers | expand

Message

Maxim Mikityanskiy Jan. 24, 2022, 3:11 p.m. UTC 
This series contains generic bugfixes for the syncookie BPF helpers. It
used to be part of series [1], but has been separated to apply to the
bpf branch as fixes.

[1]: https://lore.kernel.org/bpf/20211020095815.GJ28644@breakpoint.cc/t/

Maxim Mikityanskiy (4):
  bpf: Use ipv6_only_sock in bpf_tcp_gen_syncookie
  bpf: Support dual-stack sockets in bpf_tcp_check_syncookie
  bpf: Use EOPNOTSUPP in bpf_tcp_check_syncookie
  bpf: Fix documentation of th_len in bpf_tcp_{gen,check}_syncookie

 include/uapi/linux/bpf.h       |  6 ++++--
 net/core/filter.c              | 21 +++++++++++++++------
 tools/include/uapi/linux/bpf.h |  6 ++++--
 3 files changed, 23 insertions(+), 10 deletions(-)

Comments

John Fastabend Jan. 25, 2022, 7:12 a.m. UTC | #1 
Maxim Mikityanskiy wrote:
> This series contains generic bugfixes for the syncookie BPF helpers. It
> used to be part of series [1], but has been separated to apply to the
> bpf branch as fixes.

2/4 looks like the only real fix here. I think it would be more effective
to push 2/4 with a selftest and get that out of the way. The others are
nice but could go via bpf-next imo and 3/4 can likely be dropped imo. 

Thanks for the fix.
John