[wpan-next,v3,0/4] ieee802154: Improve durations handling

Message

Miquel Raynal Feb. 1, 2022, 6:06 p.m. UTC

These patches try to enhance the support of the various delays by adding
into the core the necessary logic to derive the actual symbol duration
(and then the lifs/sifs durations) depending on the protocol used. The
symbol duration type is also updated to fit smaller numbers.

Having the symbol durations properly set is a mandatory step in order to
use the scanning feature that will soon be introduced.

Changes since v2:
* Added the ca8210 driver fix.
* Fully dropped my rework of the way channels are advertised by device
  drivers. Adapted instead the main existing helper to derive durations
  based on the page/channel couple.

Miquel Raynal (4):
  net: ieee802154: ca8210: Fix lifs/sifs periods
  net: mac802154: Convert the symbol duration into nanoseconds
  net: mac802154: Set durations automatically
  net: ieee802154: Drop duration settings when the core does it already

 drivers/net/ieee802154/at86rf230.c | 33 ------------------
 drivers/net/ieee802154/atusb.c     | 33 ------------------
 drivers/net/ieee802154/ca8210.c    |  3 --
 drivers/net/ieee802154/mcr20a.c    |  5 ---
 include/net/cfg802154.h            |  6 ++--
 net/mac802154/cfg.c                |  1 +
 net/mac802154/main.c               | 54 +++++++++++++++++++++++++++---
 7 files changed, 55 insertions(+), 80 deletions(-)

Comments

Alexander Aring Feb. 6, 2022, 9:58 p.m. UTC | #1

Hi,

On Tue, Feb 1, 2022 at 1:06 PM Miquel Raynal <[e-mail]> wrote:
>
> These patches try to enhance the support of the various delays by adding
> into the core the necessary logic to derive the actual symbol duration
> (and then the lifs/sifs durations) depending on the protocol used. The
> symbol duration type is also updated to fit smaller numbers.
>
> Having the symbol durations properly set is a mandatory step in order to
> use the scanning feature that will soon be introduced.
>
> Changes since v2:
> * Added the ca8210 driver fix.
> * Fully dropped my rework of the way channels are advertised by device
>   drivers. Adapted instead the main existing helper to derive durations
>   based on the page/channel couple.
>
> Miquel Raynal (4):
>   net: ieee802154: ca8210: Fix lifs/sifs periods
>   net: mac802154: Convert the symbol duration into nanoseconds
>   net: mac802154: Set durations automatically
>   net: ieee802154: Drop duration settings when the core does it already
>

Acked-by: Alexander Aring <[e-mail]>

Thanks Stefan. I agree "net: ieee802154: ca8210: Fix lifs/sifs
periods" should go into "wpan".

- Alex

Stefan Schmidt Feb. 10, 2022, 2:52 p.m. UTC | #2

Hello.

On 01.02.22 19:06, Miquel Raynal wrote:
> These patches try to enhance the support of the various delays by adding
> into the core the necessary logic to derive the actual symbol duration
> (and then the lifs/sifs durations) depending on the protocol used. The
> symbol duration type is also updated to fit smaller numbers.
> 
> Having the symbol durations properly set is a mandatory step in order to
> use the scanning feature that will soon be introduced.
> 
> Changes since v2:
> * Added the ca8210 driver fix.
> * Fully dropped my rework of the way channels are advertised by device
>    drivers. Adapted instead the main existing helper to derive durations
>    based on the page/channel couple.
> 
> Miquel Raynal (4):
>    net: ieee802154: ca8210: Fix lifs/sifs periods
>    net: mac802154: Convert the symbol duration into nanoseconds
>    net: mac802154: Set durations automatically
>    net: ieee802154: Drop duration settings when the core does it already
> 
>   drivers/net/ieee802154/at86rf230.c | 33 ------------------
>   drivers/net/ieee802154/atusb.c     | 33 ------------------
>   drivers/net/ieee802154/ca8210.c    |  3 --
>   drivers/net/ieee802154/mcr20a.c    |  5 ---
>   include/net/cfg802154.h            |  6 ++--
>   net/mac802154/cfg.c                |  1 +
>   net/mac802154/main.c               | 54 +++++++++++++++++++++++++++---
>   7 files changed, 55 insertions(+), 80 deletions(-)
> 


This patchset has been applied to the wpan-next tree and will be
part of the next pull request to net-next. Thanks!

regards
Stefan Schmidt