mbox series

[net-next,0/2] net: dsa: realtek: add rtl8_4t tag

Message ID 20220209211312.7242-1-luizluca@gmail.com (mailing list archive)
Headers show
Series net: dsa: realtek: add rtl8_4t tag | expand

Message

Luiz Angelo Daros de Luca Feb. 9, 2022, 9:13 p.m. UTC 
This DSA tag might not be useful in production as the conduit driver
might generate a broken checksum. It is useful, though, for test
purpose.

Luiz

Comments

Alvin Šipraga Feb. 9, 2022, 9:34 p.m. UTC | #1 
Hi Luiz,

Luiz Angelo Daros de Luca <luizluca@gmail.com> writes:

> This DSA tag might not be useful in production as the conduit driver
> might generate a broken checksum. It is useful, though, for test
> purpose.

You make it sound like the code is never useful in production, but is
that really the case? And what kind of test case do you have in mind?

Also, you call this "tailing" which sounds quite off. Do you mean
"trailing"? I think that is the more common terminology.

In any case the series looks fine :-)

Acked-by: Alvin Šipraga <alsi@bang-olufsen.dk>

Kind regards,
Alvin