From patchwork Tue Feb 22 11:54:23 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Zhu, Lingshan" X-Patchwork-Id: 12754951 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 08CC0C433FE for ; Tue, 22 Feb 2022 12:02:20 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231819AbiBVMCm (ORCPT ); Tue, 22 Feb 2022 07:02:42 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48324 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232068AbiBVMCX (ORCPT ); Tue, 22 Feb 2022 07:02:23 -0500 Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 99D0AC4285 for ; Tue, 22 Feb 2022 04:01:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645531317; x=1677067317; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=4I5cTOOHZUo4Oiu7yGPZAkcMJ5aSrduTKuPxDImgv4Q=; b=c2Ha5/O9z+37qRnupHjGuZkQXPreZLFe/aUe2/kxXAh1ZZSNoOFckZft G3OCHuqSQpS4tXdup+TCWHrPJnNgB+B1D5lxjuKNXd1WzdcvlteP7mapt P5KMhdhyW+GiQzseI6VZoIHafKzOswnOZx/Fu9fTJ9pgz7p650dnhcMkt xJn5wVg1eX4cTSB0sYfg1WJ8+1ymcCY0D4qKiMNhSwZe1Mkw5F3qWzZY9 N3uxRBchCyMgnILJispnt7Bjjp3uYWnzoq3g//yqgZ+ZqMWErSQHXTKYP fLJ6HiQQouo6RbCHwTG+P3FnnHlWkmDFyEA3jrHh+QC3DsGmE/fOQ74TN g==; X-IronPort-AV: E=McAfee;i="6200,9189,10265"; a="338117824" X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="338117824" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 04:01:57 -0800 X-IronPort-AV: E=Sophos;i="5.88,387,1635231600"; d="scan'208";a="490772563" Received: from unknown (HELO cra01infra01.deacluster.intel.com) ([10.240.193.73]) by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Feb 2022 04:01:55 -0800 From: Zhu Lingshan To: mst@redhat.com, jasowang@redhat.com Cc: netdev@vger.kernel.org, virtualization@lists.linux-foundation.org, Zhu Lingshan Subject: [PATCH V6 0/5] vDPA/ifcvf: implement shared IRQ feature Date: Tue, 22 Feb 2022 19:54:23 +0800 Message-Id: <20220222115428.998334-1-lingshan.zhu@intel.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org It has been observed that on some platforms/devices, there may not be enough MSI vectors for virtqueues and the config change. Under such circumstances, the interrupt sources of a device have to share vectors/IRQs. This series implemented a shared IRQ feature for ifcvf. Please help review. For the test report, plase kindly refer to V3 cover letter: https://www.spinics.net/lists/netdev/msg795808.html Changes from V5: Removed set but not used variables reported by LKP: struct ifcvf_adapter *ifcvf in ifcvf_hw_enable() struct virtio_pci_common_cfg __iomem *cfg in ifcvf_hw_disable() Changes from V4: (1) Insted of checking errors by themself, set_vq_vector() and set_config_vector() would return the value read from the corresponding registers, then let the caller do error handling. So hw_disable() can use them.(Jason) (2)Use virtio pci modern IO helers than ifcvf_read/write_xxx (Jason) (3)Free all IRQs and vectors once failed in request_irq and its subroutines, don't wait for a restart caused by start_datapath fail or device reset issued from the guest. (4) Better naming: vqs-reused-irq --> vqs_reused_irq, ifcvf_dev_shared_irq --> ifcvf_dev_irq (Michael) (5) A separate patch for ifcvf_hw cacheline alignment(Michael) Changes from V3: fix code indenting issues reported by LKP: Changes from V2: (1) Fix misuse of nvectors(in ifcvf_alloc_vectors return value)(Michael) (2) Fix misuse of irq = get_vq_irq() in setup irqbypass(Michael) (3) Coding style improvements(Michael) (4) Better naming of device shared irq/shared vq irq Changes from V1: (1) Enable config interrupt when only one vector is allocated(Michael) (2) Clean vectors/IRQs if failed to request config interrupt since config interrupt is a must(Michael) (3) Keep local vdpa_ops, disable irq_bypass by setting IRQ = -EINVAL for shared IRQ case(Michael) (4) Improvements on error messages(Michael) (5) Squash functions implementation patches to the callers(Michael) Zhu Lingshan (5): vDPA/ifcvf: make use of virtio pci modern IO helpers in ifcvf vhost_vdpa: don't setup irq offloading when irq_num < 0 vDPA/ifcvf: implement device MSIX vector allocator vDPA/ifcvf: implement shared IRQ feature vDPA/ifcvf: cacheline alignment for ifcvf_hw drivers/vdpa/ifcvf/ifcvf_base.c | 124 +++++-------- drivers/vdpa/ifcvf/ifcvf_base.h | 24 ++- drivers/vdpa/ifcvf/ifcvf_main.c | 317 ++++++++++++++++++++++++++++---- drivers/vhost/vdpa.c | 5 +- 4 files changed, 349 insertions(+), 121 deletions(-)