From patchwork Wed Mar 2 19:25:17 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Krzysztof Kozlowski X-Patchwork-Id: 12766625 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E043CC433EF for ; Wed, 2 Mar 2022 19:25:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237463AbiCBT0M (ORCPT ); Wed, 2 Mar 2022 14:26:12 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40830 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232549AbiCBT0M (ORCPT ); Wed, 2 Mar 2022 14:26:12 -0500 Received: from smtp-relay-internal-1.canonical.com (smtp-relay-internal-1.canonical.com [185.125.188.123]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 77694C1175 for ; Wed, 2 Mar 2022 11:25:28 -0800 (PST) Received: from mail-ej1-f70.google.com (mail-ej1-f70.google.com [209.85.218.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by smtp-relay-internal-1.canonical.com (Postfix) with ESMTPS id 4A3503F1CB for ; Wed, 2 Mar 2022 19:25:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical.com; s=20210705; t=1646249127; bh=yRTE0dXDieeLqipRcJqUM5emUc5L/qHhnbBmseJ0BJU=; h=From:To:Subject:Date:Message-Id:MIME-Version; b=Jv2RtizdGwinP2qfowNk4Ywy1N3i4Q4KpqSWNcUHHCciU02rQOh9NRJcy8qabHJbu qxG2x5iyQ3gMWu/hbhRHljUJihGRtXzGqU5ZAunqmi712EbU+QrAkVL0Oh2PhVwtcK nlEbUkjk1aHXjgzU7rLDsNAVATum8MPAX6jJnfDl410OrIJ0tECM1CF2OvtvA8GGi4 2cgL/nNnH814updnzNUpNqf/bFFMvcoj7gx0ngvb0CbXcY+hVXfwHC8TUtVzFRuSIo uS08M5U2JeamZcKlj7zOtu79Hn+Bbo8fd5KipX7N1g5I3Wn82EViIZMLYFNBeWlrrn PZPsvqiaNOqaQ== Received: by mail-ej1-f70.google.com with SMTP id f1-20020a1709064dc100b006da6dfb4185so1159882ejw.21 for ; Wed, 02 Mar 2022 11:25:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:subject:date:message-id:mime-version :content-transfer-encoding; bh=yRTE0dXDieeLqipRcJqUM5emUc5L/qHhnbBmseJ0BJU=; b=nkh/9KlbS/Q4yXTTzTJVQfW/uX/8O5L3CDZ/NalNJDlt8U9IATB2iC5YQ37EWd6e/b baJm2MAgM0gZ3qlVlX+ZaWlzfTzIjdhYDCWOmN8Hwz52rRLZfbYAAlxCp5YT1sVe/Xwy Sb5FKV3QD9XfmF33H1LLTQ0C8qDvlipWzxWfuWqdXZLW/XVYWiDFkJYmLHe+0KVANfis 1mvKmtu5m1EAxxcwbgCFkjDQeNcDd7v+ycjHWWrr6GYLk22bhCJR2Dt6tfDzPskwbk7N 2AS8FGZ4Fe22+jFesP5k0M9hdIlZdlHV4SLeJdbL1VQ/YltsOF1Ro9pAiilxjvHYKgKN iTOA== X-Gm-Message-State: AOAM531SL7ojgwbYgsWiPzWDIi7tO7DE6yMdnpvTUriSO+neUE/ga2kn MhGKoNcpsMVJjTGbFQlal0OXkqnojiEwssxAuichlUtUId34cDAT9Z59j45OhgWgmZKBc724nq5 YJdv08F6hvzuK1M+Y+YD21HVKGhZM/HOtBA== X-Received: by 2002:a17:906:d964:b0:6ca:4019:3928 with SMTP id rp4-20020a170906d96400b006ca40193928mr24495908ejb.762.1646249127009; Wed, 02 Mar 2022 11:25:27 -0800 (PST) X-Google-Smtp-Source: ABdhPJymNIa6tXZ6VSjhto2ZRHEvmJFRAiiKkV9BB4bSPd2kVGliWkPAB8/SjWMA+lWclcfMKx3gNA== X-Received: by 2002:a17:906:d964:b0:6ca:4019:3928 with SMTP id rp4-20020a170906d96400b006ca40193928mr24495893ejb.762.1646249126792; Wed, 02 Mar 2022 11:25:26 -0800 (PST) Received: from localhost.localdomain (xdsl-188-155-181-108.adslplus.ch. [188.155.181.108]) by smtp.gmail.com with ESMTPSA id i14-20020a50cfce000000b00415b0730921sm1482765edk.42.2022.03.02.11.25.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 02 Mar 2022 11:25:26 -0800 (PST) From: Krzysztof Kozlowski To: Krzysztof Kozlowski , "David S. Miller" , Jakub Kicinski , linux-nfc@lists.01.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [RESEND PATCH v2 0/6] nfc: llcp: few cleanups/improvements Date: Wed, 2 Mar 2022 20:25:17 +0100 Message-Id: <20220302192523.57444-1-krzysztof.kozlowski@canonical.com> X-Mailer: git-send-email 2.32.0 MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Hi, These are improvements, not fixing any experienced issue, just looking correct to me from the code point of view. Changes since v1 ================ 1. Split from the fix. Testing ======= Under QEMU only. The NFC/LLCP code was not really tested on a device. Best regards, Krzysztof Krzysztof Kozlowski (6): nfc: llcp: nullify llcp_sock->dev on connect() error paths nfc: llcp: simplify llcp_sock_connect() error paths nfc: llcp: use centralized exiting of bind on errors nfc: llcp: use test_bit() nfc: llcp: protect nfc_llcp_sock_unlink() calls nfc: llcp: Revert "NFC: Keep socket alive until the DISC PDU is actually sent" net/nfc/llcp.h | 1 - net/nfc/llcp_core.c | 9 +-------- net/nfc/llcp_sock.c | 49 ++++++++++++++++++++++----------------------- 3 files changed, 25 insertions(+), 34 deletions(-)