mbox series

[iproute2-next,v3,0/7] bridge: support for controlling broadcast flooding per port

Message ID 20220309192316.2918792-1-troglobit@gmail.com (mailing list archive)
Headers show
Series bridge: support for controlling broadcast flooding per port | expand

Message

Joachim Wiberg March 9, 2022, 7:23 p.m. UTC
Hi,

this patch set address a slight omission in controlling broadcast
flooding per bridge port, which the bridge has had support for a good
while now.

v3:
  - Move bcast_flood option in manual files to before the mcast_flood
    option, instead of breaking the two mcast options.  Unfortunately
    the other options are not alphabetically sorted, so this was the
    least worst option. (Stephen)
  - Add missing closing " for 'bridge mdb show' in bridge(8) SYNOPSIS
v2:
  - Add bcast_flood also to ip/iplink_bridge_slave.c (Nik)
  - Update man page for ip-link(8) with new bcast_flood flag
  - Update mcast_flood in same man page slightly
  - Fix minor weird whitespace issues causing sudden line breaks
v1:
  - Add bcast_flood to bridge/link.c
  - Update man page for bridge(8) with bcast_flood for brports

Best regards
 /Joachim

Joachim Wiberg (7):
  bridge: support for controlling flooding of broadcast per port
  man: bridge: document new bcast_flood flag for bridge ports
  man: bridge: add missing closing " in bridge show mdb
  ip: iplink_bridge_slave: support for broadcast flooding
  man: ip-link: document new bcast_flood flag on bridge ports
  man: ip-link: mention bridge port's default mcast_flood state
  man: ip-link: whitespace fixes to odd line breaks mid sentence

 bridge/link.c            | 13 +++++++++++++
 ip/iplink_bridge_slave.c |  9 +++++++++
 man/man8/bridge.8        |  8 +++++++-
 man/man8/ip-link.8.in    | 20 +++++++++++++-------
 4 files changed, 42 insertions(+), 8 deletions(-)

Comments

Nikolay Aleksandrov March 10, 2022, 9:01 a.m. UTC | #1
On 09/03/2022 21:23, Joachim Wiberg wrote:
> Hi,
> 
> this patch set address a slight omission in controlling broadcast
> flooding per bridge port, which the bridge has had support for a good
> while now.
> 
> v3:
>   - Move bcast_flood option in manual files to before the mcast_flood
>     option, instead of breaking the two mcast options.  Unfortunately
>     the other options are not alphabetically sorted, so this was the
>     least worst option. (Stephen)
>   - Add missing closing " for 'bridge mdb show' in bridge(8) SYNOPSIS
> v2:
>   - Add bcast_flood also to ip/iplink_bridge_slave.c (Nik)
>   - Update man page for ip-link(8) with new bcast_flood flag
>   - Update mcast_flood in same man page slightly
>   - Fix minor weird whitespace issues causing sudden line breaks
> v1:
>   - Add bcast_flood to bridge/link.c
>   - Update man page for bridge(8) with bcast_flood for brports
> 
> Best regards
>  /Joachim
> 
> Joachim Wiberg (7):
>   bridge: support for controlling flooding of broadcast per port
>   man: bridge: document new bcast_flood flag for bridge ports
>   man: bridge: add missing closing " in bridge show mdb
>   ip: iplink_bridge_slave: support for broadcast flooding
>   man: ip-link: document new bcast_flood flag on bridge ports
>   man: ip-link: mention bridge port's default mcast_flood state
>   man: ip-link: whitespace fixes to odd line breaks mid sentence
> 
>  bridge/link.c            | 13 +++++++++++++
>  ip/iplink_bridge_slave.c |  9 +++++++++
>  man/man8/bridge.8        |  8 +++++++-
>  man/man8/ip-link.8.in    | 20 +++++++++++++-------
>  4 files changed, 42 insertions(+), 8 deletions(-)
> 

Thank you, the patches look good to me.

For the set:
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
patchwork-bot+netdevbpf@kernel.org March 12, 2022, 4:10 p.m. UTC | #2
Hello:

This series was applied to iproute2/iproute2-next.git (main)
by David Ahern <dsahern@kernel.org>:

On Wed,  9 Mar 2022 20:23:09 +0100 you wrote:
> Hi,
> 
> this patch set address a slight omission in controlling broadcast
> flooding per bridge port, which the bridge has had support for a good
> while now.
> 
> v3:
>   - Move bcast_flood option in manual files to before the mcast_flood
>     option, instead of breaking the two mcast options.  Unfortunately
>     the other options are not alphabetically sorted, so this was the
>     least worst option. (Stephen)
>   - Add missing closing " for 'bridge mdb show' in bridge(8) SYNOPSIS
> v2:
>   - Add bcast_flood also to ip/iplink_bridge_slave.c (Nik)
>   - Update man page for ip-link(8) with new bcast_flood flag
>   - Update mcast_flood in same man page slightly
>   - Fix minor weird whitespace issues causing sudden line breaks
> v1:
>   - Add bcast_flood to bridge/link.c
>   - Update man page for bridge(8) with bcast_flood for brports
> 
> [...]

Here is the summary with links:
  - [iproute2-next,v3,1/7] bridge: support for controlling flooding of broadcast per port
    (no matching commit)
  - [iproute2-next,v3,2/7] man: bridge: document new bcast_flood flag for bridge ports
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=3b681cf9c75e
  - [iproute2-next,v3,3/7] man: bridge: add missing closing " in bridge show mdb
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=909f0d510153
  - [iproute2-next,v3,4/7] ip: iplink_bridge_slave: support for broadcast flooding
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=c354a434b1bf
  - [iproute2-next,v3,5/7] man: ip-link: document new bcast_flood flag on bridge ports
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=b1c3ad848c1c
  - [iproute2-next,v3,6/7] man: ip-link: mention bridge port's default mcast_flood state
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=609b90aa3fb1
  - [iproute2-next,v3,7/7] man: ip-link: whitespace fixes to odd line breaks mid sentence
    https://git.kernel.org/pub/scm/network/iproute2/iproute2-next.git/commit/?id=2dee2101f6e9

You are awesome, thank you!